Message ID | 20221205115709.251489-8-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2062979wrr; Sun, 4 Dec 2022 20:31:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf7uWLDU4P+2WJOWcS3C0SnrJ2pR5XTmPrNvy3jSmKJTToUKpDKNvp8giKbrECafEGNSW6Qo X-Received: by 2002:a17:902:8f8b:b0:189:b994:1be with SMTP id z11-20020a1709028f8b00b00189b99401bemr15165528plo.133.1670214686206; Sun, 04 Dec 2022 20:31:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670214686; cv=none; d=google.com; s=arc-20160816; b=stdxsiZXHJJx7ZzNYysc5iCZnx6em+DZmi/mhj5M47fOSopdYZ8xD+lRWLmjxixDRm +Y2P32dETbHSqibDCfe7CnGueK9T+IQGB93aX4CKT2gxVfu7Pz0/8Lc+z5mS+m0YTFNU jjMomJUc/IcGgjb5gGz63ELlmGBxIR5qMBmAWlgAzFrcSeLzpZCTlRH/27SlxIkUDh1V iIOB8Czzs1gpAR7cILG1BKo+8aD6zVvSRWbC4fIECuq2BTTJcVyEyNRfBmOphu55yvLO xPKcA1QLmDIrZs1WI8GKdGOvHsJEx44bfRLpGEHeB+BWxbc/TNwoYbBPT1MbHf1Fs6az Mk3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sXy5CIjzFSZVBbFmACbA8qqJW8BHTI78TRHhZ4fvuiA=; b=eXgWnpZFmNQx/8OHsKBUWf28gtf3uv/k6j9NSQ1gt84WurZCxMEyQgphSw7UYT4pdO XcHnDWQ+21vhOTIQi6jEw8xKTWoU3zzsz+Wk+uo4xBPo5LLM4QwaMGHE3S7HS6PzqaBy jPqPux2T9aCIa6k6vzZIqkCwgvBHwxqjYY5tGCvHKVbeemd92z2RbTfyE04UWuBdjbUt Wv6P5CnQmlFVzQgf5d3fCQgAu4Q5s/eK4FKekKKB5LVVndhO4mrZTnn0Hfbp7TrhjWL+ 0NvzBaC1WvmKVv29kuEmKvcvO/8teWWdDW6WxQlOABEn6wavlL+TMwkFjXDOdAELRXNI /hrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c18-20020a634e12000000b00476f87434ebsi13058845pgb.467.2022.12.04.20.31.12; Sun, 04 Dec 2022 20:31:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231564AbiLED6d (ORCPT <rfc822;jaysivo@gmail.com> + 99 others); Sun, 4 Dec 2022 22:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbiLED6C (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 4 Dec 2022 22:58:02 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62764FCCD; Sun, 4 Dec 2022 19:58:00 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NQVBW2jCQz4f3rq6; Mon, 5 Dec 2022 11:57:55 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDXfq1CbI1jRaRVBg--.57323S9; Mon, 05 Dec 2022 11:57:57 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huawei.com, linfeilong@huawei.com, liuzhiqiang26@huawei.com Subject: [PATCH v3 7/9] blk-throttle: remove incorrect comment for tg_last_low_overflow_time Date: Mon, 5 Dec 2022 19:57:07 +0800 Message-Id: <20221205115709.251489-8-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20221205115709.251489-1-shikemeng@huaweicloud.com> References: <20221205115709.251489-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cCh0CgDXfq1CbI1jRaRVBg--.57323S9 X-Coremail-Antispam: 1UD129KBjvJXoW7WrWkGF47tr4UWrW7Cr4UJwb_yoW8Jw43pr W7tFW8GrsrXws7Kr4Yq3ZxWFWUtw4xJrW3t3sI9rW3AF4fXw1DWFn7CF1rXa1FvF97C3y0 yF43try8G3WUXFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBIb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAv FVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3w A2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE 3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr2 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwCI42IY 6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aV CY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU058n7UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751347034750710386?= X-GMAIL-MSGID: =?utf-8?q?1751347034750710386?= |
Series |
A few bugfix and cleanup patches for blk-throttle
|
|
Commit Message
Kemeng Shi
Dec. 5, 2022, 11:57 a.m. UTC
From: Kemeng Shi <shikemeng@huawei.com> Function tg_last_low_overflow_time is called with intermediate node as following: throtl_hierarchy_can_downgrade throtl_tg_can_downgrade tg_last_low_overflow_time throtl_hierarchy_can_upgrade throtl_tg_can_upgrade tg_last_low_overflow_time throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse from leaf node to sub-root node and pass traversed intermediate node to tg_last_low_overflow_time. No such limit could be found from context and implementation of tg_last_low_overflow_time, so remove this limit in comment. Signed-off-by: Kemeng Shi <shikemeng@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/blk-throttle.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 7db8592dae38..e6a087de414d 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1762,7 +1762,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq;