[v3,9/9] blk-throttle: Use more siutable time_after check for update of slice_start
Message ID | 20221205115709.251489-10-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2062647wrr; Sun, 4 Dec 2022 20:30:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf4bQsq43P2ZH79RI5WqUKE4n4m+659oimR60Xnx5FYaHHLZFz+Wonp+I1tCC2nFOvSamD3z X-Received: by 2002:a17:90b:154e:b0:216:bd62:8e69 with SMTP id ig14-20020a17090b154e00b00216bd628e69mr90303839pjb.205.1670214604448; Sun, 04 Dec 2022 20:30:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670214604; cv=none; d=google.com; s=arc-20160816; b=XAsQuiPifW9lf9qB61HRS9jxvRw0lBqcInIpcvRQU1WidQfvM8F0Ebht9wM1xTWgth 6RzpORGo3+ZczjfyJSxhbogv/noOJ6gq6YbS67EXVaWM+6EK2HVlsgD6FPIhzy4GVboJ ConPDuAUpgkXq7KLXFiveg5ZVwvd1ll4dIEU/hbZ8UEAvyUA/pTZ4+hTHmyWVczGuoxu wtv5JiH/4BTbWbSOjWs0GKM/91OA81ZbzUR+MqmPyWNVjodkN+j+j7pYfh15X21QjOak ChbhOXfLeMCZslYYvED4bKlf8TFBkw8Nw9XfklMXmLcjcEWUzXnJCo0neVkhZ9kLa0ml RRUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iEZ/SG8jdSIoSd31Q0wN+1ueTj0BvDupIDoNEMl4aac=; b=knhV6td/8ANnXE1Qkt1h1yx+NNCOtAtjdqlmI/ELPQTMoohssJghCjgdyS/8BVBITA 98aOPJood3jZ+kcDT3C6jE1BXk3f56Inr1F7X7hHgaWl5hcTDsjR6CgiTsZUjHgptW38 IrwQDJDdMzG/h908pHzfyXioaMHbjZXAb3nCcMcMqaJ2djx5qhFhRQkhp5m+uOEv0gsQ b17mwxeovaW6foBMnjqbFqbujJ78tvUbeuncUlQ1447b6Eph5SvweFgGLdEWRWwNKL5X gWmVL65+6rnmryDy/77Ft4ah5JwrAlsKJupdPgldp7ucvnFIgvvhuVX2nsT1HdQLkS56 CmyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t191-20020a6381c8000000b00478701e57c8si12637715pgd.807.2022.12.04.20.29.44; Sun, 04 Dec 2022 20:30:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231573AbiLED6g (ORCPT <rfc822;jaysivo@gmail.com> + 99 others); Sun, 4 Dec 2022 22:58:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231428AbiLED6E (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 4 Dec 2022 22:58:04 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3ABAFCD3; Sun, 4 Dec 2022 19:58:02 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NQVBX1KfCz4f3rq3; Mon, 5 Dec 2022 11:57:56 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDXfq1CbI1jRaRVBg--.57323S11; Mon, 05 Dec 2022 11:57:58 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huawei.com, linfeilong@huawei.com, liuzhiqiang26@huawei.com Subject: [PATCH v3 9/9] blk-throttle: Use more siutable time_after check for update of slice_start Date: Mon, 5 Dec 2022 19:57:09 +0800 Message-Id: <20221205115709.251489-10-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20221205115709.251489-1-shikemeng@huaweicloud.com> References: <20221205115709.251489-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cCh0CgDXfq1CbI1jRaRVBg--.57323S11 X-Coremail-Antispam: 1UD129KBjvdXoW7XrWDKw45Jr1rKw4fZF4xJFb_yoWDJFX_WF yxArs3Ga4F9ws3CryFyasY9rnFgw17XryDKryrGFW8Z3Z2qr4kJ34UJrsIq39xuF43GFsx tFs7XF4qgFnYgjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUxD7aUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751346949302342795?= X-GMAIL-MSGID: =?utf-8?q?1751346949302342795?= |
Series |
A few bugfix and cleanup patches for blk-throttle
|
|
Commit Message
Kemeng Shi
Dec. 5, 2022, 11:57 a.m. UTC
From: Kemeng Shi <shikemeng@huawei.com> There is no need to update tg->slice_start[rw] to start when they are equal already. So remove "eq" part of check before update slice_start. Signed-off-by: Kemeng Shi <shikemeng@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 413e668249cf..6fb5a2f9e1ee 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -645,7 +645,7 @@ static inline void throtl_start_new_slice_with_credit(struct throtl_grp *tg, * that bandwidth. Do try to make use of that bandwidth while giving * credit. */ - if (time_after_eq(start, tg->slice_start[rw])) + if (time_after(start, tg->slice_start[rw])) tg->slice_start[rw] = start; tg->slice_end[rw] = jiffies + tg->td->throtl_slice;