From patchwork Mon Dec 5 03:34:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 29508 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2049614wrr; Sun, 4 Dec 2022 19:36:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ZnKdwAvsr0kUQA3ArYJno/MRPkaFMwNA1s9CNuv1L048ABcH2KaZ7Qg0wI43LGeNW7Dxw X-Received: by 2002:aa7:daca:0:b0:46b:8078:2431 with SMTP id x10-20020aa7daca000000b0046b80782431mr23033448eds.408.1670211410463; Sun, 04 Dec 2022 19:36:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670211410; cv=none; d=google.com; s=arc-20160816; b=zgN5ngEIpEIGyKksC2PvherF01nMQOl2dG05gpVKT+5SbpTFT7ar4ofEi8Au16yvss G5VgIxXfi+9bO8+fiIpDFz++qVH++tcgstYNRgItGudhK3P+/Cdf/WeHdrekzK64RJOd BS7kGDa1Xra3NDDywylhzWKoRHsVdGItOPP4y7CBYwRv7yj2OePeCb4GU7RKVB/JDQhV AYtR0ZL7nJ0N4OSbsT6QYh8lHMT5Eyr19ffFmFtgutUV+PoehAcQgLe/m/JdeoEwCGSY mN0GQD1QYhPZc31L4EEI2uNaOFcUcd/TxKt4DtX98sN/BwwMRVqlMSJqZP23ApQ7rOQh CCYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=u8vBp7VcD7xXYsmzHWwyi1o619jdjjZGQzFZCRK5hJI=; b=e0U/Z5+oXykWLbfJibG6j7We3P6Aa2SsSQxtb/3gd7tXBvBMyL10D+71TGdouGo7Qh q8gp0CNmiH1wzlG74Fpwe+FCyeJlROoayQivy3xZDuNvm6/fh+Ogh402F9of/gPnusq8 lY8bnbOKPA5BDrS9FToAqyWzdOmVrq7fhXR0kVKv0WnEMgr6nxo4hkio76KcddD9Z7Xs 4oOOMyTn/oPw7KYrF2vspgzjSlOtbwBGZ+HR0RMO5gYAiPJt8bK1KY7gW5Ta9ZAoqz8T Yt7dggnrJIoCXkNgC7xh0jtHfRxjBWEaaJZJI/vsg9s/4NsvjEP3xmyI4tgF0VS8Ia4Y oigw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020aa7cc8a000000b00458bbd3a0d2si9985577edt.602.2022.12.04.19.36.27; Sun, 04 Dec 2022 19:36:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231292AbiLEDev (ORCPT + 99 others); Sun, 4 Dec 2022 22:34:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbiLEDeu (ORCPT ); Sun, 4 Dec 2022 22:34:50 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FE4DF00; Sun, 4 Dec 2022 19:34:48 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NQTgq3DDSz4xVnd; Mon, 5 Dec 2022 11:34:47 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B53YiHx012026; Mon, 5 Dec 2022 11:34:44 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Mon, 5 Dec 2022 11:34:45 +0800 (CST) Date: Mon, 5 Dec 2022 11:34:45 +0800 (CST) X-Zmail-TransId: 2af9638d66d51babae5c X-Mailer: Zmail v1.0 Message-ID: <202212051134455911470@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_rtc=3A_ds1307=3A_use_sysfs=5Femit?= =?utf-8?q?=28=29_to_instead_of_scnprintf=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B53YiHx012026 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638D66D7.001 by FangMail milter! X-FangMail-Envelope: 1670211287/4NQTgq3DDSz4xVnd/638D66D7.001/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638D66D7.001/4NQTgq3DDSz4xVnd X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751343600263389779?= X-GMAIL-MSGID: =?utf-8?q?1751343600263389779?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/rtc/rtc-ds1307.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 7c2276cf5514..def9b7f9d957 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1219,8 +1219,7 @@ static ssize_t frequency_test_show(struct device *dev, regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg); - return scnprintf(buf, PAGE_SIZE, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : - "off\n"); + return sysfs_emit(buf, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : "off\n"); } static DEVICE_ATTR_RW(frequency_test);