From patchwork Mon Dec 5 02:21:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 29501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2030398wrr; Sun, 4 Dec 2022 18:24:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf4sq+D2qDu4bV8yvzaiNDaCdUdopteFp0IuyWq5M2TpSYl6hocfxYHLk8A3rlTF9fQG4Qsi X-Received: by 2002:a17:906:2692:b0:789:d492:89f5 with SMTP id t18-20020a170906269200b00789d49289f5mr70722289ejc.103.1670207055277; Sun, 04 Dec 2022 18:24:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670207055; cv=none; d=google.com; s=arc-20160816; b=n5vVd1xOBHFPxFvR9jdJZup2GAZJ6J5B3jwONzGbJmQ01qkAfITAVZZ/jFRVmNsG/D Rb4kkFNF/wnd2USgQp8NvxDSIs3Ep9xPCMsc603qVGyJoGCBwNZfgE8DgwXbQFHF6F77 CnyDj2ph4FoJujEfOA8y4/AuzrLU0INphcFJ5BYzkffgDf2JtfNp8FfnEnGo1JWaEtOj AMlO/+u0Q8Nf4WjjP/0fcjm30BsHMVlg86GfJ3VHBbE+9hSihc3s6rd0GP6O2mPHthFq AaolSLnznLkErs5yUH3kv9P2eqi9A4IYKpb7I4eeObIGR84VsRhEzegXeFCGattvTQVC 7Gcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=XWEbvMp4T43io6fl9fD6VdHJIw+hpjE399lEWLX1caY=; b=bWgkHZdV0R+JK7HyurAlAEU8ksYXyd3RHXU0WQIQ218TdG6XDH6d+grzAt1ZwBAW9+ uh+yrpIdJqSMCUPwtDq3BPk2CbsQcHEyaFbO9P7FNzOs1gmFYCrWq9e7teD+p6zoH3xy Zw8HXAwORexlI9FtPSnPehIOFTeQ3DuKgbW+uvcSdRIbr8URdgXT5QpKLFeU5dLxROZP 9AQY+t+UtH1PnXD8SSQOu4QofS3VsBPzzjy2Q+zOqJrTYEVbby3grktQnMpuIYKRRlx2 4ILUbyr7sajkgVznrqs542ebHgtYFCKGwlPnYY3K88n76X5evHPpC+0yEXLutcWE6CNx AtKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a1709064fc900b00781dbeebeb1si11736613ejw.585.2022.12.04.18.23.52; Sun, 04 Dec 2022 18:24:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231187AbiLECVz (ORCPT + 99 others); Sun, 4 Dec 2022 21:21:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230402AbiLECVy (ORCPT ); Sun, 4 Dec 2022 21:21:54 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F54212AA6; Sun, 4 Dec 2022 18:21:51 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NQS3f2Q0yz4xVnd; Mon, 5 Dec 2022 10:21:50 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B52LiXx009508; Mon, 5 Dec 2022 10:21:44 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Mon, 5 Dec 2022 10:21:45 +0800 (CST) Date: Mon, 5 Dec 2022 10:21:45 +0800 (CST) X-Zmail-TransId: 2af9638d55b9fffffffff3709c8b X-Mailer: Zmail v1.0 Message-ID: <202212051021451139126@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_net-next_v2=5D_sfc=3A_use_sysfs=5Femit=28=29_to_?= =?utf-8?q?instead_of_scnprintf=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B52LiXx009508 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638D55BE.001 by FangMail milter! X-FangMail-Envelope: 1670206910/4NQS3f2Q0yz4xVnd/638D55BE.001/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638D55BE.001/4NQS3f2Q0yz4xVnd X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751339033270469193?= X-GMAIL-MSGID: =?utf-8?q?1751339033270469193?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen Reviewed-by: Leon Romanovsky Acked-by: Martin Habets --- v1 -> v2 Fix the Subject. drivers/net/ethernet/sfc/efx_common.c | 2 +- drivers/net/ethernet/sfc/siena/efx_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c index c2224e41a694..cc30524c2fe4 100644 --- a/drivers/net/ethernet/sfc/efx_common.c +++ b/drivers/net/ethernet/sfc/efx_common.c @@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev, struct efx_nic *efx = dev_get_drvdata(dev); struct efx_mcdi_iface *mcdi = efx_mcdi(efx); - return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled); + return sysfs_emit(buf, "%d\n", mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev, diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c index 1fd396b00bfb..e4b294b8e9ac 100644 --- a/drivers/net/ethernet/sfc/siena/efx_common.c +++ b/drivers/net/ethernet/sfc/siena/efx_common.c @@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev, struct efx_nic *efx = dev_get_drvdata(dev); struct efx_mcdi_iface *mcdi = efx_mcdi(efx); - return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled); + return sysfs_emit(buf, "%d\n", mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev,