diff mbox series

[net-next,v2] sfc: use sysfs_emit() to instead of scnprintf()

Message ID 202212051021451139126@zte.com.cn
State New
Headers
Series [net-next,v2] sfc: use sysfs_emit() to instead of scnprintf() |

Commit Message

ye.xingchen@zte.com.cn Dec. 5, 2022, 2:21 a.m. UTC 
  From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
v1 -> v2
Fix the Subject.
 drivers/net/ethernet/sfc/efx_common.c       | 2 +-
 drivers/net/ethernet/sfc/siena/efx_common.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Leon Romanovsky Dec. 5, 2022, 7:47 a.m. UTC | #1 
On Mon, Dec 05, 2022 at 10:21:45AM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> v1 -> v2
> Fix the Subject.
>  drivers/net/ethernet/sfc/efx_common.c       | 2 +-
>  drivers/net/ethernet/sfc/siena/efx_common.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Martin Habets Dec. 6, 2022, 8:55 a.m. UTC | #2 
On Mon, Dec 05, 2022 at 10:21:45AM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Martin Habets <habetsm.xilinx@gmail.com>

> ---
> v1 -> v2
> Fix the Subject.
>  drivers/net/ethernet/sfc/efx_common.c       | 2 +-
>  drivers/net/ethernet/sfc/siena/efx_common.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
> index c2224e41a694..cc30524c2fe4 100644
> --- a/drivers/net/ethernet/sfc/efx_common.c
> +++ b/drivers/net/ethernet/sfc/efx_common.c
> @@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
>  	struct efx_nic *efx = dev_get_drvdata(dev);
>  	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
> +	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
>  }
> 
>  static ssize_t mcdi_logging_store(struct device *dev,
> diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c
> index 1fd396b00bfb..e4b294b8e9ac 100644
> --- a/drivers/net/ethernet/sfc/siena/efx_common.c
> +++ b/drivers/net/ethernet/sfc/siena/efx_common.c
> @@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
>  	struct efx_nic *efx = dev_get_drvdata(dev);
>  	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
> +	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
>  }
> 
>  static ssize_t mcdi_logging_store(struct device *dev,
> -- 
> 2.25.1
patchwork-bot+netdevbpf@kernel.org Dec. 7, 2022, 4:50 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 5 Dec 2022 10:21:45 +0800 (CST) you wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] sfc: use sysfs_emit() to instead of scnprintf()
    https://git.kernel.org/netdev/net-next/c/1ab586f5177b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
index c2224e41a694..cc30524c2fe4 100644
--- a/drivers/net/ethernet/sfc/efx_common.c
+++ b/drivers/net/ethernet/sfc/efx_common.c
@@ -1164,7 +1164,7 @@  static ssize_t mcdi_logging_show(struct device *dev,
 	struct efx_nic *efx = dev_get_drvdata(dev);
 	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);

-	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
+	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
 }

 static ssize_t mcdi_logging_store(struct device *dev,
diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c
index 1fd396b00bfb..e4b294b8e9ac 100644
--- a/drivers/net/ethernet/sfc/siena/efx_common.c
+++ b/drivers/net/ethernet/sfc/siena/efx_common.c
@@ -1178,7 +1178,7 @@  static ssize_t mcdi_logging_show(struct device *dev,
 	struct efx_nic *efx = dev_get_drvdata(dev);
 	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);

-	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
+	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
 }

 static ssize_t mcdi_logging_store(struct device *dev,