Message ID | 20221205100808.3595615-1-yangyingliang@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2165111wrr; Mon, 5 Dec 2022 02:19:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf5fweAXBQKUXbibggR9lEFKI99A9U+MDC24RgyzpnkUzyM/oeD8Ee3u0+3IAewCeuW8PSfM X-Received: by 2002:a17:906:3fce:b0:7ad:bb54:75d3 with SMTP id k14-20020a1709063fce00b007adbb5475d3mr67979439ejj.484.1670235593631; Mon, 05 Dec 2022 02:19:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670235593; cv=none; d=google.com; s=arc-20160816; b=uh+WWLAARunYICQTiJ4ck2xIYkmSNVD8XagyokjKCURbmiQxc90b++8pv37nt79Igh ctC6fN21T4mBuccVVdtKh+Vu7CV0wniz/Pdmxr2rAwwm49jiXlLx0cE+pKbCy0VnTTxO ILdXpXAdfzagXUvd+zvE9udM6RKbaX63oRjMABJJsXoHoPTRZFCdLjqXLFC6OCfvwO6F bnmTVaBokLksVeZhvES7mjaxX63iTEXH8tAsGvKszI+s/58X6t57OdZzZ8LlhBj9rCso kTjQuNizv3xhoxPAFmqnm5mVnWZCiKSK+Nx7156CnlUuSoB4eePHBrnTIYr5FKlW1MZi twrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1Ms8YGGJ+lXrMKK02xS48YyKHzqQ4JmGythM1jiAvu0=; b=rtZ58eG0OVqjYIuuQkxkM6l3bdS5B9IV+2Mg2pN6obn0GelD9Nmuo/rAHTYpVdFGuf W5tNawXKOxRW15SYnm5URx/N6w4/Db/zCY1cfvU9m05FlC7NQVqrbV2JeUiHKT7QEbbZ 3nW7d5WAuc3fAOV8C4cWke7jXjeH9vVFM7DOV3aN34jlOvc0sF1F+WsGso9enhvYUgC+ GCZBDKB5TQMVECOeY+e0+bxCqhMrRiCp18qSzsSpHeEK1imlhEWOmz6VzXzr+FHkmOHa /eRhuCsxLLGRTABoCOfzRMIWywSDXaVIRZRVZbLuhnJibZ1Zcm60vIdWuI702i9Ou2Pv 2XZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a1709064ac100b0078def5c29e3si9136148ejt.596.2022.12.05.02.19.29; Mon, 05 Dec 2022 02:19:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbiLEKK4 (ORCPT <rfc822;jaysivo@gmail.com> + 99 others); Mon, 5 Dec 2022 05:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbiLEKKr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 5 Dec 2022 05:10:47 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B3CB18B0A for <linux-kernel@vger.kernel.org>; Mon, 5 Dec 2022 02:10:38 -0800 (PST) Received: from dggpemm500007.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NQfRc5tLqzRpms; Mon, 5 Dec 2022 18:09:48 +0800 (CST) Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec 2022 18:10:32 +0800 From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org> CC: <david@fries.net>, <gregkh@linuxfoundation.org> Subject: [PATCH -next] w1: fix WARNING after calling w1_process() Date: Mon, 5 Dec 2022 18:08:08 +0800 Message-ID: <20221205100808.3595615-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751368957860476455?= X-GMAIL-MSGID: =?utf-8?q?1751368957860476455?= |
Series |
[-next] w1: fix WARNING after calling w1_process()
|
|
Commit Message
Yang Yingliang
Dec. 5, 2022, 10:08 a.m. UTC
I got the following WARNING message while removing driver(ds2482):
------------[ cut here ]------------
do not call blocking ops when !TASK_RUNNING; state=1 set at [<000000002d50bfb6>] w1_process+0x9e/0x1d0 [wire]
WARNING: CPU: 0 PID: 262 at kernel/sched/core.c:9817 __might_sleep+0x98/0xa0
CPU: 0 PID: 262 Comm: w1_bus_master1 Tainted: G N 6.1.0-rc3+ #307
RIP: 0010:__might_sleep+0x98/0xa0
Call Trace:
exit_signals+0x6c/0x550
do_exit+0x2b4/0x17e0
kthread_exit+0x52/0x60
kthread+0x16d/0x1e0
ret_from_fork+0x1f/0x30
The state of task is set to TASK_INTERRUPTIBLE in loop in w1_process(),
set it to TASK_RUNNING when it breaks out of the loop to avoid the
warning.
Fixes: 3c52e4e62789 ("W1: w1_process, block or sleep")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/w1/w1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Please ignore this patch, it's not for next. On 2022/12/5 18:08, Yang Yingliang wrote: > I got the following WARNING message while removing driver(ds2482): > > ------------[ cut here ]------------ > do not call blocking ops when !TASK_RUNNING; state=1 set at [<000000002d50bfb6>] w1_process+0x9e/0x1d0 [wire] > WARNING: CPU: 0 PID: 262 at kernel/sched/core.c:9817 __might_sleep+0x98/0xa0 > CPU: 0 PID: 262 Comm: w1_bus_master1 Tainted: G N 6.1.0-rc3+ #307 > RIP: 0010:__might_sleep+0x98/0xa0 > Call Trace: > exit_signals+0x6c/0x550 > do_exit+0x2b4/0x17e0 > kthread_exit+0x52/0x60 > kthread+0x16d/0x1e0 > ret_from_fork+0x1f/0x30 > > The state of task is set to TASK_INTERRUPTIBLE in loop in w1_process(), > set it to TASK_RUNNING when it breaks out of the loop to avoid the > warning. > > Fixes: 3c52e4e62789 ("W1: w1_process, block or sleep") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/w1/w1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 8b35fae4cd61..4a2ddf730a3a 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -1195,8 +1195,10 @@ int w1_process(void *data) > */ > mutex_unlock(&dev->list_mutex); > > - if (kthread_should_stop()) > + if (kthread_should_stop()) { > + __set_current_state(TASK_RUNNING); > break; > + } > > /* Only sleep when the search is active. */ > if (dev->search_count) {
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 8b35fae4cd61..4a2ddf730a3a 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -1195,8 +1195,10 @@ int w1_process(void *data) */ mutex_unlock(&dev->list_mutex); - if (kthread_should_stop()) + if (kthread_should_stop()) { + __set_current_state(TASK_RUNNING); break; + } /* Only sleep when the search is active. */ if (dev->search_count) {