diff mbox series

objtool: Fix memory leak in create_static_call_sections

Message ID 20221205080642.558583-1-linmq006@gmail.com
State New
Headers
Series objtool: Fix memory leak in create_static_call_sections |

Commit Message

Miaoqian Lin Dec. 5, 2022, 8:06 a.m. UTC 
  strdup() allocates memory for key_name. We need to release the memory in
the following error paths. Add free to avoid memory leak.

Fixes: 1e7e47883830 ("x86/static_call: Add inline static call implementation for x86-64")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 tools/objtool/check.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 43ec14c29a60..55ce695017f8 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -668,6 +668,7 @@  static int create_static_call_sections(struct objtool_file *file)
 		if (strncmp(key_name, STATIC_CALL_TRAMP_PREFIX_STR,
 			    STATIC_CALL_TRAMP_PREFIX_LEN)) {
 			WARN("static_call: trampoline name malformed: %s", key_name);
+			free(key_name);
 			return -1;
 		}
 		tmp = key_name + STATIC_CALL_TRAMP_PREFIX_LEN - STATIC_CALL_KEY_PREFIX_LEN;
@@ -677,6 +678,7 @@  static int create_static_call_sections(struct objtool_file *file)
 		if (!key_sym) {
 			if (!opts.module) {
 				WARN("static_call: can't find static_call_key symbol: %s", tmp);
+				free(key_name);
 				return -1;
 			}