From patchwork Fri Dec 2 16:41:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 29006 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp963234wrr; Fri, 2 Dec 2022 08:50:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6MMQ65JNmFH5YW3lHytkcL5NDb6Hg7OgxSxRmOTTvuTwLNSJYyG41HFCfdbn72bryZDjCJ X-Received: by 2002:a17:902:8bca:b0:189:5b23:2f82 with SMTP id r10-20020a1709028bca00b001895b232f82mr43411420plo.43.1669999832576; Fri, 02 Dec 2022 08:50:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669999832; cv=none; d=google.com; s=arc-20160816; b=kmcapF3I73L2q6ghRHX69gfMaaky6tVqLlTf+ZZr8XzuxDEXNwcFM/GvbYxUioktYa KlGxxvItLUX21QfSlOdkMuo+8s81GlJ3EkNFl1FYQ7fcPzbjLHOCr1oZWgnoTklIAJ7e Umk6h3t2JUSLuO9UwDNgK573/mj0ShfhpP9oE6OQFUxkqc/6LPymS76FX7+Hkz6RQRuJ QXtuH/rtkrUpn+A5YPaIWibrYvRcxVGa76TcGNqUl5HJ4ajdgc+ajs/LEYwNdnAfbkDF z5JQs5WNK/KSRV1GHi1eFStt7SJFfiWbu6sr65V1yswrA/FyNQccTbO64sn2u3+bTlE8 LMEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=NBhUhPdweZ3fTupviVjoDkaZ/Bzxjb/TM6/+Uzw6tYM=; b=sMfhp+r8DrQ5Dr0BDuh0asebxgipmOLdeTsbjIPqMp8hJK7infM33DcX2szDEUvEtj NZF7Jg8XMO+nC/KbVFsHW1FM5MfjdD1LnCv3uEZ5EA/nxy428lPTjMRyF0vX6Qw9JpYJ xkGCptrmEno5w8Y4/qREEl9LoT6Vo6epIUV4C8CHo69ahtlQgI/Vop7JOXrBFrC2fQyV GVHoxBB+maggMeRPsoSKKrPh1p5V47AKq7yaWrrW3Ha7XGglsq162wl1sPLve5cJ/i0u Yx+H2kas/NhegjZCQwK3+G1WcQ+Zdzb3IA4AFBdRj7gBN54dWWRnGEXX1YWsWZG+HeCY zP0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=W3qrvxNW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u30-20020a63235e000000b004541962a9basi7478868pgm.701.2022.12.02.08.50.14; Fri, 02 Dec 2022 08:50:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=W3qrvxNW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233744AbiLBQmH (ORCPT + 99 others); Fri, 2 Dec 2022 11:42:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234087AbiLBQmA (ORCPT ); Fri, 2 Dec 2022 11:42:00 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E42C7243; Fri, 2 Dec 2022 08:42:00 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d1so8606489wrs.12; Fri, 02 Dec 2022 08:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NBhUhPdweZ3fTupviVjoDkaZ/Bzxjb/TM6/+Uzw6tYM=; b=W3qrvxNWQG18OXMSTFZQkIOrmn9ZkqxlS3C/C5VDGgmacy8F6t4GEmPN7+nIzI3R1W UQjqIBsFhs2EmDiU4IouSTnNwPv6jUb97Il4+HByArzo6uADGnPWEGKJLJ0rOnvWxX1Q f7y6wk9Q+rYhTodh2rXoXvfytFFWNLtzU0x8mLSiy9Oj/a0izKbpcO//QAVdGSHCTEQg x7K8L8ymNYZvoApuerQTVuOL6ysZ97HpDjOG0FG8GgNNUBbRBrKcD2VJFGysU5557HPv 5o7o9qy8DYTXJzniz5BXdgMtT2ot4J5sVDErgRFSi7f57gVONYVkQTVbHGLr6WJsqv3J dNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NBhUhPdweZ3fTupviVjoDkaZ/Bzxjb/TM6/+Uzw6tYM=; b=HrmbnKlJ9KIXdDGDUkGCJ6p0MIkiu2LQB90jCvNcOPVSEVWeBI6/6qx/J8/jGZtnf6 ElgbccdIcQdDtNVto0GCbPSBOvEqdHaKcCGw6nQrAihiEV8nXoXuIzYZHL04T8bt+7oh Uce2tpbBJ9hh01cXqJYg5OVjmt75J7dIWOY4ddoZNpsz1AtPgfPefis+p5+3lUfD4I66 1pBoGuvYXdlvN38Tg2InopRkzwJuVO4TCAtuRsFWrwUfkfHPJh6pdR0/2i8nfOvZ5cGu uBG15sIf3aFEcQXD/+aQmaWixmbZUqchEsaFElkO/usAiy+4vdM2sh8NWfOt+FC+YsUr B1Kw== X-Gm-Message-State: ANoB5pl2xu4xDP5U9c1Q55nC7ewk2waxQ8sCF7341+/JAN+gXbR1/dnQ LG2WklM0EK8urOpecnZwkLo0xbekiIbDTVU7 X-Received: by 2002:a5d:46d1:0:b0:242:4698:f0a7 with SMTP id g17-20020a5d46d1000000b002424698f0a7mr2151557wrs.77.1669999318410; Fri, 02 Dec 2022 08:41:58 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id q17-20020a05600000d100b0024207ed4ce0sm7491149wrx.58.2022.12.02.08.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 08:41:57 -0800 (PST) From: Colin Ian King To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kunihiko Hayashi , Masami Hiramatsu , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] ASoC: uniphier: aio-core: Make some read-only arrays static const Date: Fri, 2 Dec 2022 16:41:56 +0000 Message-Id: <20221202164156.1812971-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751121744426250432?= X-GMAIL-MSGID: =?utf-8?q?1751121744426250432?= Don't populate the read-only arrays slotsel_2ch, slotsel_multi, v_pll and v_div on the stack but instead make them static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- sound/soc/uniphier/aio-core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c index b8195778953e..0eba60758134 100644 --- a/sound/soc/uniphier/aio-core.c +++ b/sound/soc/uniphier/aio-core.c @@ -277,17 +277,18 @@ void aio_port_reset(struct uniphier_aio_sub *sub) static int aio_port_set_ch(struct uniphier_aio_sub *sub) { struct regmap *r = sub->aio->chip->regmap; - u32 slotsel_2ch[] = { + static const u32 slotsel_2ch[] = { 0, 0, 0, 0, 0, }; - u32 slotsel_multi[] = { + static const u32 slotsel_multi[] = { OPORTMXTYSLOTCTR_SLOTSEL_SLOT0, OPORTMXTYSLOTCTR_SLOTSEL_SLOT1, OPORTMXTYSLOTCTR_SLOTSEL_SLOT2, OPORTMXTYSLOTCTR_SLOTSEL_SLOT3, OPORTMXTYSLOTCTR_SLOTSEL_SLOT4, }; - u32 mode, *slotsel; + u32 mode; + const u32 *slotsel; int i; switch (params_channels(&sub->params)) { @@ -515,13 +516,13 @@ static int aio_port_set_clk(struct uniphier_aio_sub *sub) struct uniphier_aio_chip *chip = sub->aio->chip; struct device *dev = &sub->aio->chip->pdev->dev; struct regmap *r = sub->aio->chip->regmap; - u32 v_pll[] = { + static const u32 v_pll[] = { OPORTMXCTR2_ACLKSEL_A1, OPORTMXCTR2_ACLKSEL_F1, OPORTMXCTR2_ACLKSEL_A2, OPORTMXCTR2_ACLKSEL_F2, OPORTMXCTR2_ACLKSEL_A2PLL, OPORTMXCTR2_ACLKSEL_RX1, }; - u32 v_div[] = { + static const u32 v_div[] = { OPORTMXCTR2_DACCKSEL_1_2, OPORTMXCTR2_DACCKSEL_1_3, OPORTMXCTR2_DACCKSEL_1_1, OPORTMXCTR2_DACCKSEL_2_3, };