From patchwork Fri Dec 2 15:12:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 28939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp916531wrr; Fri, 2 Dec 2022 07:17:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf5pI+U0eyLd7Yomc/BoQQD4YcRFmI26KE26WLpS0y6BRmaqCrh2rj42KhsmJnAMSJIpV3YY X-Received: by 2002:a17:906:d85:b0:7c0:cc5d:e05a with SMTP id m5-20020a1709060d8500b007c0cc5de05amr1566623eji.44.1669994232435; Fri, 02 Dec 2022 07:17:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669994232; cv=none; d=google.com; s=arc-20160816; b=om9hxJA/TXg/8OLmKkINEDBxn5BvS3LyQxJCyb4PQd/OkTW27oN92DA1EreUa5q4Ks OsuQS/GQqp0teap6q1v3xgmsWSytyNK6GSqNhG65bnNBxQPCUlgFgQjx7nGaEduMTr2O Cx/NKdIqkEjphpPAV4tuH6xYPCAKLCHaRf6wJS3B9/KYN2S3qwkakrrYIi16E8bwGRI9 k0Os77oT32uwaTVSNgJl+xXtNZowI1GA9W1Wt/zGnM3Prat+e9j3ZSnI65SiDFobnM03 Az65G/QtixtJ72rmLFprlcehHkT9wSJtjK0lXovISzpA1btaAa5239WLXDkWKJ2YpnCO WPbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9N5iGN9naDmEHyePTLp/VNDqNAqfYj5SwKQDYp+5n08=; b=SYbUmGvyJbEHP9BwRTVYoAgOnl0PLl0hVX4yXE0h0xgixlPBJhFgb7WDQ61EpkMDT6 Nes9ScxhYta2ZcASX5Lz2aKJfiQG9bs+ZvCkzLJS4LycHB1IukfttiVaLjMHn6ieljrJ vj1BSt2ikzA8qbwlf1cJKkhx7Hu5ysRDfRMtjhAReksoZXVkR1Yqrtrd50bExplS9Ixu Uo9MXQuqWSu7BIqs/1gaLvl6noRgzed1qX/N/xR3fTILnnCW0I7kjwG+AL92YaHHDZK6 Q82k11KK4KArKUkPtUivKcJE3nrkp75zJPSTg9NOxDHcjfCPaP9AsRPstshwnoFYPs8d JGwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=ukgDRQFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020aa7c551000000b0046c3f90f602si953383edr.600.2022.12.02.07.16.48; Fri, 02 Dec 2022 07:17:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=ukgDRQFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233751AbiLBPMa (ORCPT + 99 others); Fri, 2 Dec 2022 10:12:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbiLBPMQ (ORCPT ); Fri, 2 Dec 2022 10:12:16 -0500 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09547A5574; Fri, 2 Dec 2022 07:12:14 -0800 (PST) Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id BC8662008; Fri, 2 Dec 2022 16:12:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1669993932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N5iGN9naDmEHyePTLp/VNDqNAqfYj5SwKQDYp+5n08=; b=ukgDRQFSLv9COkH21ixYjveituhMhPvZ2feOojDvvWOAcpBbwvbMfJ5GanDphDxuiX4MNN e1wKUbMydRsnmvjpgJlWEkEIIKpYntMtawxyOLpesfv7wpKcstyAj7Q5+PTK91rTEhE2pc qQRRQNVk59seNeC6/8zXqYF1jvN0BLMh66VRNbyBJ2wRMHm2dFYzARIWO/E1bm0SipIOt4 agiwA2bA2reTHb80H+vUaZ9ynVC0Ci5jaCMRX30CVx4QD0dsMmc7HvX2bFn3lzWXJN4Bfu 13j7fBYlterynoHWa+2kGIyR1ZiI0a0hikVoJiBljEiQQsgY6Hs4Rn6K6vYbmg== From: Michael Walle To: Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Michael Walle Subject: [PATCH net-next v1 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default Date: Fri, 2 Dec 2022 16:12:04 +0100 Message-Id: <20221202151204.3318592-5-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202151204.3318592-1-michael@walle.cc> References: <20221202151204.3318592-1-michael@walle.cc> MIME-Version: 1.0 X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751115872250528257?= X-GMAIL-MSGID: =?utf-8?q?1751115872250528257?= The interrupts on the GPY215B and GPY215C are broken and the only viable fix is to disable them altogether. There is still the possibilty to opt-in via the device tree. Signed-off-by: Michael Walle --- drivers/net/phy/mxl-gpy.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 20e610dda891..edb8cd8313b0 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c @@ -12,6 +12,7 @@ #include #include #include +#include #include /* PHY ID */ @@ -290,6 +291,10 @@ static int gpy_probe(struct phy_device *phydev) phydev->priv = priv; mutex_init(&priv->mbox_lock); + if (gpy_has_broken_mdint(phydev) && + !device_property_present(dev, "maxlinear,use-broken-interrupts")) + phydev->irq = PHY_POLL; + fw_version = phy_read(phydev, PHY_FWV); if (fw_version < 0) return fw_version;