From patchwork Fri Dec 2 02:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhang.songyi@zte.com.cn X-Patchwork-Id: 28670 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp611746wrr; Thu, 1 Dec 2022 18:54:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vwwOVUbfMmWudRbAM1WpUPbZluFq2PFGdsHMJIl15q8UtZGg74G3PDoprk977i+vrwQ+s X-Received: by 2002:a17:906:b088:b0:7bd:6295:cdd with SMTP id x8-20020a170906b08800b007bd62950cddmr25901144ejy.534.1669949641795; Thu, 01 Dec 2022 18:54:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669949641; cv=none; d=google.com; s=arc-20160816; b=MzgIn4MeJr1dhztqiT/HkWqSUR1WrtHfjMQj3wmQrPvfjPu/G0V9Gmj0vmESosuYUG 9KTrqiYdqYQgNiIQ6uwvYVM+8fU8Q3kM0YKZPM8bLugLQVPqNVFcNM+g/GKqXGuUUyDQ F8rdi+WDluGWzUNmtd0KaDvc9+tK/8emHbrgEiSNu5+p+g2d9qgnpRhKrynjGJf3bpR2 tXU9kqX4KWXxy6+75E2OFYS9+5410ioG3KxJOPYfVnPQlc3k1ihZSQCUuTGHl7jdpfmO VK8yPKrVUs9lD+g7CwRXxWn2kVKoFsGXpyXxLrnE8WbEn7ezqKzkKQNmm6ZLzXWFHCCF dlSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=CkkHOp3nbNyshJQmfC/UE7g/uIE9d/T/gg++EQ1PN9c=; b=zOZk1Ci90boDPzpusOXKrm5h1JzhHbkdspwEw7zlBoIMz7QhvIuyfR9hMAPEJIBedg yZ9h7N/bDqPySn4dkSY+A8YulYk585MICPOudMFrMJsKY0ktFY772rVgKpf20qKbTBz+ AMh9w93aHpVwCgan5+vvht0Fg9RRBIKjRp0KagN9MMZ7okRNVhBv6J/S3YH/CmpHuHwO FQQeGpzSDfacQfMzZVZn85VMIUSfGOnetWqXMA+++xIZVsNF2PexF3a+4K/VF8Kct1Hl 0zGVi7zbe0P1MXr4eDraegaIsYy7WPhMybTdvF+Bmfx571mpaCNysm8fo0ECzbQH3/MN TGQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf30-20020a1709077f1e00b007ae72eabbe0si4969906ejc.928.2022.12.01.18.53.38; Thu, 01 Dec 2022 18:54:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232068AbiLBCmX (ORCPT + 99 others); Thu, 1 Dec 2022 21:42:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbiLBCmV (ORCPT ); Thu, 1 Dec 2022 21:42:21 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CCFD11FA for ; Thu, 1 Dec 2022 18:42:20 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NNcfg35Hrz4xVnn; Fri, 2 Dec 2022 10:42:19 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B22g3kg039926; Fri, 2 Dec 2022 10:42:03 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Fri, 2 Dec 2022 10:42:04 +0800 (CST) Date: Fri, 2 Dec 2022 10:42:04 +0800 (CST) X-Zmail-TransId: 2af9638965fcffffffff86bec3ce X-Mailer: Zmail v1.0 Message-ID: <202212021042043546303@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , Subject: =?utf-8?q?=5BPATCH_linux-next_v2=5D_pxa=3A_Remove_dev=5Ferr=28=29_a?= =?utf-8?q?fter_platform=5Fget=5Firq=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B22g3kg039926 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 6389660B.000 by FangMail milter! X-FangMail-Envelope: 1669948939/4NNcfg35Hrz4xVnn/6389660B.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 6389660B.000/4NNcfg35Hrz4xVnn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751069115893648032?= X-GMAIL-MSGID: =?utf-8?q?1751069115893648032?= From: zhang songyi There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Signed-off-by: zhang songyi Reviewed-by: Lubomir Rintel --- drivers/soc/pxa/ssp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..bd029e838241 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev) } ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - } if (dev->of_node) { const struct of_device_id *id =