From patchwork Fri Dec 2 09:48:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edmund Berenson X-Patchwork-Id: 28841 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp747857wrr; Fri, 2 Dec 2022 02:11:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf7LnwVbRxxZ5U9WJqiXSw6XFeDg8yGGUC+zp4fh+/whCHJXp/5OU1nJN5GoNLM/a5vPZX4B X-Received: by 2002:a17:906:2810:b0:7b2:7b45:2bf6 with SMTP id r16-20020a170906281000b007b27b452bf6mr43623013ejc.467.1669975874277; Fri, 02 Dec 2022 02:11:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669975874; cv=none; d=google.com; s=arc-20160816; b=WtguCZgHaIjAXJEi5OPUxnt13SoMV9gUKmXq5HhrqkWrQEcFiQgYRBP3H1fg23Y+1+ FoDh/0TdDepr9swKqc5eBg2JQxXli5Dh1Q5StgNv3s5OEweAZpcXP4v3YPm+RbelNczw JUMvTf78ZEtjcBRe5rx76u0Nrme8yE5CtXOzRVRlwAA99dpE8nP0mn7cDtr+LZCVzxtb M6vYS3KT0mCglfC/cNo6pVrT0++YVnzu4OBMmTTY7/tUb4MJsSEKXvultT5RudCcH0kC jNc3QIctZCeL83LPrCcDKxAa3P++8a/Sg4ZYyvBUpgfWgHrqNhM1eH7CJYmTf/d0YaxZ i0jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from; bh=no0/j1uS8ky8ai40Jk+S87FnRVKqYBea51HAJ6XVcdU=; b=MWXuADWnne+nGixuW1iXnx5A4UCWvLn0wd5jXcqVeRCZDgblmywJNi/q4orxcW6Epq 33KWv07WbWEClci5QGO3uQQH7pToLuNPAQPVZbeF9X4pz7eB/TSiCGOX5NELji0Azqzv FyaIo5IScsmEQhMsAYq4xUM3NCmngZtmCdmmZ7xRpPd9bf8znAQvFEUAADa5SYVxYqa9 u6QCt2VwgTdmYJyZrOGM1QcmOJ4KZRkS+u37lnurkNc1PNvqe735nLEq2zvS8ZtGacXy qiBbc+IZbeHz79f3UQqMNR8Ovq76briuiKQnApoJJvKveawepwqfkzDcP73JsAOqw7Sn rs9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a50d751000000b00459c1e64776si5457482edj.412.2022.12.02.02.10.49; Fri, 02 Dec 2022 02:11:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232784AbiLBJtZ (ORCPT + 99 others); Fri, 2 Dec 2022 04:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231449AbiLBJtY (ORCPT ); Fri, 2 Dec 2022 04:49:24 -0500 Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E05C868A for ; Fri, 2 Dec 2022 01:49:22 -0800 (PST) Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id C25FD5FCDC; Fri, 2 Dec 2022 10:49:20 +0100 (CET) From: Edmund Berenson Cc: Edmund Berenson , Lukasz Zemla , Serge Semin , Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] spi: dw: select SS0 when gpio cs is used Date: Fri, 2 Dec 2022 10:48:59 +0100 Message-Id: <20221202094859.7869-1-edmund.berenson@emlix.com> X-Mailer: git-send-email 2.37.4 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751096622496656450?= X-GMAIL-MSGID: =?utf-8?q?1751096622496656450?= SER register contains only 4-bit bit-field for enabling 4 SPI chip selects. If gpio cs are used the cs number may be >= 4. To ensure we do not write outside of the valid area, we choose SS0 in case of gpio cs to start spi transfer. Co-developed-by: Lukasz Zemla Signed-off-by: Lukasz Zemla Signed-off-by: Edmund Berenson --- drivers/spi/spi-dw-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index 99edddf9958b..57c9e384d6d4 100644 --- a/drivers/spi/spi-dw-core.c +++ b/drivers/spi/spi-dw-core.c @@ -94,6 +94,10 @@ void dw_spi_set_cs(struct spi_device *spi, bool enable) { struct dw_spi *dws = spi_controller_get_devdata(spi->controller); bool cs_high = !!(spi->mode & SPI_CS_HIGH); + u8 enable_cs = 0; + + if (!spi->cs_gpiod) + enable_cs = spi->chip_select; /* * DW SPI controller demands any native CS being set in order to @@ -103,7 +107,7 @@ void dw_spi_set_cs(struct spi_device *spi, bool enable) * support active-high or active-low CS level. */ if (cs_high == enable) - dw_writel(dws, DW_SPI_SER, BIT(spi->chip_select)); + dw_writel(dws, DW_SPI_SER, BIT(enable_cs)); else dw_writel(dws, DW_SPI_SER, 0); }