Message ID | 20221202085554.59637-13-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp723398wrr; Fri, 2 Dec 2022 01:00:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf7RsGPthVzXreTZH61NVba2SGW7rb8D6qF9ydbzG1FsiEUjmQeEkuBggQb0WZRkWB8LO9hB X-Received: by 2002:aa7:c754:0:b0:46b:6096:a884 with SMTP id c20-20020aa7c754000000b0046b6096a884mr16998863eds.152.1669971632290; Fri, 02 Dec 2022 01:00:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669971632; cv=none; d=google.com; s=arc-20160816; b=lOC6lxjII/o4OJCp9Y152+wTMo4AGCsZOb/SGr1nOXmB0DHPVibHhVRrXAZwVv28W0 OPfEOZHVmw4EBiSLIjOnRh2AobEVor/UWeDYoZflKmA9mX+gvxZ36nP0NmZ5MWnMy0A2 k/il1XJTdmArdJZBOsLj6LXMCHyMVwEnHwHKuVa3QTuY/8Ur5ybJoQrv0RquDptyTD/j CILY9jB6i00wsC4ieQrt0cFBZMQ8jiUe6SCEc3gxoXv8Tvy+SgTjgYr0DYtKqkLQ2bjp dy2aAJiaMjMlRXlIgn0Lq8nV0OeT8+7oGYkygLZ4hbixkPUcB20L9td8u4Ti/VgDIn+0 WgSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7Oo6s6EUUJAHLwqnGgZFQJNt6SIn7i9VCkQpm/Vrbzo=; b=ZCBNc2cRSRn4SckVMUP1LSm3vtcgxHUgrfs6WMoEYDbPjhszAuTVTBZ5szmlsquMM7 iyKZV8uQEs1JrN45q5epHUBA/Kiohdi6/xgysgiHy7y1TjdMQAPrOLfgE2GUw2zLWOx/ ZmBMs4s24dLQDju/N6G2IsNnY9jBDq7KfK+/parzN/2KiNlPyxLZqJXgDzAQN8MFDKW7 CRQVZ2jCcYHV08YAcPs2abAS8/aRucBD/sVafFbG1o2gBzzaKbtEjki+G6B+z04a6DPj bN8ERrrnYDH4QHxpTmwl9aVyHBo6b8MxzTE52nz41s2qWhsaAvLIPZAb+m6J6hedO4T/ DFug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b="kV1V5/gf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a170906974900b0078d484e0e79si6064320ejy.481.2022.12.02.01.00.08; Fri, 02 Dec 2022 01:00:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b="kV1V5/gf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233064AbiLBI5k (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Fri, 2 Dec 2022 03:57:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232892AbiLBI47 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 2 Dec 2022 03:56:59 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB37C1BFB for <linux-kernel@vger.kernel.org>; Fri, 2 Dec 2022 00:56:09 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id w15so6756842wrl.9 for <linux-kernel@vger.kernel.org>; Fri, 02 Dec 2022 00:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7Oo6s6EUUJAHLwqnGgZFQJNt6SIn7i9VCkQpm/Vrbzo=; b=kV1V5/gf8m5wqxaEveJyek5uZa0ea5mtXODUbKxzKlTcGhFaB+WjfI13Y0zcfaTHC9 YQeJbqAkcNvWF+yIkB5sJT81q5wAPbAKZfA0JzizaToD+pe8cyVNtumveJef6nqY9AsL Qp9F8dI6KJm+e+UJe5KTHrSkT0GoRNPcqriNW03miil0WG/fqGOTdaR9f7atgurt4el+ xyQsC+CKE2TXOr0M884NB0w809S0tO8hvSK1NOrcmvconJt5H/4UKWiYO2MgEqMQagwy D35/+zHdyZg7J78iORM92uBTWPm0Q6Nw6V/OE0A3KU1G/PC9KPjA2fCIHUHJ08CaxAOh 8Mow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Oo6s6EUUJAHLwqnGgZFQJNt6SIn7i9VCkQpm/Vrbzo=; b=rTQszfLQJr+KRA6JOe2XkfDXTqKSDKLnl9kKc1oVYHT1lFMYgoTn5N9GoL4X3qmoFx 5GFHD+8/o97L5JMyPl2Uf9cTTLTsyp4qhGcLhatP4AhQtWNq95pPrt3M5j6xCV3L4oNM vNnmfGN4HptFZ6mRVQoHD2WqOpk+n/QgsLmbfmrWBAsONmHkTGJF2Sapy9zCS7VI2CGA +KoYOWKSrc71XUbTA20kmuXqUmxU43QUrik8dsTd8+dLZ4upCCUAYgWWNDW8G8pGe5fw d7NS/vAGcyULfB98QLk5ZAgoC2rQcaXEqmTDmYoJ0mMOb9jCs9BkxaRSL0pdXDLs4YjS 7HFw== X-Gm-Message-State: ANoB5pkUaQJsZYyJmvXunLgUQafw0t9lWJ+ETMGAgB2tG8gqVwr+Ef6i J9P/1y2DSJFan5nSNYbfWqNYON66puIDCdvr X-Received: by 2002:a5d:4d51:0:b0:242:1bad:6f79 with SMTP id a17-20020a5d4d51000000b002421bad6f79mr14035680wru.342.1669971369107; Fri, 02 Dec 2022 00:56:09 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:29a4:6f04:ddb1:1ed7]) by smtp.gmail.com with ESMTPSA id a13-20020adfed0d000000b0024219b1cb1bsm6527517wro.60.2022.12.02.00.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 00:56:08 -0800 (PST) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Vinod Koul <vkoul@kernel.org>, Alex Elder <elder@kernel.org>, =?utf-8?q?Ilp?= =?utf-8?q?o_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org> Subject: [PATCH v5 12/14] tty: serial: qcom-geni-serial: stop operations in progress at shutdown Date: Fri, 2 Dec 2022 09:55:52 +0100 Message-Id: <20221202085554.59637-13-brgl@bgdev.pl> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221202085554.59637-1-brgl@bgdev.pl> References: <20221202085554.59637-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751092174197979068?= X-GMAIL-MSGID: =?utf-8?q?1751092174197979068?= |
Series |
serial: qcom-geni-serial: implement support for SE DMA
|
|
Commit Message
Bartosz Golaszewski
Dec. 2, 2022, 8:55 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> We don't stop transmissions in progress at shutdown. This is fine with FIFO SE mode but with DMA it causes trouble so fix it now. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/tty/serial/qcom_geni_serial.c | 2 ++ 1 file changed, 2 insertions(+)
Comments
On 02/12/2022 09:55, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > We don't stop transmissions in progress at shutdown. This is fine with > FIFO SE mode but with DMA it causes trouble so fix it now. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- This looks like a fix (even if without SE DMA impact is not visible), so how about Fixes tag and moving it to the beginning of patchset? Best regards, Krzysztof
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 808b0250d51e..1dfc0122ff53 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -864,6 +864,8 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port) static void qcom_geni_serial_shutdown(struct uart_port *uport) { disable_irq(uport->irq); + qcom_geni_serial_stop_tx(uport); + qcom_geni_serial_stop_rx(uport); } static int qcom_geni_serial_port_setup(struct uart_port *uport)