From patchwork Fri Dec 2 08:12:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 28757 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp709660wrr; Fri, 2 Dec 2022 00:13:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf6uO07zMVkf19yLVq+Cxq9zejG5Hm9wM7Fx5qeCNIu3EDNmg+oRknQoj4ucb9GfZsMzaGN5 X-Received: by 2002:a50:ed14:0:b0:46b:fb4:6b6f with SMTP id j20-20020a50ed14000000b0046b0fb46b6fmr22460684eds.237.1669968830021; Fri, 02 Dec 2022 00:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669968830; cv=none; d=google.com; s=arc-20160816; b=kVzBOPPpRABumTIhh4K6Zo8IECeAE+6PMpldYj73dOsTdC5N4TTAiedJEXLzzKm0YP +J+hYMKQH0ueVWkmdKkdhWVp4H7ZN4isg16nvFoQocRwH6GDyetx/hCFNCWePOhId4Rc etuW07I+zbWUDWNS/PRu2Mh+v8M/HCQl9+KRAhBaS7Yk3+kBzXlfjJAFj4GsU2f2djWY qMHTuMSxQ4VU3iMNyET2pMWjRH7oWAqx1S9zvkJvwf37wQEKvhRQS0YoLPTXrLOylAHY oDLJ5wp7xYlsFLbY1HUJ9zXqdJ/+pbn2OXVFHKQyyLhtvrYdwPMjAlrhBD/E5QUUc8g3 ozdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OorTeZY5veCZ5LS3K7Q06oRrQd7NMVlOQOChi1XNNZg=; b=YHDhrZDLgjB0hSjKp0OuEyWH+fjP5CW7tQeMke/W7BJFpb33P73gPGbJRt9X2dixpP 5t6Sf9LjbIN5lZQRuovrfzsvEwGS14OW5TKuuzHq2Ylz1aZ2TPluAkNqPXqeYbbSygM/ rrIlH4cmddeu1S+1CigA9/hcAF4xANeozyfqG3kA1AQYEiTC3Ykjbq1aBqoMTHg2EjC/ kV+u0gMpt0eDWjmLMT5KOk+b1QIxKSndGNwmAInpVwquVepTsx4dOOirf1gLMpU2OpRg vcf0NYpnKaWbBnUBwVqruVgS5RSxqmYEuBfsk9puz4PVEqpbuEMPTCNcD6QDEqdXHBcl y+vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js20-20020a17090797d400b007c040bc168dsi5654449ejc.248.2022.12.02.00.13.25; Fri, 02 Dec 2022 00:13:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232769AbiLBIM5 (ORCPT + 99 others); Fri, 2 Dec 2022 03:12:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbiLBIMk (ORCPT ); Fri, 2 Dec 2022 03:12:40 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91BCDFEC for ; Fri, 2 Dec 2022 00:12:37 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p119p-0005AH-RH; Fri, 02 Dec 2022 09:12:29 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p119o-001lGs-C3; Fri, 02 Dec 2022 09:12:29 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p119m-00BfDd-Oy; Fri, 02 Dec 2022 09:12:26 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko , Sascha Hauer Subject: [PATCH v5 02/11] wifi: rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Date: Fri, 2 Dec 2022 09:12:15 +0100 Message-Id: <20221202081224.2779981-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202081224.2779981-1-s.hauer@pengutronix.de> References: <20221202081224.2779981-1-s.hauer@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751089235858294368?= X-GMAIL-MSGID: =?utf-8?q?1751089235858294368?= rtw_fw_beacon_filter_config() is called once with rtwdev->mutex held and once without the mutex held. Call it consistently with rtwdev->mutex held. Signed-off-by: Sascha Hauer Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 07578ccc4bab3..776a9a9884b5d 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -487,8 +487,8 @@ static int rtw_ops_sta_remove(struct ieee80211_hw *hw, { struct rtw_dev *rtwdev = hw->priv; - rtw_fw_beacon_filter_config(rtwdev, false, vif); mutex_lock(&rtwdev->mutex); + rtw_fw_beacon_filter_config(rtwdev, false, vif); rtw_sta_remove(rtwdev, sta, true); mutex_unlock(&rtwdev->mutex);