From patchwork Thu Dec 1 23:26:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 28593 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp540630wrr; Thu, 1 Dec 2022 15:28:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf7NRWkSJv3xpfCNt4l18kapssHinHWebyWOWQjQm09N9OEBDnRBDmTngrdIAP+DfDhmTmZ6 X-Received: by 2002:a17:907:8c05:b0:7c0:7fd8:12b4 with SMTP id ta5-20020a1709078c0500b007c07fd812b4mr14861181ejc.21.1669937328396; Thu, 01 Dec 2022 15:28:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669937328; cv=none; d=google.com; s=arc-20160816; b=FrxZW8YCabELvZAuTsIBOJA7yMu3jE/Q5SBwtp1Ke9yhjWCPqX33nlY0xWVPJdgAc7 vJX5fY9jjBMbEQaeG0rF7l0J7zyHuEA2Pc6Ge/HHigyd98prkS8f5Ev1cU6HvGsL2707 3nXNvHdgUws1cLHZfYFud1bnyJImX7sLtUe8HJbVb70XNM65A44qHOeHeg7In/6S7cIx /USZW2TYr5B+PXTo0a5mAvDeIQEDK2Pe4RwpBVe5kJwpVKI14VQrkMa18V/EFltFnrTJ za+sVycXyX8BCc+aFHXnejMealhCKX1BNio+BRH9awQyD4U3XGx3Xyfz9mtpol9I7zPP DUAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=gWsZ8OEnLV5ymKaFcFmcePQ3bdY8nApK/KZQmQFCIA8=; b=OP+GYwCViMe22I0N+wBpekS/v8618/GFdbV25ZyaVH85q8/ybTo3adU5vbBjYuwSSb GQ5AAqHH3vYibc/gXI97F1c73jIGuFDnpD6Njjs1kHasM5Ri4FUWek64R7TouGQgJg86 Evpo5SDJAOdoE46XoItT8lz+MClxZcay06gTPRf5OKhtS2uptXLk2r5wPxShtr6RkMKI uMwd4Xt8NBsIGb3lZ5RP9/dQUNqnUyN7NOEDwRH0xb4SHjE0Tnunt8pkgPWfhAD8PmNn n8hSngyhAqAkHZvdXCZHmx9yAJGE4VyYx0pyi8MV3WCdZFtwJPn3kc5iMJoR+zrclM1g kGvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=KN+kBu6b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa40-20020a1709076d2800b00791a3dd01b6si5007712ejc.864.2022.12.01.15.28.25; Thu, 01 Dec 2022 15:28:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=KN+kBu6b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231839AbiLAX1Y (ORCPT + 99 others); Thu, 1 Dec 2022 18:27:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231795AbiLAX1K (ORCPT ); Thu, 1 Dec 2022 18:27:10 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA088C9366 for ; Thu, 1 Dec 2022 15:27:09 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-39afd53dcdbso31374777b3.8 for ; Thu, 01 Dec 2022 15:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=gWsZ8OEnLV5ymKaFcFmcePQ3bdY8nApK/KZQmQFCIA8=; b=KN+kBu6bWD02SccUwaKTReovA9KttAHlSNVjQiYSWj29bw0KOiCRw/sKqjr/lVMsDF Fs7Tr5euBCRY2XuQF6p7OubZFH+0hwCZaHv6tJRF7NnLpHO6x0G76cQZ+teH+Sqyatke QvK9E0JqQyweeu9vSF3H9lSs4o0oy7nK4o7cGI5MwRQ3LILlUaCVzkwKXXJ4MJxzkYwP 4b+8FdEFgNCMr9gBAWReY4t8hXIKJoDbkTk8M+cpJule4aX29nrdLG+4QNAWps/F6asm XgfYfXc5EIaFHcCMD9VChTb9l77gn/d1UI6XkXoW5ETAbItWPe5FSl2x6tF/ZsgsrOrY qgLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gWsZ8OEnLV5ymKaFcFmcePQ3bdY8nApK/KZQmQFCIA8=; b=X2rqvtGVrcEumMZwjQZO1EVstJny4xBtp8Il5I5Onr6G8hdRelHogRJnUuf9XpWL+7 V36POqzBOZdGlCVckDLcnKn4u4GGAFqmVBLyZ760cfbQiwGOW8obgQcU5CaYboXa8idD XH+r9pddPq3dtukQp3IM9za8CxifitMIvUHTZ9Fh/Y9MMttvx/IeS3MRwbmpYHjWTDbV 5UbDLPna5SgJDAzPxr66QicgVTp6V8YQgwFxBX6IWgAREyx55k1gvpW5rcLO9i6JX8c5 cHOT+Ch3tU63jYHhiefUlI35GxPScCNb8YGmcX3gxnHbWbtntSZAkSsyJPYSe+8n5uFk RnIg== X-Gm-Message-State: ANoB5pmjYJUdKNOVSCGIely5HwL7IQme6tgbf+c/eg40IpRvPrf6yNP+ o1Fyg9gEQ1UlDEGsbe9t/p31yf+Um10= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:af04:0:b0:6de:9623:a2ec with SMTP id a4-20020a25af04000000b006de9623a2ecmr46844162ybh.496.1669937228986; Thu, 01 Dec 2022 15:27:08 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 1 Dec 2022 23:26:43 +0000 In-Reply-To: <20221201232655.290720-1-seanjc@google.com> Mime-Version: 1.0 References: <20221201232655.290720-1-seanjc@google.com> X-Mailer: git-send-email 2.39.0.rc0.267.gcb52ba06e7-goog Message-ID: <20221201232655.290720-5-seanjc@google.com> Subject: [PATCH 04/16] x86/reboot: Assert that IRQs are disabled when turning off virtualization From: Sean Christopherson To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Sean Christopherson , Paolo Bonzini Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Andrew Cooper X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751056204008850049?= X-GMAIL-MSGID: =?utf-8?q?1751056204008850049?= Assert that IRQs are disabled when turning off virtualization in an emergency. KVM enables hardware via on_each_cpu(), i.e. could re-enable hardware if a pending IPI were delivered after disabling virtualization. Signed-off-by: Sean Christopherson --- arch/x86/kernel/reboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 78182b2969db..40ea16ecb3b8 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -838,6 +838,8 @@ int crashing_cpu = -1; */ void cpu_emergency_disable_virtualization(void) { + lockdep_assert_irqs_disabled(); + #if IS_ENABLED(CONFIG_KVM_INTEL) cpu_crash_vmclear_loaded_vmcss(); #endif