From patchwork Thu Dec 1 23:08:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 28590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp538496wrr; Thu, 1 Dec 2022 15:22:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HuAzU6/8gv4aah1kSxgieCxMoVYba5N+TIQRPrjdA6Q5rRRU0CC9XzMlU9UJlYjsCgyi6 X-Received: by 2002:a05:6402:206b:b0:46a:d5ed:e066 with SMTP id bd11-20020a056402206b00b0046ad5ede066mr27861259edb.335.1669936950895; Thu, 01 Dec 2022 15:22:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669936950; cv=none; d=google.com; s=arc-20160816; b=lkEkNjjAMd0QJ+5YshIdL1HCDCSdTKQ8YgrHLof6tuqELUA5r7yLvOQbYn1Hk5uE9X 670vTjo6duHVVvUGjQ+g5qVNTPRQEoicZ8qAXnudyWrfYjPfMdKBTrZvyAA6G0tKAEZU XlqVEMUVXA27c2BQKsjiGBcWSsYi4NOdt74AlE7O1lhKHODEim7KyJS3P3m5Ycna2yct 96ff1EcYiRC0rsSO22HGda9VvTqfY/EJplSoiYhJfiBsBIP1ElXmomRoNQfa+QiWqWbd N19yVdVm4smRKkAAux9Seb07wuow4ch8GPOkSkyAqyL7SRPZsngxXQzdx6JPkKboTUBV ZP/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BtaH/R2U9H/FSCFeNcuszPREFemDGP9fQpdb/KT1ZL4=; b=B7Zbl2eUb7vI6JBjKpNbYl9AF1bIrbRojdlovZuQ+kGuSvCYHqzYvJVBCPxd8XI+j3 egLQFqv5RrX4McNR3Oniq/KOWFfdnuvLyoGziuaV1gs+DFmrstCCmgUUr02L581lPB3Y qUp1jBbcU4ZVGXcVonZV2Ki3QS67oF4KuMLC89YyvkMtvWHndOQduu8LlYkdWupt/Sdi lWWbCQo7/JSLbtPGqN5p4kufMqICJ4gnfqhmUhY6hwASzniioBzR/qW6uT5RYFKJuTIW FqJF9dM3e2JW1OftxPsCGUEWIroeLk74qiHJT/MOFDgqeohJd4FdQ4fBymyQ8GB6k4GE 5SLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iS9QIA0N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne16-20020a1709077b9000b007bf7bb4702asi5220100ejc.804.2022.12.01.15.22.07; Thu, 01 Dec 2022 15:22:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iS9QIA0N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbiLAXLT (ORCPT + 99 others); Thu, 1 Dec 2022 18:11:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231771AbiLAXKn (ORCPT ); Thu, 1 Dec 2022 18:10:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA3FFBF652 for ; Thu, 1 Dec 2022 15:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669936140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BtaH/R2U9H/FSCFeNcuszPREFemDGP9fQpdb/KT1ZL4=; b=iS9QIA0NoHrNEmxnkrx8RMEYZRasgwABiPvgRDiDN73fYYitKyOjm6DJKxF/3d9CxvjkTS MwR+C1qBhZf880BnPr9N7jssCD7MnrJQrKrZ2wxB7Lck3ZFKD3q/h5yJ6AkFC4MU4YFuD6 +/9DHtFzKN0TDQstf7rzDPdBOno7S6A= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-423-aCRiw6XANKmbDPazvPw0OA-1; Thu, 01 Dec 2022 18:08:58 -0500 X-MC-Unique: aCRiw6XANKmbDPazvPw0OA-1 Received: by mail-oo1-f72.google.com with SMTP id x13-20020a4a9b8d000000b0049eeca57fbcso1013661ooj.9 for ; Thu, 01 Dec 2022 15:08:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtaH/R2U9H/FSCFeNcuszPREFemDGP9fQpdb/KT1ZL4=; b=C7V9O9wlS0ZqGt5l1oU5k61g3qz+TqX111q0IY4MrIOUPwJ0HzKG0PwS5RZxd6idEB OzrDijTG2v/haSVNMXFirLa38/vtbZ//96XrexXIOlt3qEOxJxY1TSn1821A4BnGLWhd 9oVw9InlHNpk1wlrT76z6kMtq0sF9+3QTol/4CFmwPdQ9tLe4IE2fjKTR6lGtThubGFt GqdlBmjcD9kgtGgnlcKgfIlX0Lg01VKjvENHVSSzHo02xmQA37AhNOOSloZAw6Q90cX6 muhoVfpBcfbf3R1oL1Ka6FOoF5oPihGgqV9hMjjV+2xa5Pc8Y9kbelsrfd5CF5pBATNX nP/g== X-Gm-Message-State: ANoB5plyQ50sTonTbwyW+QEiWAWvjCUSy563eQiJYJitj5Dj+ALMneZe 8oT8SXizSrJzqEnWQKKC3rBtT84mccSK0jA2f1qQKmK8x6JjeCs+/NZQ9fCYo4uqiUCxPXwnImZ QaRLld3QE9zmkyJ/mf2ISVbOk X-Received: by 2002:a9d:5e0f:0:b0:662:2458:3ef7 with SMTP id d15-20020a9d5e0f000000b0066224583ef7mr34467970oti.150.1669936138147; Thu, 01 Dec 2022 15:08:58 -0800 (PST) X-Received: by 2002:a9d:5e0f:0:b0:662:2458:3ef7 with SMTP id d15-20020a9d5e0f000000b0066224583ef7mr34467958oti.150.1669936137925; Thu, 01 Dec 2022 15:08:57 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::41]) by smtp.gmail.com with ESMTPSA id y22-20020a4ade16000000b0049fb2a96de4sm2320393oot.0.2022.12.01.15.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:08:57 -0800 (PST) From: Andrew Halaney To: andersson@kernel.org Cc: agross@kernel.org, konrad.dybcio@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org, Andrew Halaney Subject: [PATCH 4/4] scsi: ufs: ufs-qcom: Use dev_err() where possible Date: Thu, 1 Dec 2022 17:08:10 -0600 Message-Id: <20221201230810.1019834-5-ahalaney@redhat.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221201230810.1019834-1-ahalaney@redhat.com> References: <20221201230810.1019834-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751055808146675170?= X-GMAIL-MSGID: =?utf-8?q?1751055808146675170?= dev_err() statements are better to use than pr_err(), so switch to those. In a similar vein, the check on the dev_req_params pointer here is not needed, the two places this function is called never pass in a NULL pointer, so instead of using dev_err() there just remove it. Signed-off-by: Andrew Halaney Reviewed-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index b1fcff1fad0c..4350c44a6fc7 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -680,12 +680,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, struct ufs_dev_params ufs_qcom_cap; int ret = 0; - if (!dev_req_params) { - pr_err("%s: incoming dev_req_params is NULL\n", __func__); - ret = -EINVAL; - goto out; - } - switch (status) { case PRE_CHANGE: ufshcd_init_pwr_dev_param(&ufs_qcom_cap); @@ -709,7 +703,7 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, dev_max_params, dev_req_params); if (ret) { - pr_err("%s: failed to determine capabilities\n", + dev_err(hba->dev, "%s: failed to determine capabilities\n", __func__); goto out; }