From patchwork Thu Dec 1 22:57:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Rokosov X-Patchwork-Id: 28579 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp528845wrr; Thu, 1 Dec 2022 15:00:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf7HreZQo3UK0/DpjAxm5kFkHE+DkQ78WLR15RJXNEamle6Hz87i3OyHS8FZ6dg+ewq14FXq X-Received: by 2002:a17:906:5055:b0:78d:cdce:bc52 with SMTP id e21-20020a170906505500b0078dcdcebc52mr43601066ejk.469.1669935623922; Thu, 01 Dec 2022 15:00:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669935623; cv=none; d=google.com; s=arc-20160816; b=OPGKuuFOK2+gw4j4zeCmlsk+4P7hGVokPc/EMqf3U3JDYGd8OeLEfeideqwsKBYUVa Fm8qvJwKW5eXhPMG+SqfO1a1CBgE2CSmGanGkCbyRObmHa/4y9xFlWHYpPEes9Khf63B WcnMLAxCOU3+jB0qXJm4aAdP7rusFmtESjjwncQJ+raBFXuEvBef6b5Y0srxNwixgCmI WJdetv5eHIuYv28To+r/o5RD3OqByI+ppg+gQc5AA4/cuNHYE3gn+PKFgslXnvQqROg1 FD3JpFUPFsw3xgerh4p/5e7HDk4ryWD22p7vZNfA3ie7cP5Jlxzc6EHcfW2fc4cCURER 5RfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=su3raxn0OGsgB1AdUJiueQi3w/7b0lMP0lopP7rXXpY=; b=E3BFf65fW8+BnMe2Nd/iKV6co/xPu4gHYbK16O0H03IHNIfRAFeOt9lS5X5PFcC7v8 alIdIlSZIJNXMDYPxorVeHULct992noUe1XJbuOs1FzsQHJ7ss+/qNfeY4A03gggasAS iK4en+yEpwR+uaUmk71iP3mq+oRMxZDL27vUZcjJzOiWIxxSqX1mxdztxQ+d9VOzRoy9 NTZMSfZN0XCinoiszxqwQvehfJ/yYtD/i60Vm4FAt8nQir+p2p2Xi4y3zdyLrIxuqj9u Bz6R2TnTlIYM2n6/QKn4h47PnULg4HMSYfaucJmUR0skofqseCoucsM4fB5IoAtJ+8qu /pWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=cNmnNR0W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz10-20020a17090777ca00b0073d81935416si445084ejc.749.2022.12.01.15.00.00; Thu, 01 Dec 2022 15:00:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=cNmnNR0W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231838AbiLAW60 (ORCPT + 99 others); Thu, 1 Dec 2022 17:58:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231691AbiLAW5m (ORCPT ); Thu, 1 Dec 2022 17:57:42 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D95DEF0; Thu, 1 Dec 2022 14:57:39 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id E8C9E5FD0F; Fri, 2 Dec 2022 01:57:37 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1669935457; bh=su3raxn0OGsgB1AdUJiueQi3w/7b0lMP0lopP7rXXpY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=cNmnNR0WXQN6phqG51RQRC2mtxtZ5MEXY3k+09rPdvLXyKXzpm/ijJnUrIKOA5wtw Z0piWjyB7Af3tgf22fEsa+r7y/HVZJ1X6mvf82a6AIYSma4FaKcVSX7Jrgvc/MF1IA UxmBZL7LRaigh9JOMZq1Uku6CqfANbByJdao4xASKzOcCwwZfpavpoOoJuvRLV33SP qKn9dLSLiNc09VZO3gohUgF3uKa9YJoG3+0//G6Js3FTpd3nIQB3nmFXzuibTA+p2i IVcteNX+DhRB4Py1hMhnZMPPbJuRUSn2CMXz5uovgQ+fdwgErPyD812LWwO2zmnjjf w6DH1H04lExhg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 2 Dec 2022 01:57:37 +0300 (MSK) From: Dmitry Rokosov To: , , , , , , , CC: , , , , , , , , Dmitry Rokosov Subject: [PATCH v8 10/11] dt-bindings: clock: meson: fixup A1 peripherals clkc dtb_check errors Date: Fri, 2 Dec 2022 01:57:02 +0300 Message-ID: <20221201225703.6507-11-ddrokosov@sberdevices.ru> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20221201225703.6507-1-ddrokosov@sberdevices.ru> References: <20221201225703.6507-1-ddrokosov@sberdevices.ru> MIME-Version: 1.0 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/12/01 20:49:00 #20634374 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751054416671142232?= X-GMAIL-MSGID: =?utf-8?q?1751054416671142232?= During running dtbs_check and dt_binding_check checkers the following problems were found and resolved: - $id is not correct, it has wrong url path - no base offset in the dt node definition - CLKIDs aren't applied by names, just magic int constants there - address and size cells are required for long reg definition - wrong indentations Signed-off-by: Dmitry Rokosov --- .../bindings/clock/amlogic,a1-clkc.yaml | 36 +++++++++++-------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml index 7729850046cf..b0249ab21466 100644 --- a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml @@ -1,7 +1,7 @@ -#SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: "http://devicetree.org/schemas/amlogic,a1-clkc.yaml#" +$id: "http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml#" $schema: "http://devicetree.org/meta-schemas/core.yaml#" title: Amlogic Meson A/C serials Peripheral Clock Control Unit Device Tree Bindings @@ -10,6 +10,7 @@ maintainers: - Neil Armstrong - Jerome Brunet - Jian Hu + - Dmitry Rokosov properties: compatible: @@ -50,16 +51,23 @@ additionalProperties: false examples: - | - clkc_periphs: periphs-clock-controller { - compatible = "amlogic,a1-periphs-clkc"; - reg = <0 0x800 0 0x104>; - #clock-cells = <1>; - clocks = <&clkc_pll 6>, - <&clkc_pll 7>, - <&clkc_pll 8>, - <&clkc_pll 9>, - <&clkc_pll 10>, - <&xtal>; - clock-names = "fclk_div2", "fclk_div3", "fclk_div5", - "fclk_div7", "hifi_pll", "xtal"; + #include + apb { + #address-cells = <2>; + #size-cells = <2>; + + clkc_periphs: periphs-clock-controller@800 { + compatible = "amlogic,a1-periphs-clkc"; + reg = <0 0x800 0 0x104>; + #clock-cells = <1>; + clocks = <&clkc_pll CLKID_FCLK_DIV2>, + <&clkc_pll CLKID_FCLK_DIV3>, + <&clkc_pll CLKID_FCLK_DIV5>, + <&clkc_pll CLKID_FCLK_DIV7>, + <&clkc_pll CLKID_HIFI_PLL>, + <&xtal>; + clock-names = "fclk_div2", "fclk_div3", + "fclk_div5", "fclk_div7", + "hifi_pll", "xtal"; + }; };