From patchwork Thu Dec 1 19:03:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 28511 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp440648wrr; Thu, 1 Dec 2022 11:16:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4pZJHlSbbAWwB7GArYeJNhIn84AE1cUpmAdhParJDjRv28tOXsmv9WoNlRVbtdeTXG5naY X-Received: by 2002:a05:6402:4d0:b0:462:317a:e02f with SMTP id n16-20020a05640204d000b00462317ae02fmr48851933edw.125.1669922202800; Thu, 01 Dec 2022 11:16:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669922202; cv=none; d=google.com; s=arc-20160816; b=qa3MYdoUGBv3oDLmPrV8njaqaQTilY33RS6YpqzEl20fbvmOjWnoyCQxPry9nZDzWd O1n3bIoGsw4+JKppd2QNpIvShvLdG9jVa28e5OPrEBFh/Q+cr0zyFYozD4mjvRhoLLv5 kkCCHmYEzJLajQVK6ogv3Niy75hVyanQP8u4lZvoQHvuSrmdohj84jy8bx2FVKScrJNn XEhyesuQ4y4VA3GnCfyo+7fzJUcZ5B4ixNap8nsX6yG/AFT5Y4bwVGAw3bUXGsorJZ1z Wtk+E4kGwqa+1EyFgn9qyio/xwDRs5bVl1Gw9/6PK7l9uI8pLWAL363AZ0LqfttWntSx QdYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bAA6BwbBaAZOfPoWU8hKGND5fHQgQCgW9VzqG/UGn2Y=; b=1ExFa90Ro3PvVdiGG+tihsE4ToVZvFrO05uIqN5RiFLG6J8i++GYp+AaKvYHuqyi5v sm/fzdDYZXW3XAw0mS6vWpok/FmmBsT04XoJ5dn/IYNgZKUZniLSZD5cESZIWCEL6RHX agvrhge/xqC4ScWO9wh/orx83Qd1niJrCRDCHCcm7FgnghyrVmgAI86QtnqWQg/imILy oELGSwmQ/6qV4Orv0F95FdUfpJLPT73/IR+ovXM5tca5yapkURbZhWJWSmpHzQI1/N+t MaaExNHwBsD+i1T4apr0fpE5/ixx6QzBhwBXbQ/AlLblAsVR8vw1HaA/18wamEuY8lFy G7vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Ol3TACe9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr21-20020a170906d55500b0078d49f0df9csi4725424ejc.453.2022.12.01.11.16.19; Thu, 01 Dec 2022 11:16:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Ol3TACe9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbiLATEc (ORCPT + 99 others); Thu, 1 Dec 2022 14:04:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231134AbiLATEZ (ORCPT ); Thu, 1 Dec 2022 14:04:25 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CFAFC5E1B for ; Thu, 1 Dec 2022 11:04:24 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id q7so4328394wrr.8 for ; Thu, 01 Dec 2022 11:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bAA6BwbBaAZOfPoWU8hKGND5fHQgQCgW9VzqG/UGn2Y=; b=Ol3TACe9AgHdDvDQsBilzT1sJ3COPVe2KK+h1R2Ej+Vl2UTtUxHMOBd/mIF/skWmBm jCjVH3Lu8JpC+8f8mE1EyxcYOOyd717zjESbXmetpJv1cLUHzwNch/yvpYp+kxUEj8cE t9L3FcG+jZP8/Kg/0F9gHi6zlAVm3SpEskUeOu5OTEhLhRes7kKtvBA95B589mXsSINd d7s6QDBAy0vb/lmFAOZXH2ZlELaz7vd99hfvWUZH4WITD8FJbXTOxLZhrYrttUS1EFIY QmFq5acqsnlXNwJggSFOSgMV9swxetihXaPVskAVU0l/QK6oLVtoEKQfp8PpgYPfmwEM b1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bAA6BwbBaAZOfPoWU8hKGND5fHQgQCgW9VzqG/UGn2Y=; b=y4C0zqF3mz9pl9cseniNrLloIbk2QCyNUqIb4jz7wJwGO9vvB34IrvwMFscxe/kn/p zKp07CCXddlVcoTJmGqxJmCxu+/SFzpV34GnIa7ya6in864XkqmqMBawi9rPS2OKKjDo JHUed67qDi+n1KnBL7ho1uoBTc7KGE7CQ61LkvE3xOJl76Vg9wA8QHEdwshTrIl8pek0 Mky10j72Qo0Cq5DhuFmfNpzyewIRf1skCUCB7SLHRbtdku++o6GEgf8EYZwNFeu79ShW ph+eP14iGnwlMxBUZBk3hGTWUOKdnxQMl6o5pfs8KsAISP6iTrj8lutzkv34Do4uFbJk gyvw== X-Gm-Message-State: ANoB5pl/b5OmPD/xCcUscI2/55GmJ47Bor3RZm2nbskQ0Ugxtw9hRZxM IKTOg89fJys2sf0YdZlbFrJpAgxMZUS8TUFe X-Received: by 2002:adf:bd90:0:b0:241:edf6:e198 with SMTP id l16-20020adfbd90000000b00241edf6e198mr26625530wrh.492.1669921463047; Thu, 01 Dec 2022 11:04:23 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id h20-20020a05600c351400b003c6cd82596esm11848474wmq.43.2022.12.01.11.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 11:04:22 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v4 3/5] hwmon: (pmbus/core): Notify hwmon events Date: Thu, 1 Dec 2022 20:03:52 +0100 Message-Id: <20221201190354.1512790-3-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221201190354.1512790-1-Naresh.Solanki@9elements.com> References: <20221201190354.1512790-1-Naresh.Solanki@9elements.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751040343749543802?= X-GMAIL-MSGID: =?utf-8?q?1751040343749543802?= Notify hwmon events using the pmbus irq handler. Signed-off-by: Naresh Solanki --- drivers/hwmon/pmbus/pmbus_core.c | 46 +++++++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index bdcbc216b0cc..78c401412c4d 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2782,7 +2782,35 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = }, }; -static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +#define to_dev_attr(_dev_attr) \ + container_of(_dev_attr, struct device_attribute, attr) + +static void pmbus_notify(struct pmbus_data *data, int page, int reg, int flags) +{ + int i; + + for (i = 0; i < data->num_attributes; i++) { + struct device_attribute *da = to_dev_attr(data->group.attrs[i]); + struct sensor_device_attribute *attr = to_sensor_dev_attr(da); + int index = attr->index; + u16 smask = pb_index_to_mask(index); + u8 spage = pb_index_to_page(index); + u16 sreg = pb_index_to_reg(index); + + if (reg == sreg && page == spage && (smask & flags)) { + dev_dbg(data->dev, "sysfs notify: %s", da->attr.name); + sysfs_notify(&data->dev->kobj, NULL, da->attr.name); + kobject_uevent(&data->dev->kobj, KOBJ_CHANGE); + flags &= ~smask; + } + + if (!flags) + break; + } +} + +static int pmbus_regulator_get_flags(struct regulator_dev *rdev, unsigned int *error, + bool notify) { int i, status; const struct pmbus_regulator_status_category *cat; @@ -2812,6 +2840,9 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & bit->pflag) *flags |= bit->rflag; } + + if (notify && status) + pmbus_notify(data, page, cat->reg, status); } /* @@ -2856,6 +2887,11 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned return 0; } +static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned int *flags) +{ + return pmbus_regulator_get_flags(rdev, flags, false); +} + static int pmbus_regulator_get_status(struct regulator_dev *rdev) { struct device *dev = rdev_get_dev(rdev); @@ -3088,7 +3124,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) { struct pmbus_data *data = pdata; struct i2c_client *client = to_i2c_client(data->dev); - int i, status; + int i, ret = IRQ_NONE, status; u8 page; for (i = 0; i < data->info->num_regulators; i++) { @@ -3096,6 +3132,10 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) if (!data->rdevs[i]) continue; + ret = pmbus_regulator_get_flags(data->rdevs[i], &status, true); + if (ret) + return ret; + page = rdev_get_id(data->rdevs[i]); mutex_lock(&data->update_lock); status = pmbus_read_status_word(client, page); @@ -3110,7 +3150,7 @@ static irqreturn_t pmbus_fault_handler(int irq, void *pdata) mutex_unlock(&data->update_lock); } - return IRQ_HANDLED; + return ret; } static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data)