From patchwork Thu Dec 1 17:43:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 28476 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp399131wrr; Thu, 1 Dec 2022 09:48:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HxT2DhzYWOqak/x7/g/KXdVXgy+XeXHQzq0+y0EsbkkYJTYmzGqTBvOEQhPsdl2dQJqSg X-Received: by 2002:a17:906:6852:b0:7c0:a728:6aa9 with SMTP id a18-20020a170906685200b007c0a7286aa9mr5778016ejs.514.1669916910152; Thu, 01 Dec 2022 09:48:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669916910; cv=none; d=google.com; s=arc-20160816; b=fLw9wC8TIrNTnyAhTvm2cidk8+8IGUBmTqhVbh62TTcKXQ0Hcb8kDkQBAVVWUBW/gv FD6NXVujEGwXPfoASacU/Jps7A6vm1JCa5THsJMj92tvUtxEGXVMumytWRafopmquqz2 SAjIRiOZtOdrdoI40D5JzUIMYI0cRqozc3fPaxbwPRb3/IFEdvIWqz8xydIyxX+hpGH2 7FhR3pqUZN9EG0EBXFB7ufuwSnkZI1WRPmqYLIghrpH0omqbxlrnQDBhnvz6JsZZutdl BwiZIGvSnGlAkQwZGHC9/DkBJlSDMu0kgGA2AeopZSvwHqhY5CnFq6qu2xKqK1pIEQWp vhEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RgfrCdEhXykVwBp3nVTN7WEjo711kZc0QKngTjXB/aU=; b=tuRY5W7Fyf401mGE1zGo4yFSjZ1yDrSt0Cid0C/UDsy2NjqaOWrFRKqb/Qy0rmwFg8 S5Kca6TkbiRNUU4h4hCbVF5qQDoZBT4kcundlpKErIpZm/FmbFnNUH3HMsDp6OKrQpHQ 5O91cnXHweRP3WKGwMLcMsHqEGjywqSA9fYA97EKR2UmMMFXAyRwZc8QYCc/It09sORe 8cgiaSTT9T56LbbsZD0vD5ATsIbPiGXFSFCIRKvj1LbBC87bMxVlf2WXmaRvoDHjh+rz qdOn3dj37zT0r+BSVORmABvo1oNmbLkg8H5fBJZoDxwMafQhZkkMjaJLE244VpJDeAi/ n/5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F5Y0Q5UQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc11-20020a1709078a0b00b00791a37e665esi4368969ejc.10.2022.12.01.09.48.07; Thu, 01 Dec 2022 09:48:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F5Y0Q5UQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiLARqq (ORCPT + 99 others); Thu, 1 Dec 2022 12:46:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbiLARqE (ORCPT ); Thu, 1 Dec 2022 12:46:04 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41130CAB72 for ; Thu, 1 Dec 2022 09:45:19 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id k5so2509207pjo.5 for ; Thu, 01 Dec 2022 09:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RgfrCdEhXykVwBp3nVTN7WEjo711kZc0QKngTjXB/aU=; b=F5Y0Q5UQLyyIR5QPRFA5yUqqUh1IxjxKnxrw7Sg44Xod7IPkxDk8a8CvKdMfIKAu4R 8JPI6vH4kowAIxeAtJ4bFRkU5Gn9nlW8Cqevp1wF/BckB6B8H2KcLqmorCEE1Zzb0cI6 UUTeX3qDPg+udsYi3swPmdvFHV50CMC3cd2RYw2iEpPIzM2SkNSVmYc0KSz1sSBsL7ls GfdGRgfyV0yZfHpQdtAZ9//P9o1qB++UJXkC1FmvHhTk/QzQxW+3Iam3ZgSr9u4HkJfO FBYLzj9kA1r3l2Z43glviXlDKmd845CiempMsq6KKAJbctYVyTLtO5Z9Q1gNeV2BF/AK dPDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RgfrCdEhXykVwBp3nVTN7WEjo711kZc0QKngTjXB/aU=; b=bMsnBjEb1IvwJDQGyJ9LKzKu9QXaxxBFmDR9jiv0T7o+anmYJhlILpRmcjAfCS7niq DrP2svS+ivdv0mlrTvKx9zQeYjTIu47zclDUqzjP2yiL4CMmRwMofp7UE0Y5UDSj05OZ SfzknhzpwVDL40s7cWotQ2F9GpQRS4BvSAY46dYw/0jQG7kjyq1Goy0IDbZIgYixz1tj JxqkJq2RFj5gj8pkygnsGc6lpgEfMRkb/OG/nYjcabB+4YDSNSnbY+eERuvmHUHw3/fk lTgW5E9OrPb1SE543KSrrCiuK3BnnVB1zj3a5LsyMvzvU5mOGkic3kpTx04MMmJy//HB nbtw== X-Gm-Message-State: ANoB5pkd8BggpJWDYkvRmsiEkqhomxcn8GuQO8k5zKJHlJ4PehzU7LI/ FxqYhYdJUphsmnA6mRnig+Wr X-Received: by 2002:a17:903:2683:b0:186:6f1e:5087 with SMTP id jf3-20020a170903268300b001866f1e5087mr50040574plb.119.1669916718738; Thu, 01 Dec 2022 09:45:18 -0800 (PST) Received: from localhost.localdomain ([220.158.159.39]) by smtp.gmail.com with ESMTPSA id p4-20020a170902780400b0016d9b101413sm3898743pll.200.2022.12.01.09.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 09:45:17 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, vkoul@kernel.org Cc: quic_cang@quicinc.com, quic_asutoshd@quicinc.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, dmitry.baryshkov@linaro.org, ahalaney@redhat.com, abel.vesa@linaro.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, Manivannan Sadhasivam Subject: [PATCH v4 14/23] scsi: ufs: ufs-qcom: Remove un-necessary WARN_ON() Date: Thu, 1 Dec 2022 23:13:19 +0530 Message-Id: <20221201174328.870152-15-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221201174328.870152-1-manivannan.sadhasivam@linaro.org> References: <20221201174328.870152-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751034794231706694?= X-GMAIL-MSGID: =?utf-8?q?1751034794231706694?= In the reset assert and deassert callbacks, the supplied "id" is not used at all and only the hba reset is performed all the time. So there is no reason to use a WARN_ON on the "id". Reviewed-by: Andrew Halaney Signed-off-by: Manivannan Sadhasivam Reviewed-by: Asutosh Das --- drivers/ufs/host/ufs-qcom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 7cd996ac180b..8bb0f4415f1a 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_assert_reset(host->hba); /* provide 1ms delay to let the reset pulse propagate. */ usleep_range(1000, 1100); @@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) { struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev); - /* Currently this code only knows about a single reset. */ - WARN_ON(id); ufs_qcom_deassert_reset(host->hba); /*