From patchwork Thu Dec 1 09:21:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomeu Vizoso X-Patchwork-Id: 28269 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp160975wrr; Thu, 1 Dec 2022 01:28:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7sYy+vTx/8w8CIdyxPrXqZ3to+LB2lNPJKrolJpWHeFtKb85mNpayF5B7Pz10xVsgdthdq X-Received: by 2002:a05:6402:448c:b0:461:7378:3501 with SMTP id er12-20020a056402448c00b0046173783501mr41369475edb.35.1669886885262; Thu, 01 Dec 2022 01:28:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669886885; cv=none; d=google.com; s=arc-20160816; b=vL5hzuNIO/L+r/dxiUBd8BFahTXUClLIUXTvbwrt7UUmKwP6NA+E9KbQjrnMXtE9qH TuJcMtmTPWZFpbnvXVT72r3aqBJI/4DLSwOEvqg2BxGMSTsFSc6fBmLGUFO4+y/myC7a iuXGgvCUWYmiXL4E2Mrx6ORUzLaypqe1cI0hvUIWY7lxjOhoOpmhGSB2ivw9Yc7m6mfj P2XyWAmZ86+rlmNYc16eMPRRGhPE8ltRz9TprUcNfrMEe6TtAyhqMuCccNmbF7oFQANk GPBRc3FaAV4HeIhegSRM564DnV1/siVVBh/moz+9efPAKQq1Y1DRUQHJuudTfUXOu4Zv E3OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from:sender :dkim-signature; bh=NbApf1anPXhkyL1eMhU3x4CauZkX++vBii8PykYLja0=; b=EEcBUmj7Y1718VmMbrYn6sjc3mAvuCgEe9wnRRQqVZCJSlnYLC0gk3kKErZUSggjta tEe/xEMYScgrFkrlSFc4Ce1JynmSQNfYbqL5IiqdsapyPwH/a9OPj1a8agQHH4egfyjC D1X+eOz+Rk2+y5hR0pz/gC9gdEy5NOZjP4cNAUcAJAtsoYqBxCg/imSl6wGmFb96YPI/ f0jWZ5+UFB65mAh2Pe+obsbk3Tjf9G7rNGDkXzpqEIUUBLQJ7rd5WZXzOjewLDsRqHel Gsb0whLhwO1xJoQeHzzuixSIBu4bTvbxAL3yX6CTzdcmrJUMEPaVVf31j91wTofOTEoK sAQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=QZsc+anX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di7-20020a170906730700b007c00323cc16si3620415ejc.973.2022.12.01.01.27.41; Thu, 01 Dec 2022 01:28:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=QZsc+anX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbiLAJWc (ORCPT + 99 others); Thu, 1 Dec 2022 04:22:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbiLAJWM (ORCPT ); Thu, 1 Dec 2022 04:22:12 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3088886594 for ; Thu, 1 Dec 2022 01:22:10 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id b2so2707012eja.7 for ; Thu, 01 Dec 2022 01:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=NbApf1anPXhkyL1eMhU3x4CauZkX++vBii8PykYLja0=; b=QZsc+anXmpwu6POr+6D9Nn9OjPEpMot3211JfomV93JEayXGnUjwqnbnYsuH2EqZ8J 3QXZCMWe/ss5ahcWqWboFLZL3vqDH7B6puPa4VC80uGyOA+XWxAZSpNvpk3nBom9288C +MXcRRHO4kjisktIB490p1q2A9l115vmJMhbwvAeG7wihz8OmuT0nllQW/QTj4LEF9jH IclppEXhs/6UYUPsFSzxNyc5NapjHKT2wg9uAk0fqwtaicRwaXL6M8pXSWYpWnukA9au 4O0yxq1pVanNzhwssbcok9cAVk1PkfZXjBxWXXqq+6AoALKAocWg/5c180e2YCREbuO7 8UpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NbApf1anPXhkyL1eMhU3x4CauZkX++vBii8PykYLja0=; b=s2yHNUyuwdXiD7HVeGHNFyc6+6rkUdyCNuOc+w7lAew4CVwWBxGaROCdqjO+fPpLUP ziL8CyOzTGsFbIpCyicy0jjNN8INBbc7sUWs/76b58Vtzr4EHix8dI8EN7yQ9Yk+aa99 dpg4Z3mKEhxcnZu8ByOo4KvbmAfcMpzxLJXERu5xfTse/KCZdyLK2DqNnq49hlt+LDrx NpnAVN2PnSqCvjNKdkQCtv1Y2n0NoFRqLnz36Cu8VjmAPz931jslk5Nm/kKqFomaTXDd LSC6CbLpT/w2hywDytFoXB+hWSh4lvzWWM50Myr2zcCoVXwSA/SUVOiqdbm5Tzu9yUs2 dFtw== X-Gm-Message-State: ANoB5pndFdzZHeGyz9oVG4PzaAJSJXiIfCjTXc5S8nbg7jKQY7jvV0D7 qndcXrffIZT6Sy9FaloGiyQ= X-Received: by 2002:a17:907:76e2:b0:7bd:f424:b1da with SMTP id kg2-20020a17090776e200b007bdf424b1damr20991045ejc.306.1669886528176; Thu, 01 Dec 2022 01:22:08 -0800 (PST) Received: from cizrna.home (cst-prg-44-69.cust.vodafone.cz. [46.135.44.69]) by smtp.gmail.com with ESMTPSA id 18-20020a170906211200b007b29eb8a4dbsm1587879ejt.13.2022.12.01.01.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 01:22:07 -0800 (PST) Sender: Tomeu Vizoso From: Tomeu Vizoso Cc: italonicola@collabora.com, Tomeu Vizoso , Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , etnaviv@lists.freedesktop.org (moderated list:DRM DRIVERS FOR VIVANTE GPU IP), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR VIVANTE GPU IP), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 7/7] drm/etnaviv: Warn when probing on NPUs Date: Thu, 1 Dec 2022 10:21:28 +0100 Message-Id: <20221201092131.62867-8-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221201092131.62867-1-tomeu.vizoso@collabora.com> References: <20221201092131.62867-1-tomeu.vizoso@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751003310349148311?= X-GMAIL-MSGID: =?utf-8?q?1751003310349148311?= Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 37018bc55810..3cbc82bbf8d4 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -765,6 +765,10 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) goto fail; } + if (gpu->identity.nn_core_count > 0) + dev_warn(gpu->dev, "etnaviv has been instantiated on a NPU, " + "for which the UAPI is still experimental\n"); + /* Exclude VG cores with FE2.0 */ if (gpu->identity.features & chipFeatures_PIPE_VG && gpu->identity.features & chipFeatures_FE20) {