Message ID | 20221201092131.62867-6-tomeu.vizoso@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp160905wrr; Thu, 1 Dec 2022 01:27:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf5OVxRPeGonEwBceTAgI+L3R1YWmTQU1+tdG2Vl0uHKM3WvPozVc1cXoU/MVmsEyhhXgnz2 X-Received: by 2002:a17:906:2481:b0:7b9:a749:e70b with SMTP id e1-20020a170906248100b007b9a749e70bmr33036580ejb.567.1669886870298; Thu, 01 Dec 2022 01:27:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669886870; cv=none; d=google.com; s=arc-20160816; b=WmfGowWVWvIcBZkJGjoJYJT8i+FJQ6DDaJCnlEKnwpmKClH5fKLj/cElCcYgySVuHp L276Pe5SLyReI7ooQSy3stgIgtql6KnG/CCG+Q+oEhavutqTHcTQWfFPwqyJJb9XJTBN ftYKYE+aW471ZP+RyQkxJVZYFavFGfmD55EbknTLKWO6FQbAGSTe7aQ23xeOmvA17nLY 6Q3Rp+UfbWaev8wk+nRkm8lWqeGlD7hzpUSmfmWJO+cxD/Sk/aVYku2OmVvsEC4SlWXe DyZx0oBgfJ2n0mqsAIMg/O+9zBKHC4MXENZABc+rG/DF0RngqBFZgnCjDxDx9zs6ZWUd qYkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from:sender :dkim-signature; bh=j/wAlj9+lbLEBeIqsdF+yfeUS1s2V84+JTVk1VCdcTE=; b=PGlLBms5cs3NSMSWyWkC0h366WFeLsOQ/D8VDiPnZYuXyQdRBVup/K8WwDJK3O+fLN ga4cUZemCjyUAhJplnX9TdnP1hA+mBrvkumSqk7OFD+dqoUW36YTOb0Gomi7fh2wBnC5 daOhHO8rMWr6ym2ZR73tvPlbdO0XUg0rCwZQN+17s17zpl96qEk5zFp+PimTw4s+Ct25 QdWm/SY5TZUsSxgy1tITwYzOesMo/raUuvhPlgIgeJ4JQvcZe8Hz80MwpnsMuUfWKuUv FSGzIf4aCyg8rIusJzHs6OKfG0ux716EAhmh7L5s0bk9B1T2ZtJZ/FeveBY6jdIrO8rX w24Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=AEJ5Dr7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa37-20020a17090786a500b007bfe5b7feccsi3859349ejc.55.2022.12.01.01.27.27; Thu, 01 Dec 2022 01:27:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=AEJ5Dr7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbiLAJW1 (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Thu, 1 Dec 2022 04:22:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbiLAJWJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 1 Dec 2022 04:22:09 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5780889AED for <linux-kernel@vger.kernel.org>; Thu, 1 Dec 2022 01:22:07 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id vp12so2696093ejc.8 for <linux-kernel@vger.kernel.org>; Thu, 01 Dec 2022 01:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=j/wAlj9+lbLEBeIqsdF+yfeUS1s2V84+JTVk1VCdcTE=; b=AEJ5Dr7zB416GNoTNHNKS9rh5+Y2xhjAKHwoZGCbN23KANzvgKbjQsTMwcHfU9//gc 7eEuqNfoarSzqd6Hub73JzuxHzfZ3zuKU8KbpyRTmxVxZ8jxQLHg56ngi90cCF+1I+IA ETujKamyy5Lki/kXzCCBzo3ZCdibteSRokDjyYZX6sa+sYTcCUzC47vjDpeOoHjJTFgi LldbFFMwGZoiqaX8LPCS0KrhY+dGHtSyCwpi8DfDbiKu4JcKUTRiGGW0qYhoXcVNL1xz C1ymFTKcSVgFRNt9TI20M1niY9gxYghKhHzmRWDYslmPMfNQ9FTKs+DyFqKxnbtnlWCx 997A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j/wAlj9+lbLEBeIqsdF+yfeUS1s2V84+JTVk1VCdcTE=; b=i0yGl02n6kxRnNhZistUJDyf9h2Cj6zcfTmaJwKUDJTyoiZWzth7ARw70TmvFcgRIi IhrMskPxeGll0wHPE4VivhElr3MhYp/nInN90anjwcVwoRdrpN0IQNAQS96PCD4tuqUY xALGO3DmgUOrHvUls4CzYxU6mvUQhNJkkfn18VcNqyL0YgKvQSA40VbZTa3qGBduUnfQ aVgsH7egVIIEkWuYmUARt4L5o+fxFqH34D/L2ZE8tjfQgXCJ2IibIfwCU0onAb5r27ow P3/p5ybUTVvGY3+4qgNFewxKtKX8qY0gTPnUMctDWwLSaaaI68xi9wW3CAcUs5EAb77k 10bQ== X-Gm-Message-State: ANoB5pkAYrmg0KG5HPzpGSTRdZw/3Qhul7opxDBSZnb1peqF55LyfDww M+wV+NNVdhYhFKa32QbO0yE= X-Received: by 2002:a17:906:1ecf:b0:7ad:902c:d1d6 with SMTP id m15-20020a1709061ecf00b007ad902cd1d6mr43010098ejj.143.1669886525782; Thu, 01 Dec 2022 01:22:05 -0800 (PST) Received: from cizrna.home (cst-prg-44-69.cust.vodafone.cz. [46.135.44.69]) by smtp.gmail.com with ESMTPSA id 18-20020a170906211200b007b29eb8a4dbsm1587879ejt.13.2022.12.01.01.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 01:22:05 -0800 (PST) Sender: Tomeu Vizoso <tomeu.vizoso@gmail.com> From: Tomeu Vizoso <tomeu.vizoso@collabora.com> Cc: italonicola@collabora.com, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Lucas Stach <l.stach@pengutronix.de>, Russell King <linux+etnaviv@armlinux.org.uk>, Christian Gmeiner <christian.gmeiner@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, etnaviv@lists.freedesktop.org (moderated list:DRM DRIVERS FOR VIVANTE GPU IP), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR VIVANTE GPU IP), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 5/7] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055 Date: Thu, 1 Dec 2022 10:21:26 +0100 Message-Id: <20221201092131.62867-6-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221201092131.62867-1-tomeu.vizoso@collabora.com> References: <20221201092131.62867-1-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751003294878259889?= X-GMAIL-MSGID: =?utf-8?q?1751003294878259889?= |
Series |
Support for the NPU in Vim3
|
|
Commit Message
Tomeu Vizoso
Dec. 1, 2022, 9:21 a.m. UTC
This is a compute-only module marketed towards AI and vision
acceleration. This particular version can be found on the Amlogic A311D
SoC.
The feature bits are taken from the Khadas downstream kernel driver
6.4.4.3.310723AAA.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
---
drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
Comments
Hi Tomeu, the changes itself look good to me now, I was just very confused about the ordering of the patches. I would have expected them to be in this order: 1. Add NN cores to chip identities struct (set to 0 for all existing entries in HWDB) 2. Add UAPI warning 3. Add HWDB entry for VIPNano-QI.7120.0055 (having NN cores set to correct value, so you don't touch the entry twice in the same series) Regards, Lucas Am Donnerstag, dem 01.12.2022 um 10:21 +0100 schrieb Tomeu Vizoso: > This is a compute-only module marketed towards AI and vision > acceleration. This particular version can be found on the Amlogic A311D > SoC. > > The feature bits are taken from the Khadas downstream kernel driver > 6.4.4.3.310723AAA. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> > --- > drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 31 ++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c b/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c > index f2fc645c7956..3f6fd9a3c088 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c > @@ -130,6 +130,37 @@ static const struct etnaviv_chip_identity etnaviv_chip_identities[] = { > .minor_features10 = 0x90044250, > .minor_features11 = 0x00000024, > }, > + { > + .model = 0x8000, > + .revision = 0x7120, > + .product_id = 0x45080009, > + .customer_id = 0x88, > + .eco_id = 0, > + .stream_count = 8, > + .register_max = 64, > + .thread_count = 256, > + .shader_core_count = 1, > + .vertex_cache_size = 16, > + .vertex_output_buffer_size = 1024, > + .pixel_pipes = 1, > + .instruction_count = 512, > + .num_constants = 320, > + .buffer_size = 0, > + .varyings_count = 16, > + .features = 0xe0287cac, > + .minor_features0 = 0xc1799eff, > + .minor_features1 = 0xfefbfadb, > + .minor_features2 = 0xeb9d6fbf, > + .minor_features3 = 0xedfffced, > + .minor_features4 = 0xd30dafc7, > + .minor_features5 = 0x7b5ac333, > + .minor_features6 = 0xfc8ee200, > + .minor_features7 = 0x03fffa6f, > + .minor_features8 = 0x00fe0ef0, > + .minor_features9 = 0x0088003c, > + .minor_features10 = 0x108048c0, > + .minor_features11 = 0x00000010, > + }, > }; > > bool etnaviv_fill_identity_from_hwdb(struct etnaviv_gpu *gpu)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c b/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c index f2fc645c7956..3f6fd9a3c088 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_hwdb.c @@ -130,6 +130,37 @@ static const struct etnaviv_chip_identity etnaviv_chip_identities[] = { .minor_features10 = 0x90044250, .minor_features11 = 0x00000024, }, + { + .model = 0x8000, + .revision = 0x7120, + .product_id = 0x45080009, + .customer_id = 0x88, + .eco_id = 0, + .stream_count = 8, + .register_max = 64, + .thread_count = 256, + .shader_core_count = 1, + .vertex_cache_size = 16, + .vertex_output_buffer_size = 1024, + .pixel_pipes = 1, + .instruction_count = 512, + .num_constants = 320, + .buffer_size = 0, + .varyings_count = 16, + .features = 0xe0287cac, + .minor_features0 = 0xc1799eff, + .minor_features1 = 0xfefbfadb, + .minor_features2 = 0xeb9d6fbf, + .minor_features3 = 0xedfffced, + .minor_features4 = 0xd30dafc7, + .minor_features5 = 0x7b5ac333, + .minor_features6 = 0xfc8ee200, + .minor_features7 = 0x03fffa6f, + .minor_features8 = 0x00fe0ef0, + .minor_features9 = 0x0088003c, + .minor_features10 = 0x108048c0, + .minor_features11 = 0x00000010, + }, }; bool etnaviv_fill_identity_from_hwdb(struct etnaviv_gpu *gpu)