From patchwork Wed Nov 30 18:13:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. McKenney" X-Patchwork-Id: 27939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1078109wrr; Wed, 30 Nov 2022 10:15:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4FQpdafUFkeYkd5MKo4/sWLosH/YujNmCtF5QV5CmHawN4fNnKZTHCvcLu4JriXO2UJ2/4 X-Received: by 2002:a05:6402:3644:b0:45f:c7f2:297d with SMTP id em4-20020a056402364400b0045fc7f2297dmr57880697edb.266.1669832131509; Wed, 30 Nov 2022 10:15:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669832131; cv=none; d=google.com; s=arc-20160816; b=nLHkB6/RJ9suMeLACF3Q1vQRvDYtKsDkhrgsipVdFYAorh0W3vNMLtmm3HYkm59PH2 RzkO+Vsmsu5+lxbXVEa09JsWeuwjt67fBZtQFq1Ae82lfLofc1Fi+mmyR6UTOifMNwbm D0YGMKCUmzWBcUlkC/pTTPJChnvVSoQG8+OjTZFGfBVcaHs4WppabO+kjLvNh55k1sML 6N5WM16FPhJ2uiVyviav8pW+0mbIJoi3Fgbh+2v+RwhjdNX98M5s2xDsMnhljizBUVCc Gh1DZQV2Rz5/53P5HswFjIScHM4pkps16xLrIPBZ+EiDAYSbQ5h/AfqGJO7h5A68DXre JLDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uuQBoT0/9VgjI8k7NsHO7zPPIVhrYWCEsChCDjUY0bA=; b=qrZyl3nU4DRrkb5gkFTVjw/TSO2EhWb/VafNPnDJITOMsIyOwKQxmzbpPHUa0Bw6kQ IG4quq7tJCMgpjzmsUeeJ8/xn7TkA+KepkqiuaM8xsHM3jFwerxXVvCYMXQK27iQ6qD9 2+eoekqZH0no7N3jFfGlECoKubSGRMxXieySxEu6a2M98wtDh2MxCXoPpKYPHwi21CV5 7651wsdh9YobaKXm3XX/fIBd+LxCmuSA8rjue3vaEjMT6lGh8F7pYC/wWNCl+ad0HQLd noh0CeKLado32xo5FgX4SwOWzWMNDtMFSwkf9VmHsF7+QgLNDEQVA98pNh6XZj/+yPDX SA8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W8Ib8dqo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ss28-20020a170907c01c00b00780a3097d20si1507451ejc.180.2022.11.30.10.15.07; Wed, 30 Nov 2022 10:15:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W8Ib8dqo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiK3SOO (ORCPT + 99 others); Wed, 30 Nov 2022 13:14:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbiK3SNb (ORCPT ); Wed, 30 Nov 2022 13:13:31 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E66DD862D4; Wed, 30 Nov 2022 10:13:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5F407CE1ACC; Wed, 30 Nov 2022 18:13:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BAC0C433D6; Wed, 30 Nov 2022 18:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669832007; bh=KTUh/BBOVf/jDi48jtrSyvr3uGxVW8ae61JQrk9NyJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W8Ib8dqo0tM2ZZX1nN5aPSqBIQqvc+AFNKQ9RXDNJHY7jdtD5p70hLzIGA+ZplQn9 yNjVd3NK9aPO965vSs9Vxf2u7XONZv0fe7n09XoPaKp9RIKv91a7/I0AQ7kSthytkW Tr4sLMqh6hy03j1NuMEVmSvUV4p4Aw6Ers1Xb9d3m4edfqbeNf2K1i1k8peYxz+01m jFywHwADwCLsnoEfQDXsnQSZERbTmMKe26WKNqh7Ivr5ZSmu4LY07LmV0OSh36uYm2 5yRt7Xd0DlSZXIHyPtgMwz20ir1LCys0eIY5urJHAQqB9g80LnsUGhlFagIHmTJKtZ eZ52DRv0AsnUg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 558095C051C; Wed, 30 Nov 2022 10:13:27 -0800 (PST) From: "Paul E. McKenney" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, Zhen Lei , Joel Fernandes , Frederic Weisbecker , "Paul E . McKenney" Subject: [PATCH rcu 01/16] rcu: Simplify rcu_init_nohz() cpumask handling Date: Wed, 30 Nov 2022 10:13:10 -0800 Message-Id: <20221130181325.1012760-1-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20221130181316.GA1012431@paulmck-ThinkPad-P17-Gen-1> References: <20221130181316.GA1012431@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750945897016496255?= X-GMAIL-MSGID: =?utf-8?q?1750945897016496255?= From: Zhen Lei In kernels built with either CONFIG_RCU_NOCB_CPU_DEFAULT_ALL=y or CONFIG_NO_HZ_FULL=y, additional CPUs must be added to rcu_nocb_mask. Except that kernels booted without the rcu_nocbs= will not have allocated rcu_nocb_mask. And the current rcu_init_nohz() function uses its need_rcu_nocb_mask and offload_all local variables to track the rcu_nocb and nohz_full state. But there is a much simpler approach, namely creating a cpumask pointer to track the default and then using cpumask_available() to check the rcu_nocb_mask state. This commit takes this approach, thereby simplifying and shortening the rcu_init_nohz() function. Signed-off-by: Zhen Lei Reviewed-by: Joel Fernandes (Google) Acked-by: Frederic Weisbecker Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_nocb.h | 34 +++++++++++----------------------- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 0a5f0ef414845..ce526cc2791ca 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -1210,45 +1210,33 @@ EXPORT_SYMBOL_GPL(rcu_nocb_cpu_offload); void __init rcu_init_nohz(void) { int cpu; - bool need_rcu_nocb_mask = false; - bool offload_all = false; struct rcu_data *rdp; - -#if defined(CONFIG_RCU_NOCB_CPU_DEFAULT_ALL) - if (!rcu_state.nocb_is_setup) { - need_rcu_nocb_mask = true; - offload_all = true; - } -#endif /* #if defined(CONFIG_RCU_NOCB_CPU_DEFAULT_ALL) */ + const struct cpumask *cpumask = NULL; #if defined(CONFIG_NO_HZ_FULL) - if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) { - need_rcu_nocb_mask = true; - offload_all = false; /* NO_HZ_FULL has its own mask. */ - } -#endif /* #if defined(CONFIG_NO_HZ_FULL) */ + if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) + cpumask = tick_nohz_full_mask; +#endif + + if (IS_ENABLED(CONFIG_RCU_NOCB_CPU_DEFAULT_ALL) && + !rcu_state.nocb_is_setup && !cpumask) + cpumask = cpu_possible_mask; - if (need_rcu_nocb_mask) { + if (cpumask) { if (!cpumask_available(rcu_nocb_mask)) { if (!zalloc_cpumask_var(&rcu_nocb_mask, GFP_KERNEL)) { pr_info("rcu_nocb_mask allocation failed, callback offloading disabled.\n"); return; } } + + cpumask_or(rcu_nocb_mask, rcu_nocb_mask, cpumask); rcu_state.nocb_is_setup = true; } if (!rcu_state.nocb_is_setup) return; -#if defined(CONFIG_NO_HZ_FULL) - if (tick_nohz_full_running) - cpumask_or(rcu_nocb_mask, rcu_nocb_mask, tick_nohz_full_mask); -#endif /* #if defined(CONFIG_NO_HZ_FULL) */ - - if (offload_all) - cpumask_setall(rcu_nocb_mask); - if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { pr_info("\tNote: kernel parameter 'rcu_nocbs=', 'nohz_full', or 'isolcpus=' contains nonexistent CPUs.\n"); cpumask_and(rcu_nocb_mask, cpu_possible_mask,