From patchwork Wed Nov 30 16:59:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 27914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1043425wrr; Wed, 30 Nov 2022 09:06:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf6eZhZGL2izreg8L7kHvM9vsCeSRs/V0C7bn4gI26KFmkpF6sFI9OOdxEoo+irL+YSfY41o X-Received: by 2002:a17:906:89a0:b0:7bf:ca7b:49de with SMTP id gg32-20020a17090689a000b007bfca7b49demr14013889ejc.296.1669828018632; Wed, 30 Nov 2022 09:06:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669828018; cv=none; d=google.com; s=arc-20160816; b=yy2cXIekAfP4SDOEtCzEXwvpwbvqS9l4oJUmfEDK3GqSBSTpOtrV/6J0DkyfOB2vl+ LSXhRcfifnFVAdf6fGai2oi+m15xTUAuFZxCXdRYwAsNV73vHBhueOyt3l2ydP/c1y+u YZzqv3ZrgiQiM19E/EaXtLvwzv4YhjJwyZ5bgWMDPtgnmn8uKX7fzh7ZBlOoYgDX9oRM TUH/LJuQfimtVv3YcMlFIIM58vv25nUPvsGCu9aenjkRfebbIF+f8z3IutZnZ8jLnXxM aSdUl18hxcFx4vq5CUlHmo9a/fN+lBpIfmn09QJ3XFjCozcnhenfuBQ/N1cEVw5KtCnH gKeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=cAH1mFCXkFqmnEnoZEKkxSOHh+BKrxCtdwzrNc4tgneYPSUJ1tfsGQj305BnzfEQgN XqWtfQSzSxuoL8746GMOwzTvkXnIzlaGmhwffnqaM5di0q6Vy8GeO9oSmdjyL9afWYVG kecp4WIAl87FE5H5yLSboO86P9lI+ESsSc43HZhUtxWU1sQfEMQ+RoYwYW9QDqAWgmmb bpmFKMYxVQr6RuByk/aY6lF6c2e8KuTYV3qIgdV8gyc9MFDNq8Xf7t51kW8/+Q81xi8j ikFbIZ/vyf6Heu7UnkylfzW9Ew0pjE4Vb5r5m0V1+caKz4BBXmU2So2tyPsY3sMnrYVo j88Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=YRIWNKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm21-20020a170907949500b007986956bd8esi1813812ejc.472.2022.11.30.09.06.32; Wed, 30 Nov 2022 09:06:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=YRIWNKwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbiK3RFn (ORCPT + 99 others); Wed, 30 Nov 2022 12:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbiK3RFB (ORCPT ); Wed, 30 Nov 2022 12:05:01 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 596AA70634 for ; Wed, 30 Nov 2022 09:00:04 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so1915442wmb.2 for ; Wed, 30 Nov 2022 09:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=YRIWNKwOKtKOAVADiQlwkkGbVDhFN7bL0mUA71LmY+JBSjuKhPOxzeLxkgQFb6m3rM Pu60RTcJEOLceyYrS6ugloVBqiNKuUzY5HPYruWg0jSoMi7Z+8TPrT/o2jYkvRB2Tqq0 YTxs3ZIO2YNYJ9UerVamih6zqCzRT5qwSSuWzmrjrQmFsZZ5QC/dseAn1rd36uUQMwCZ qJfIPiQhoxCZJi/9QuxwY9P/847Vm8Xl+6w7qG3z1ZGuapVsXynsTngIbVRtir3LNXyD aG08Js6Ilnmj3PA9PjK6Uh1YNJC7MJP7HQXTCuslXY3ALapPSN/w0qLvLNAGHTMIhDUH IY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xm/vpmwhJgDMht8f1OqkuJQbgIo2XHirTX9u59ErmCw=; b=a94a3erza+/TNOvl56wI9RkpK+0eQvTeXoAS5YVc/PybjqkSMXeAKkpofqRdwjRKWg pZgGAcy7eC3SqcrQvz+rqLgcOSBj9FDnL25XBMmix87mobHZ5HedbyS7/qpNHTmh38y+ DxLBL73lrbMR6TzQtii4o0I3Bl4rTis49ia3ydNOiJtbLydByASdHqv6GnB5gIDn53Gf wTR22KmXBetDR3BiQL7MJ3x5dNLozpcGkp3xo3vGrFWMq5t0ujcwuiWBHuRxHj+2NYBm K101dfkdwFloRTnYAgVB+V0YmNYfOE3p/VntMZL5NjaXboIzVSMRsLKwbBtJ3ecwPgN2 6qYA== X-Gm-Message-State: ANoB5pmO2PoKNG4OP4yJVBlb+TrwYJuPBRwHZussa70QvaGXJNXVd3ju SRDTNAhfQcC87j2kZtB8b+8JSQ== X-Received: by 2002:a1c:6a04:0:b0:3cf:77cc:5f65 with SMTP id f4-20020a1c6a04000000b003cf77cc5f65mr39421824wmc.25.1669827602880; Wed, 30 Nov 2022 09:00:02 -0800 (PST) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id fn7-20020a05600c688700b003c6b70a4d69sm2457159wmb.42.2022.11.30.09.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 09:00:02 -0800 (PST) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: devicetree@vger.kernel.org, Guenter Roeck , Jean Delvare , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , Naresh Solanki Subject: [PATCH v3 1/4] hwmon: (pmbus/core): Add status byte to regulator flag map Date: Wed, 30 Nov 2022 17:59:51 +0100 Message-Id: <20221130165955.3479143-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750941448348658109?= X-GMAIL-MSGID: =?utf-8?q?1750941584085555715?= Add PMBus status byte to regulator flag map. Signed-off-by: Naresh Solanki --- Changes: - Remove status input - Add comment for PMBUS status byte. --- drivers/hwmon/pmbus/pmbus_core.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 95e95783972a..a7b4ae0f1f3b 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2751,7 +2751,16 @@ struct pmbus_regulator_status_category { }; static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = { - { + { /* STATUS byte is always present. */ + .func = -1, + .reg = PMBUS_STATUS_BYTE, + .bits = (const struct pmbus_regulator_status_assoc[]) { + { PB_STATUS_IOUT_OC, REGULATOR_ERROR_OVER_CURRENT }, + { PB_STATUS_VOUT_OV, REGULATOR_ERROR_REGULATION_OUT }, + { PB_STATUS_VIN_UV, REGULATOR_ERROR_UNDER_VOLTAGE }, + { }, + }, + }, { .func = PMBUS_HAVE_STATUS_VOUT, .reg = PMBUS_STATUS_VOUT, .bits = (const struct pmbus_regulator_status_assoc[]) { @@ -2768,6 +2777,7 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, { PB_IOUT_OC_FAULT, REGULATOR_ERROR_OVER_CURRENT }, { PB_IOUT_OC_LV_FAULT, REGULATOR_ERROR_OVER_CURRENT }, + { PB_POUT_OP_FAULT, REGULATOR_ERROR_FAIL }, { }, }, }, { @@ -2834,14 +2844,6 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & PB_STATUS_POWER_GOOD_N) *flags |= REGULATOR_ERROR_REGULATION_OUT; } - /* - * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are - * defined strictly as fault indicators (not warnings). - */ - if (status & PB_STATUS_IOUT_OC) - *flags |= REGULATOR_ERROR_OVER_CURRENT; - if (status & PB_STATUS_VOUT_OV) - *flags |= REGULATOR_ERROR_REGULATION_OUT; /* * If we haven't discovered any thermal faults or warnings via