From patchwork Wed Nov 30 07:56:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhang.songyi@zte.com.cn X-Patchwork-Id: 27624 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp790841wrr; Wed, 30 Nov 2022 00:06:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf6reqbM1pwG00Cn688d8ACeS2GUCRnq+/3uQU+4NwLqeE+gfmr78IFIksyTLkwN+T/duhK5 X-Received: by 2002:a05:6a00:408b:b0:56b:ca57:ba8c with SMTP id bw11-20020a056a00408b00b0056bca57ba8cmr41847351pfb.43.1669795601908; Wed, 30 Nov 2022 00:06:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669795601; cv=none; d=google.com; s=arc-20160816; b=o9sG/H1jPLL+2upPfqJXWOoGnSJAmk8r0v3A6TxJNskF/QTm78tudi/7txgNxiEuWf dNAlqX7P9JpQGZ6I5PotubIEPIjAiRXWGAah3A6OJuJxTzVkRQLKadFdot/NYWmlOHQY IQS+J6yMef5+Tr6WfyyoJMQxMVfwrxZkVJ7TCG+a+EQZUkQB4ZC1BpbbbA6UwWIa0Pvg YH8ks5CZA0Y2EEfcZ8FHuiPPPSCvhblq4AkAwNg/S9Uc6ZWIbanxYPesdNMZUXaQuKWT 7YWb6dvLJJcfnn6H3ejb+NHZQb+G2PacOQpoOLBkPRr9kqfhKC3kY1tDdcuBdiJsRQG8 T8kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=pDTF6os7HSbN4HQl6vOa/s1cwsTAKi31mW3QJQmOKeA=; b=AKYYMzRkoqVl+tiKXp/4FFvE35ok6a7dJ5z6VS0O6Va6FqYSZ42pHyyWA7zNHLyIuZ aZOIHPQTGXIZGUd0tK5uEJ5fubQVtqcE0M5/AYgxDR6H/k2MT9LRDDVgdyUrpKWEZ1qP 8SdJk0hkv2QtmqYUaLbANUUTbx6dHrl1lJNM8uPMuX91DTx9LXn9NG39IbwO10gxolUq TccVFoslcxq8neO5QHOzyX79UUFoc0+tTCP5T0Js2LGtdOq8W3Ko2abIT5LqymtmjaIT JFCcrqLiNEf9COzJBM3faq+jqGT5o4CJ9LGSpVWgXkNtNQTAg7ntHuhdnnBXmNQIl8oA V86Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c23-20020a17090a8d1700b001fe1c9436b1si959114pjo.86.2022.11.30.00.06.29; Wed, 30 Nov 2022 00:06:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234269AbiK3H4Q (ORCPT + 99 others); Wed, 30 Nov 2022 02:56:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbiK3H4O (ORCPT ); Wed, 30 Nov 2022 02:56:14 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB4660EBF for ; Tue, 29 Nov 2022 23:56:13 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NMWjm1vltz5BNRf; Wed, 30 Nov 2022 15:56:12 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2AU7u4wB019582; Wed, 30 Nov 2022 15:56:04 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 30 Nov 2022 15:56:06 +0800 (CST) Date: Wed, 30 Nov 2022 15:56:06 +0800 (CST) X-Zmail-TransId: 2af963870c9635e6ca36 X-Mailer: Zmail v1.0 Message-ID: <202211301556064978448@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_pxa=3A_Remove_dev=5Ferr=28=29_afte?= =?utf-8?q?r_platform=5Fget=5Firq=28=29?= X-MAIL: mse-fl1.zte.com.cn 2AU7u4wB019582 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 63870C9C.000 by FangMail milter! X-FangMail-Envelope: 1669794972/4NMWjm1vltz5BNRf/63870C9C.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63870C9C.000/4NMWjm1vltz5BNRf X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750907592619442975?= X-GMAIL-MSGID: =?utf-8?q?1750907592619442975?= From: zhang songyi There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because platform_get_irq() already prints an error Signed-off-by: zhang songyi Reviewed-by: Lubomir Rintel Reviewed-by: Robert Jarzmik --- drivers/soc/pxa/ssp.c | 1 - 1 file changed, 1 deletion(-) -- 2.15.2 diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..7085901b4e4b 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev) ssp->irq = platform_get_irq(pdev, 0); if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); return -ENODEV; }