From patchwork Wed Nov 30 15:32:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kajetan Puchalski X-Patchwork-Id: 27858 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp999414wrr; Wed, 30 Nov 2022 07:41:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf4s/gJpcYZBBtfUhUWk5cau5p2zo4Rs7aUErdGv4MHHxrF97B0CIWKWXZOlbu+UbCC33lSh X-Received: by 2002:a05:6a00:1696:b0:53e:6656:d829 with SMTP id k22-20020a056a00169600b0053e6656d829mr65011211pfc.63.1669822862757; Wed, 30 Nov 2022 07:41:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669822862; cv=none; d=google.com; s=arc-20160816; b=tc8ZWntl9yxmyRpKlGU0J56BRvPNF136NHb+Mn69IC9XAxY9pUChSbaWN9SJLrGfsB B6tvlx1PRug1t0+PaWQrWtAJ0aVLAkq5SI+jzndHt9JAeSTfsBeGmvLt7vPb2rVrWzFk kDXcklhC+rOR0Wm7JUzfKo6sFwN9BLhna/iLSOWwPHpMsWZd6TEl81Hhtz/vmvYlMNKR KJo39jvpbYHaYjyg6hyrW6TGMi2pXN/VIyqFQwaV1kLGd7IfdIy0QvRKQv+dccaa0Awg A3VT6xgFY9WX6giVUXAjRfXmCz4MccvuBwVl5jwtzwVhQgZ/fhnioURehgmNO0MLt/fc 9+TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=anVv06K4voEx8glJ2FPNjL9SygdM/whii5BW5GdM7ks=; b=Y+x+q2qh9HXav7vIrCXqHyEOuG1pfW77hnMCTK8SWVyTCUy1j7g9AjUHRjZmaRO7Xs Hq69jMFvg/jke5uDmC8Xdeu0kdlQXNyYs2V0W/HL2SumtrWJw+xPMrSemxq4/UCEnbXx vCtepwpEV7J7OQnfHABJmXo5ei7FbLu3q33AiF4BYwEUuZOfowbAwE/vmGNYyLVKU9uo IqM3gVH7N1pgDuEu0JpswMsucICdZMzsVmnRBeJlJ1s0mA6G37D1YBIwF5EhgWfz4pzc 1oJzA2pw+UXUE41l8Zyi0LCko6NVXNfsVOVShXd7EvVNhFH9yRiyT4RbhQHP8+BK4QUa Z4nA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p19-20020a170903249300b00188ad330242si1388779plw.131.2022.11.30.07.40.48; Wed, 30 Nov 2022 07:41:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbiK3PdX (ORCPT + 99 others); Wed, 30 Nov 2022 10:33:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiK3PdT (ORCPT ); Wed, 30 Nov 2022 10:33:19 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9DCE41A21C; Wed, 30 Nov 2022 07:33:18 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07C5F1042; Wed, 30 Nov 2022 07:33:25 -0800 (PST) Received: from e126311.arm.com (unknown [10.57.72.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A2FC3F67D; Wed, 30 Nov 2022 07:33:16 -0800 (PST) From: Kajetan Puchalski To: rafael@kernel.org Cc: daniel.lezcano@linaro.org, lukasz.luba@arm.com, Dietmar.Eggemann@arm.com, dsmythies@telus.net, yu.chen.surf@gmail.com, kajetan.puchalski@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v5 1/2] cpuidle: teo: Optionally skip polling states in teo_find_shallower_state() Date: Wed, 30 Nov 2022 15:32:03 +0000 Message-Id: <20221130153204.2085591-2-kajetan.puchalski@arm.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221130153204.2085591-1-kajetan.puchalski@arm.com> References: <20221130153204.2085591-1-kajetan.puchalski@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750936177844842071?= X-GMAIL-MSGID: =?utf-8?q?1750936177844842071?= Add a no_poll flag to teo_find_shallower_state() that will let the function optionally not consider polling states. This allows the caller to guard against the function inadvertently resulting in TEO putting the CPU in a polling state when that behaviour is undesirable. Signed-off-by: Kajetan Puchalski --- drivers/cpuidle/governors/teo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c index d9262db79cae..e2864474a98d 100644 --- a/drivers/cpuidle/governors/teo.c +++ b/drivers/cpuidle/governors/teo.c @@ -258,15 +258,17 @@ static s64 teo_middle_of_bin(int idx, struct cpuidle_driver *drv) * @dev: Target CPU. * @state_idx: Index of the capping idle state. * @duration_ns: Idle duration value to match. + * @no_poll: Don't consider polling states. */ static int teo_find_shallower_state(struct cpuidle_driver *drv, struct cpuidle_device *dev, int state_idx, - s64 duration_ns) + s64 duration_ns, bool no_poll) { int i; for (i = state_idx - 1; i >= 0; i--) { - if (dev->states_usage[i].disable) + if (dev->states_usage[i].disable || + (no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING)) continue; state_idx = i; @@ -469,7 +471,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, */ if (idx > idx0 && drv->states[idx].target_residency_ns > delta_tick) - idx = teo_find_shallower_state(drv, dev, idx, delta_tick); + idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false); } return idx;