Message ID | 20221130150857.67113-2-tmaimon77@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp990463wrr; Wed, 30 Nov 2022 07:23:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf5fXNrH6HVSOJyzHeUU8f1VJbfS3tHFsr+IJwn9CNVBxffkit63HLiuwNsxDioit4Rq9E2X X-Received: by 2002:aa7:dd15:0:b0:46b:c12:29e5 with SMTP id i21-20020aa7dd15000000b0046b0c1229e5mr16279630edv.236.1669821823049; Wed, 30 Nov 2022 07:23:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669821823; cv=none; d=google.com; s=arc-20160816; b=TkitbUXDYtx1+omwqeOq6LD0N+HIAfqyGxFzQkjs7A09eyztBRtC3dQBPe2igP4q67 zyHX49iVS6XbKtCjEMHlOS75nZIU0l03Us9KC1N8AcV1m91FKFD8m3b1PPuT6anhRJ84 82Hu2jevygRRU9d709zKGccFwpzHskf3i8XKSBnmj5F1n4U+8aJyInT5G20idQN0j3Ij /3nAtvKTE9+Mhi/mq6MIig13x9IcbpxseDvNE12HmagVc3Pwz8/2j9TYR4eFzptfxc9E ykPAVmu6RIN2U1w5qVE2p5v4BattNUzPmPVZs5Tu9EB/5tF7zWu3gd4uqaTrQAnf2ri+ 6YWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HaHZjupRPbZqsRe/nWa9eVMxQYCGINYtiOsXoJaeRaY=; b=I971OAI6qCqymuVeHrzXzfE88P6K14mJwuNag0Db2B2g0sHsMIjfXcOriTiOegQJqZ 4XFk504gJvp6MSOvth2dWHCSmbH4rU4UcHwxuvxNl34RUH77c/4b3L9BQ2ex20UgcMSc HD7wrceQqT33H1P1VwvzQR4hKXacN7TXZU1VdevJ4seF3ZN2QlYqO+HbaBOcBxxqA5V5 lWI0GkByksof8EvIPa5MI4mm+g2OXYTS5cx8usNprUs2c434DzXDnOlpBMqJURgJEGci 3phntX+B1mt+AedXsV6Wqw5JpoGhuzioaJ+FVjZo/HN0vWK7oc+5zC7762hxXvKpbPCF RMAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i14-20020a1709064fce00b007c08bfea570si1527498ejw.157.2022.11.30.07.23.19; Wed, 30 Nov 2022 07:23:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiK3PTl (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Wed, 30 Nov 2022 10:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiK3PTi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 30 Nov 2022 10:19:38 -0500 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9ED9E7BFBA; Wed, 30 Nov 2022 07:19:36 -0800 (PST) Received: from NTHCCAS01.nuvoton.com (NTHCCAS01.nuvoton.com [10.1.8.28]) by maillog.nuvoton.com (Postfix) with ESMTP id 732ED1C812A5; Wed, 30 Nov 2022 23:09:01 +0800 (CST) Received: from NTHCML01B.nuvoton.com (10.1.8.178) by NTHCCAS01.nuvoton.com (10.1.8.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Wed, 30 Nov 2022 23:09:01 +0800 Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCML01B.nuvoton.com (10.1.8.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 30 Nov 2022 23:09:01 +0800 Received: from taln60.nuvoton.co.il (10.191.1.180) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Wed, 30 Nov 2022 23:09:00 +0800 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id 19AC063A1E; Wed, 30 Nov 2022 17:09:00 +0200 (IST) From: Tomer Maimon <tmaimon77@gmail.com> To: <ulf.hansson@linaro.org>, <avifishman70@gmail.com>, <tali.perry1@gmail.com>, <joel@jms.id.au>, <venture@google.com>, <yuenn@google.com>, <benjaminfair@google.com>, <adrian.hunter@intel.com>, <skhan@linuxfoundation.org>, <davidgow@google.com>, <pbrobinson@gmail.com>, <gsomlo@gmail.com>, <briannorris@chromium.org>, <arnd@arndb.de>, <krakoczy@antmicro.com>, <andy.shevchenko@gmail.com> CC: <openbmc@lists.ozlabs.org>, <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Tomer Maimon <tmaimon77@gmail.com> Subject: [PATCH v1 1/2] dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller Date: Wed, 30 Nov 2022 17:08:56 +0200 Message-ID: <20221130150857.67113-2-tmaimon77@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20221130150857.67113-1-tmaimon77@gmail.com> References: <20221130150857.67113-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750935088266081431?= X-GMAIL-MSGID: =?utf-8?q?1750935088266081431?= |
Series |
MMC: add NPCM SDHCI driver support
|
|
Commit Message
Tomer Maimon
Nov. 30, 2022, 3:08 p.m. UTC
Add binding for Nuvoton NPCM SDHCI controller.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
.../devicetree/bindings/mmc/npcm,sdhci.yaml | 47 +++++++++++++++++++
1 file changed, 47 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml
Comments
On Wed, Nov 30, 2022 at 05:08:56PM +0200, Tomer Maimon wrote: > Add binding for Nuvoton NPCM SDHCI controller. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../devicetree/bindings/mmc/npcm,sdhci.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > new file mode 100644 > index 000000000000..38409272807a > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/npcm,sdhci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NPCM SDHCI Controller > + > +maintainers: > + - Tomer Maimon <tmaimon77@gmail.com> > + > +properties: > + compatible: > + enum: > + - nuvoton,npcm750-sdhci > + - nuvoton,npcm845-sdhci > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +patternProperties: > + "^sdhci@[0-9a-f]+$": > + type: object sdhci is a child node of the nuvoton,npcm750-sdhci node? > + $ref: mmc-controller.yaml I think you want: allOf: - $ref: mmc-controller.yaml# And then you will have some errors in the example to fix. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + sdhci0: sdhci@f0840000 { Drop unused labels. Node name should be 'mmc' > + compatible = "nuvoton,npcm750-sdhci"; Indent by 4 spaces. > + reg = <0xf0840000 0x200>; > + interrupts = <0 27 4>; > + clocks = <&clk 4>; > + }; > -- > 2.33.0 > >
Hi Rob, Thanks for your comments. Your comments will be addressed next version. On Fri, 2 Dec 2022 at 01:49, Rob Herring <robh@kernel.org> wrote: > > On Wed, Nov 30, 2022 at 05:08:56PM +0200, Tomer Maimon wrote: > > Add binding for Nuvoton NPCM SDHCI controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../devicetree/bindings/mmc/npcm,sdhci.yaml | 47 +++++++++++++++++++ > > 1 file changed, 47 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > > > > diff --git a/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > > new file mode 100644 > > index 000000000000..38409272807a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/npcm,sdhci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NPCM SDHCI Controller > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@gmail.com> > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm750-sdhci > > + - nuvoton,npcm845-sdhci > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > +patternProperties: > > + "^sdhci@[0-9a-f]+$": > > + type: object > > sdhci is a child node of the nuvoton,npcm750-sdhci node? No, will be removed > > > + $ref: mmc-controller.yaml > > I think you want: > > allOf: > - $ref: mmc-controller.yaml# > > And then you will have some errors in the example to fix. > > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + sdhci0: sdhci@f0840000 { > > Drop unused labels. > > Node name should be 'mmc' > > > + compatible = "nuvoton,npcm750-sdhci"; > > Indent by 4 spaces. > > > + reg = <0xf0840000 0x200>; > > + interrupts = <0 27 4>; > > + clocks = <&clk 4>; > > + }; > > -- > > 2.33.0 > > > > Best regards, Tomer
diff --git a/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml new file mode 100644 index 000000000000..38409272807a --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mmc/npcm,sdhci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NPCM SDHCI Controller + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +properties: + compatible: + enum: + - nuvoton,npcm750-sdhci + - nuvoton,npcm845-sdhci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +patternProperties: + "^sdhci@[0-9a-f]+$": + type: object + $ref: mmc-controller.yaml + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + sdhci0: sdhci@f0840000 { + compatible = "nuvoton,npcm750-sdhci"; + reg = <0xf0840000 0x200>; + interrupts = <0 27 4>; + clocks = <&clk 4>; + };