| Message ID | 20221130101852.5408-1-cniedermaier@dh-electronics.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp844246wrr;
Wed, 30 Nov 2022 02:31:55 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf6jJrj/vj14ewD1ZgNaHDVBJ1qZ4MEwwK3+iN5QJtCxYJQeVaE4h9eWTC9mobf4wkIvIAqJ
X-Received: by 2002:a05:6402:24a0:b0:458:ad54:20d5 with SMTP id
q32-20020a05640224a000b00458ad5420d5mr53796765eda.86.1669804315138;
Wed, 30 Nov 2022 02:31:55 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669804315; cv=none;
d=google.com; s=arc-20160816;
b=huI7nG7No2vo3shKn3LRNEabaOCQaVfk0IEUtd0/H6fFYrjkdO9aOA1r0Fp6IWpmiw
xkGW1mD1c1nOvGg3q+WBBW+7zKE9fENzwk1MwpiPBzIifHLAZhdreW9HldgWKLInESWK
SLkfKNeu1GoL91/6CQPhc72nqqDQA1Rjox6WZWRNP3uuDmJmenp7jjSOs+PksWU/hqRT
lDUEWS9qww2scMk4d/8GE2TlgPriAfLeQ5++0mQLEm8u+wWRENCgZR2e/MHSj8WSAIqo
8FSL6pOkjZf/uzQ4HKaDmpJCwvtG17YI/ST22rEDKYLzdCsDQ+NyOd7Zi30YtoUHKKVf
jV9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from
:dkim-signature;
bh=Bjb3a95JxH8fwSaNK37AgYquFmTd2pxLk+nae0XMhx4=;
b=M72voTvHcLOIw/GuiWaE38YHwranXLYzMeyJ8XQSUNSam4PldL7ChL9EcXQgenKWS2
nmUgvleEtw9OOvQ1H3xuU306m4CLRr+iBtadBZ6zAulpWxjUAL+KJZpKgCLlkqtEVz9/
Am3AytxSMafoKo/x9TUsXRMa1mAczeCAmwFgMYPnkXhGbREBBQxzvwZnWPjfPFac/MCo
JXB/hPvNXJedr6MqFOQeM0+WIkn2wxxfzIYGPrT24HkQSIL0HTW3o5zb1kCMtHt7xddZ
mM6SMNI7GBc7aiucNbgronx8nyPqWiLwomDwKocrr4ny3PkfszV9CPhJ5us0UHsknEHQ
5btg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@dh-electronics.com header.s=dhelectronicscom
header.b=IjuNkgOG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=dh-electronics.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ty12-20020a170907c70c00b007ae377adb6asi903146ejc.628.2022.11.30.02.31.31;
Wed, 30 Nov 2022 02:31:55 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@dh-electronics.com header.s=dhelectronicscom
header.b=IjuNkgOG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=dh-electronics.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235903AbiK3Kap (ORCPT <rfc822;heyuhang3455@gmail.com>
+ 99 others); Wed, 30 Nov 2022 05:30:45 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59454 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235850AbiK3KaV (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 30 Nov 2022 05:30:21 -0500
X-Greylist: delayed 587 seconds by postgrey-1.37 at lindbergh.monkeyblade.net;
Wed, 30 Nov 2022 02:30:18 PST
Received: from mx2.securetransport.de (mx2.securetransport.de [188.68.39.254])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 547BB3FBAF;
Wed, 30 Nov 2022 02:30:18 -0800 (PST)
Received: from mail.dh-electronics.com (unknown [77.24.89.57])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by mx2.securetransport.de (Postfix) with ESMTPSA id 8739F5EC41;
Wed, 30 Nov 2022 11:20:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com;
s=dhelectronicscom; t=1669803611;
bh=Bjb3a95JxH8fwSaNK37AgYquFmTd2pxLk+nae0XMhx4=;
h=From:To:CC:Subject:Date:From;
b=IjuNkgOGqhr2Oy8IWhRSWYsh1ndVcZsY+USFVjQhx5H4n0VVw/AOs9MTwjN6mvHnO
CqLqN8VOZlafm3mV8b4Q78AABGYvdD6nfN+2MVjHfpyVnH9KHGgAkxCzWoP0kvsNVe
14WNLtmCBQP6TnxRpfPEBJdigNOPmTwNiPHed+xei/CD50dbmAaYJ04kt/uL0A0mhd
aI6zXG6sxauNK9a5Z0SLiS45YSjVuqBy5nn3NSg/xvAoGStoaDlBO8hKz0Azz00yl+
MvCii2P5r0EZKs9Fmw1RoMZ9ur74xKNC4f3d75rOuuWvRshUEmA3whhTARCOMQ6+UO
u0ki+CyWasG6Q==
Received: from DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) by
DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.20; Wed, 30 Nov 2022 11:20:02 +0100
Received: from localhost.localdomain (172.16.51.2) by
DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.20 via Frontend Transport; Wed, 30 Nov 2022 11:20:01 +0100
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: <linux-kernel@vger.kernel.org>
CC: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Marek Vasut <marex@denx.de>, <kernel@dh-electronics.com>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: [PATCH V2] dt-bindings: mmc: Remove comment on wakeup-source property
Date: Wed, 30 Nov 2022 11:18:52 +0100
Message-ID: <20221130101852.5408-1-cniedermaier@dh-electronics.com>
X-Mailer: git-send-email 2.11.0
X-klartext: yes
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750916729245969397?=
X-GMAIL-MSGID: =?utf-8?q?1750916729245969397?=
|
| Series |
[V2] dt-bindings: mmc: Remove comment on wakeup-source property
|
|
Commit Message
Christoph Niedermaier
Nov. 30, 2022, 10:18 a.m. UTC
The current comment on wakeup-source is a little confusing because
the word deprecated can be interpreted at first glance to mean that
wakeup-source is deprecated. Also mentioning the obsolete property
confuses more than it helps. Therefore, the comment should be removed
completely because the enable-sdio-wakeup property is not used in
any current DTs.
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marek Vasut <marex@denx.de>
Cc: kernel@dh-electronics.com
Cc: linux-mmc@vger.kernel.org
Cc: devicetree@vger.kernel.org
To: linux-kernel@vger.kernel.org
---
V2: - Instead of changing the comment, remove it
---
Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote: > > The current comment on wakeup-source is a little confusing because > the word deprecated can be interpreted at first glance to mean that > wakeup-source is deprecated. Also mentioning the obsolete property > confuses more than it helps. Therefore, the comment should be removed > completely because the enable-sdio-wakeup property is not used in > any current DTs. > > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > --- > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Marek Vasut <marex@denx.de> > Cc: kernel@dh-electronics.com > Cc: linux-mmc@vger.kernel.org > Cc: devicetree@vger.kernel.org > To: linux-kernel@vger.kernel.org > --- > V2: - Instead of changing the comment, remove it > --- > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index 802e3ca8be4d..e82c00368088 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -293,7 +293,6 @@ properties: > description: > SDIO only. Preserves card power during a suspend/resume cycle. > > - # Deprecated: enable-sdio-wakeup > wakeup-source: > $ref: /schemas/types.yaml#/definitions/flag > description: This looks good to me! However, let's also drop the reference to the property from Documentation/devicetree/bindings/power/wakeup-source.txt. Kind regards Uffe
From: Ulf Hansson [mailto:ulf.hansson@linaro.org] Sent: Wednesday, November 30, 2022 12:40 PM > On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier<cniedermaier@dh-electronics.com> wrote: >> >> The current comment on wakeup-source is a little confusing because >> the word deprecated can be interpreted at first glance to mean that >> wakeup-source is deprecated. Also mentioning the obsolete property >> confuses more than it helps. Therefore, the comment should be removed >> completely because the enable-sdio-wakeup property is not used in >> any current DTs. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >> --- >> Cc: Ulf Hansson <ulf.hansson@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> Cc: Marek Vasut <marex@denx.de> >> Cc: kernel@dh-electronics.com >> Cc: linux-mmc@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> To: linux-kernel@vger.kernel.org >> --- >> V2: - Instead of changing the comment, remove it >> --- >> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> index 802e3ca8be4d..e82c00368088 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> @@ -293,7 +293,6 @@ properties: >> description: >> SDIO only. Preserves card power during a suspend/resume cycle. >> >> - # Deprecated: enable-sdio-wakeup >> wakeup-source: >> $ref: /schemas/types.yaml#/definitions/flag >> description: > > This looks good to me! > > However, let's also drop the reference to the property from > Documentation/devicetree/bindings/power/wakeup-source.txt. Should I include this in a version 3 or should I send a separate patch? Regards Christoph
On Wed, 30 Nov 2022 at 12:55, Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote: > > From: Ulf Hansson [mailto:ulf.hansson@linaro.org] > Sent: Wednesday, November 30, 2022 12:40 PM > > On Wed, 30 Nov 2022 at 11:20, Christoph Niedermaier<cniedermaier@dh-electronics.com> wrote: > >> > >> The current comment on wakeup-source is a little confusing because > >> the word deprecated can be interpreted at first glance to mean that > >> wakeup-source is deprecated. Also mentioning the obsolete property > >> confuses more than it helps. Therefore, the comment should be removed > >> completely because the enable-sdio-wakeup property is not used in > >> any current DTs. > >> > >> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > >> --- > >> Cc: Ulf Hansson <ulf.hansson@linaro.org> > >> Cc: Rob Herring <robh+dt@kernel.org> > >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > >> Cc: Marek Vasut <marex@denx.de> > >> Cc: kernel@dh-electronics.com > >> Cc: linux-mmc@vger.kernel.org > >> Cc: devicetree@vger.kernel.org > >> To: linux-kernel@vger.kernel.org > >> --- > >> V2: - Instead of changing the comment, remove it > >> --- > >> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > >> index 802e3ca8be4d..e82c00368088 100644 > >> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > >> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > >> @@ -293,7 +293,6 @@ properties: > >> description: > >> SDIO only. Preserves card power during a suspend/resume cycle. > >> > >> - # Deprecated: enable-sdio-wakeup > >> wakeup-source: > >> $ref: /schemas/types.yaml#/definitions/flag > >> description: > > > > This looks good to me! > > > > However, let's also drop the reference to the property from > > Documentation/devicetree/bindings/power/wakeup-source.txt. > > Should I include this in a version 3 or should I send a separate patch? Please add it in v3, so we can remove the confusing things altogether. Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml index 802e3ca8be4d..e82c00368088 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml @@ -293,7 +293,6 @@ properties: description: SDIO only. Preserves card power during a suspend/resume cycle. - # Deprecated: enable-sdio-wakeup wakeup-source: $ref: /schemas/types.yaml#/definitions/flag description: