From patchwork Tue Nov 29 21:29:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 27520 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp584544wrr; Tue, 29 Nov 2022 13:50:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf5d2v0cI+eclEuVSSjPTp8IB6HyO3LAYzLlTuYu+7H8sf3CwyipgTiCvWflEwU67p6Hb++P X-Received: by 2002:a05:6402:2949:b0:468:fb6b:3a79 with SMTP id ed9-20020a056402294900b00468fb6b3a79mr52442589edb.63.1669758614141; Tue, 29 Nov 2022 13:50:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669758614; cv=none; d=google.com; s=arc-20160816; b=JQb43026sUXz446z6DKILjo/h/dyzSolRt0MW/E/qCnNjovEy295XW0RrLqM59BQJL wTbEyOrCwSEx1V2ixiTBy6u48ohhH7YCsTWz/Z/fa1t4Mwc54llVhqfBNJ0SYuidcdZ1 jXtBS8Ldgp8m4k9DqxXzxOe6WpDaLbr5TDBoPVAfey74aEWK4jJ9h6w9I1D1fJGVqEf9 MyzIwCT2FmqaUO8lulSW48/c9qzzeKP3VoDBH/MeUn58f+TeOtxBoeDwWeMia9NScW1v IA1EFRGnAY4nOajeK4PUlD5+JPcri85wytoL9jCUbiuaEvaTVMzehDFV2s47BOcjwzh7 xqvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lsgOmxMw167o2eXJFVbDhoedN8JpOMEkuaHKi4hzTmA=; b=pBqaIhM96WdZkN/r7kFYd0IVlqW1optcWnCmG8asIVmxLTwWuvuoFcz2qIiDdxbmQ0 QcVtN/QmzyAttimkylH60HN/jABpfJNywbxABHICk3hT9CdQzWUA8yjvtrE25MjhO/2P 7sP00UxMVrguqogi3iwovKT5oAXzU0yb1daZZUVa7qT07xNtJ4GhgpLIeZ2mf2z6OhuW 8PRVsY2bstLt38OOj05pEHrIWtPwh6lW0ob5Aw+U4TXjGyHTwF+ji9OcmNkuXnYBZG+l Os8qkTB04kp25u4DF8hgLxqKUMXFL7jRFp9ydJc5JFVHtchf9Dl1dLvbXShiByd1ewpu TJwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=djwIltTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a056402518d00b004614f376c2fsi15012587edd.88.2022.11.29.13.49.50; Tue, 29 Nov 2022 13:50:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@z3ntu.xyz header.s=z3ntu header.b=djwIltTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236867AbiK2V3t (ORCPT + 99 others); Tue, 29 Nov 2022 16:29:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236072AbiK2V3s (ORCPT ); Tue, 29 Nov 2022 16:29:48 -0500 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E4B5655B; Tue, 29 Nov 2022 13:29:47 -0800 (PST) Received: from g550jk.arnhem.chello.nl (unknown [62.108.10.64]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id DA61BCAAFE; Tue, 29 Nov 2022 21:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1669757356; bh=cyHwj60MQxWv+m1wQhw3cegdMX2JlrYI3TaYhQorhOg=; h=From:To:Cc:Subject:Date; b=djwIltTvulexjuIPgOcxRiEWJlxKVrmB8/k6c7irIRfQyF/zcg+SokWaHQuhmsd2k wZAPEATvtEhvhEuLopoBthJ7I/LPvU9aSzf70GWep87HZNLKfpXK/Md2F4jl1O66Mu UVn8cCWeqLcgqA3+pvb7QdPzClbutk0WasVtEtPE= From: Luca Weiss To: linux-leds@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Luca Weiss , Pavel Machek , Vincent Knecht , linux-kernel@vger.kernel.org Subject: [PATCH] leds: is31fl319x: Fix setting current limit for is31fl319{0,1,3} Date: Tue, 29 Nov 2022 22:29:01 +0100 Message-Id: <20221129212901.1049085-1-luca@z3ntu.xyz> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD, FROM_SUSPICIOUS_NTLD_FP,SPF_HELO_NONE,SPF_PASS,T_PDS_OTHER_BAD_TLD autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750868808751475773?= X-GMAIL-MSGID: =?utf-8?q?1750868808751475773?= The current setting lives in bits 4:2 (as also defined by the mask) but the current limit defines in the driver use bits 2:0 which should be shifted over so they don't get masked out completely (except for 17.5mA which became 10mA). Now checking /sys/kernel/debug/regmap/1-0068/registers shows that the current limit is applied correctly and doesn't take the default b000 = 42mA. Fixes: fa877cf1abb9 ("leds: is31fl319x: Add support for is31fl319{0,1,3} chips") Signed-off-by: Luca Weiss --- Cross-checked with SN3193 datasheet I found online and downstream driver, but please double check also against any info you have. The SN3193 is used on msm8974pro-oneplus-bacon and I will send a patch in the future to add it to the dts. drivers/leds/leds-is31fl319x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index 52b59b62f437..b2f4c4ec7c56 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -38,6 +38,7 @@ #define IS31FL3190_CURRENT_uA_MIN 5000 #define IS31FL3190_CURRENT_uA_DEFAULT 42000 #define IS31FL3190_CURRENT_uA_MAX 42000 +#define IS31FL3190_CURRENT_SHIFT 2 #define IS31FL3190_CURRENT_MASK GENMASK(4, 2) #define IS31FL3190_CURRENT_5_mA 0x02 #define IS31FL3190_CURRENT_10_mA 0x01 @@ -553,7 +554,7 @@ static int is31fl319x_probe(struct i2c_client *client) is31fl3196_db_to_gain(is31->audio_gain_db)); else regmap_update_bits(is31->regmap, IS31FL3190_CURRENT, IS31FL3190_CURRENT_MASK, - is31fl3190_microamp_to_cs(dev, aggregated_led_microamp)); + is31fl3190_microamp_to_cs(dev, aggregated_led_microamp) << IS31FL3190_CURRENT_SHIFT); for (i = 0; i < is31->cdef->num_leds; i++) { struct is31fl319x_led *led = &is31->leds[i];