From patchwork Tue Nov 29 19:19:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 27442 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp525356wrr; Tue, 29 Nov 2022 11:24:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf7hBZnG6GEwt1spdT3Mn+ep+9KGdikil2IPV8VMyt41e3sc6fSJKblUc8eOm4AE7xwraULv X-Received: by 2002:a17:906:19d5:b0:780:93d2:8510 with SMTP id h21-20020a17090619d500b0078093d28510mr35386389ejd.457.1669749841118; Tue, 29 Nov 2022 11:24:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749841; cv=none; d=google.com; s=arc-20160816; b=QwhcT0caQZCQf0yJbEm5lQi/NOk3gUQJ3Ji7vIx7SLjnOgqJMfBObKtisWrd+wLPhn DUfYW/KiW/4FbEe+tZ4B7TYvepMN85mmBdoKGWYp19rLn6rjZPh3xcDtfgNNXYokjwf1 hn+LNKT1XJ0oyvmMqt6Pp1bwOfCjomz1eFdmnreB1jTAwcOAbR26P0sXne+6cnrbapV3 cAyj+ltJ+e7jYy4FO6EhQuLmfdwNprlG3W2pUqp+PkhO4dnb0Gl2Hnw16xrm8dQsncRB 3veUq/meBYO0FiYCpVtWgF8MxIj4MIxB7siysJbHoBxCattCVqZjU8rEclFGPqWS6PqW 4d2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Nveh5A0ZF11TSwS4JhZjKC3Y/bPmA5nmXXuqH0bCb0s=; b=tGkaYH/jIfr2EjeNzfdAFF6UoQ1FMq/v3j2xQ4N3Xxk9O79pZjvanjO0+6/qFJF8kK BT41tIubhB7o2wgKgq8oPLzJCORyaD0tU2Tz7aVyVIocmuTZC/zoCEr0QhlicmBMkaZb bSxaaE3epNhBXpLbwdTss6Hz9PEKQGtXz5pGJglxBn9VmXq5q2Ef4uArerSzxXQdpC7S wOnaLGioHUT5zlYABzjFai1nCmkSh5hNFByWVLN+EEUccJUojBx3/LRlxe7lUv89P08r Ydc0LFUQcvufa2fppYCCwt2CRsqhYkdFcGO1D4h40yiMk79kgJPkdTJNWjUxELYMPJ2c 5baw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=qZiq8zwD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc37-20020a17090716a500b007c00de4e8d5si5334531ejc.798.2022.11.29.11.23.36; Tue, 29 Nov 2022 11:24:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=qZiq8zwD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236915AbiK2TVn (ORCPT + 99 others); Tue, 29 Nov 2022 14:21:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236785AbiK2TVH (ORCPT ); Tue, 29 Nov 2022 14:21:07 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB876DFDF for ; Tue, 29 Nov 2022 11:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nveh5A0ZF11TSwS4JhZjKC3Y/bPmA5nmXXuqH0bCb0s=; b=qZiq8zwD/K3DkQxZ5GuG3/hC3aQghhrXNsAepBuOJBurYhxibjzBrwRyEbNZJZeSI4JF7o VST3H3lVx+lMgiYARwAByWb+BadWzUTojng6SinbWvW9ilQFFg3rxnvI4MAHKd6BzZf0/C NSfgpQjZ3QvRuKc8qOOukBEsEiY+tI8= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Tomi Valkeinen Subject: [PATCH v2 15/26] drm: omap: Remove #ifdef guards for PM related functions Date: Tue, 29 Nov 2022 19:19:31 +0000 Message-Id: <20221129191942.138244-2-paul@crapouillou.net> In-Reply-To: <20221129191942.138244-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> <20221129191942.138244-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859609673997727?= X-GMAIL-MSGID: =?utf-8?q?1750859609673997727?= Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle the .suspend/.resume callbacks. These macros allow the suspend and resume functions to be automatically dropped by the compiler when CONFIG_SUSPEND is disabled, without having to use #ifdef guards. This has the advantage of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. The #ifdef CONFIG_PM guard around omap_gem_resume() was also removed, and replaced by a "if (IS_ENABLED(CONFIG_PM_SLEEP))" guard in-line. The change to CONFIG_PM_SLEEP is because it is only ever called in this configuration. Signed-off-by: Paul Cercueil --- Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 ++---- drivers/gpu/drm/omapdrm/omap_drv.c | 7 +++---- drivers/gpu/drm/omapdrm/omap_gem.c | 5 +++-- drivers/gpu/drm/omapdrm/omap_gem.h | 2 -- 4 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index 61a27dd7392e..14cc4cb457d1 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -1161,7 +1161,6 @@ int tiler_map_show(struct seq_file *s, void *arg) } #endif -#ifdef CONFIG_PM_SLEEP static int omap_dmm_resume(struct device *dev) { struct tcm_area area; @@ -1185,9 +1184,8 @@ static int omap_dmm_resume(struct device *dev) return 0; } -#endif -static SIMPLE_DEV_PM_OPS(omap_dmm_pm_ops, NULL, omap_dmm_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(omap_dmm_pm_ops, NULL, omap_dmm_resume); #if defined(CONFIG_OF) static const struct dmm_platform_data dmm_omap4_platform_data = { @@ -1218,7 +1216,7 @@ struct platform_driver omap_dmm_driver = { .owner = THIS_MODULE, .name = DMM_DRIVER_NAME, .of_match_table = of_match_ptr(dmm_of_match), - .pm = &omap_dmm_pm_ops, + .pm = pm_sleep_ptr(&omap_dmm_pm_ops), }, }; diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index eaf67b9e5f12..5f22e63e26c7 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -877,7 +877,6 @@ static int pdev_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP static int omap_drm_suspend(struct device *dev) { struct omap_drm_private *priv = dev_get_drvdata(dev); @@ -895,14 +894,14 @@ static int omap_drm_resume(struct device *dev) return omap_gem_resume(drm_dev); } -#endif -static SIMPLE_DEV_PM_OPS(omapdrm_pm_ops, omap_drm_suspend, omap_drm_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(omapdrm_pm_ops, + omap_drm_suspend, omap_drm_resume); static struct platform_driver pdev = { .driver = { .name = "omapdrm", - .pm = &omapdrm_pm_ops, + .pm = pm_sleep_ptr(&omapdrm_pm_ops), }, .probe = pdev_probe, .remove = pdev_remove, diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c index cf571796fd26..119e829c40de 100644 --- a/drivers/gpu/drm/omapdrm/omap_gem.c +++ b/drivers/gpu/drm/omapdrm/omap_gem.c @@ -1104,7 +1104,6 @@ void *omap_gem_vaddr(struct drm_gem_object *obj) * Power Management */ -#ifdef CONFIG_PM /* re-pin objects in DMM in resume path: */ int omap_gem_resume(struct drm_device *dev) { @@ -1112,6 +1111,9 @@ int omap_gem_resume(struct drm_device *dev) struct omap_gem_object *omap_obj; int ret = 0; + if (!IS_ENABLED(CONFIG_PM_SLEEP)) + return 0; + mutex_lock(&priv->list_lock); list_for_each_entry(omap_obj, &priv->obj_list, mm_list) { if (omap_obj->block) { @@ -1133,7 +1135,6 @@ int omap_gem_resume(struct drm_device *dev) mutex_unlock(&priv->list_lock); return ret; } -#endif /* ----------------------------------------------------------------------------- * DebugFS diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h index 4d4488939f6b..edcd92ecc2ea 100644 --- a/drivers/gpu/drm/omapdrm/omap_gem.h +++ b/drivers/gpu/drm/omapdrm/omap_gem.h @@ -32,9 +32,7 @@ union omap_gem_size; void omap_gem_init(struct drm_device *dev); void omap_gem_deinit(struct drm_device *dev); -#ifdef CONFIG_PM int omap_gem_resume(struct drm_device *dev); -#endif #ifdef CONFIG_DEBUG_FS void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m);