From patchwork Tue Nov 29 10:07:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 27142 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp244447wrr; Tue, 29 Nov 2022 02:11:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf6CsJEfQSO4zzm6hEQeRKmOnkkw6XJ83Mjng7NlE6XTwWCaFXRDwiTRpXcfIiJQbcaC6jEG X-Received: by 2002:a17:907:9852:b0:7a8:a957:5b4e with SMTP id jj18-20020a170907985200b007a8a9575b4emr7124083ejc.305.1669716710714; Tue, 29 Nov 2022 02:11:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669716710; cv=none; d=google.com; s=arc-20160816; b=p4RCC7ORuqTqivw43OTpTpubN7jpnV62rhxQoZQk5Jq33qIxce2WYjFAKE85vFvuhu U0C3tvBoP5iVTiZ/idg6D+i3Z5Zk0w3Ws30796XBBxqbA3RUoR2rqAJK3kGwY9inSyai ag9aOV6H2tmgOzt5+KwMdrrQrgWFFraqEkXF5CsH8Xn70jaGCMmfUwtVDXtubwbvIPFO Xl+dhB7R6wEHWMghjrDxhGTEeZ0D1koqp4/2F2Kp7eUT8j7+YhVsco9lM0JaTpRFoY9s /NnNyMgLLFZu+Eng6mZchAinVupI/B5OSW4aLgDRnC3/yR+gjJ+k/vSr+3jB4LDzJlU1 Vzgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OorTeZY5veCZ5LS3K7Q06oRrQd7NMVlOQOChi1XNNZg=; b=Zl+xVZae3q9Ok4uwnAtWH/JApuF9pb6EpOZz8zC6BPCvuxz9QkVx1ybc+biwCFoT8G 03fAC+KA5Bxy4Nm4U7B5EanNxcAjW27BZavYuLfh2HvJf9eQgityT9rdPEDQkyGsb7Vl 2J7qb/pwHiwb9//k8+LSzEyng3lsYEuqAmu3tW3a7L6uw8nicPOaO5upsfH5bTAMqcj1 0bK+ZhWQPbx7lb5yV0umZqwnILu9gJABgXAZf8Y0iSSQAtocSZucWYqZLX4/pHzmWSRm Y0BNzBMDLHZTHLPc7TNSNxsBKYlTpl8HmAp+2NdSIyfaQtH80Aj8xz9wS1T5IwfgMGX/ j7mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n18-20020aa7db52000000b0046ae1883662si7510174edt.597.2022.11.29.02.11.26; Tue, 29 Nov 2022 02:11:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232176AbiK2KIN (ORCPT + 99 others); Tue, 29 Nov 2022 05:08:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232151AbiK2KIL (ORCPT ); Tue, 29 Nov 2022 05:08:11 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9584E18357 for ; Tue, 29 Nov 2022 02:08:10 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozxX1-0006y6-My; Tue, 29 Nov 2022 11:08:03 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ozxWy-0012hq-8e; Tue, 29 Nov 2022 11:08:01 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ozxWx-00BYGr-Cp; Tue, 29 Nov 2022 11:07:59 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko , Sascha Hauer Subject: [PATCH v4 02/11] wifi: rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Date: Tue, 29 Nov 2022 11:07:45 +0100 Message-Id: <20221129100754.2753237-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221129100754.2753237-1-s.hauer@pengutronix.de> References: <20221129100754.2753237-1-s.hauer@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750824869688204532?= X-GMAIL-MSGID: =?utf-8?q?1750824869688204532?= rtw_fw_beacon_filter_config() is called once with rtwdev->mutex held and once without the mutex held. Call it consistently with rtwdev->mutex held. Signed-off-by: Sascha Hauer Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 07578ccc4bab3..776a9a9884b5d 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -487,8 +487,8 @@ static int rtw_ops_sta_remove(struct ieee80211_hw *hw, { struct rtw_dev *rtwdev = hw->priv; - rtw_fw_beacon_filter_config(rtwdev, false, vif); mutex_lock(&rtwdev->mutex); + rtw_fw_beacon_filter_config(rtwdev, false, vif); rtw_sta_remove(rtwdev, sta, true); mutex_unlock(&rtwdev->mutex);