diff mbox series

[net-next,v2] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

Message ID 20221129031406.3849872-1-mailhol.vincent@wanadoo.fr
State New
Headers
Series [net-next,v2] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER |

Commit Message

Vincent Mailhol Nov. 29, 2022, 3:14 a.m. UTC 
  As discussed in [1], abbreviating the bootloader to "bl" might not be
well understood. Instead, a bootloader technically being a firmware,
name it "fw.bootloader".

Add a new macro to devlink.h to formalize this new info attribute name
and update the documentation.

[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
---
* Changelog *

v1 -> v2:

  * update the documentation as well.
  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
---
 Documentation/networking/devlink/devlink-info.rst | 5 +++++
 include/net/devlink.h                             | 2 ++
 2 files changed, 7 insertions(+)

Comments

Jiri Pirko Nov. 29, 2022, 8:28 a.m. UTC | #1 
Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@wanadoo.fr wrote:
>As discussed in [1], abbreviating the bootloader to "bl" might not be
>well understood. Instead, a bootloader technically being a firmware,
>name it "fw.bootloader".
>
>Add a new macro to devlink.h to formalize this new info attribute name
>and update the documentation.
>
>[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
>
>Suggested-by: Jakub Kicinski <kuba@kernel.org>
>Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>---
>* Changelog *
>
>v1 -> v2:
>
>  * update the documentation as well.
>  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
>---
> Documentation/networking/devlink/devlink-info.rst | 5 +++++
> include/net/devlink.h                             | 2 ++
> 2 files changed, 7 insertions(+)
>
>diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
>index 7572bf6de5c1..1242b0e6826b 100644
>--- a/Documentation/networking/devlink/devlink-info.rst
>+++ b/Documentation/networking/devlink/devlink-info.rst
>@@ -198,6 +198,11 @@ fw.bundle_id
> 
> Unique identifier of the entire firmware bundle.
> 
>+fw.bootloader
>+-------------
>+
>+Version of the bootloader.
>+
> Future work
> ===========
> 
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index 074a79b8933f..2f552b90b5c6 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE	"fw.roce"
> /* Firmware bundle identifier */
> #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID	"fw.bundle_id"
>+/* Bootloader */
>+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER	"fw.bootloader"

You add it and don't use it. You should add only what you use.
Vincent Mailhol Nov. 29, 2022, 9:28 a.m. UTC | #2 
On Tue. 29 Nov. 2022 at 17:33, Jiri Pirko <jiri@resnulli.us> wrote:
> Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@wanadoo.fr wrote:
> >As discussed in [1], abbreviating the bootloader to "bl" might not be
> >well understood. Instead, a bootloader technically being a firmware,
> >name it "fw.bootloader".
> >
> >Add a new macro to devlink.h to formalize this new info attribute name
> >and update the documentation.
> >
> >[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> >
> >Suggested-by: Jakub Kicinski <kuba@kernel.org>
> >Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> >---
> >* Changelog *
> >
> >v1 -> v2:
> >
> >  * update the documentation as well.
> >  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
> >---
> > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> > include/net/devlink.h                             | 2 ++
> > 2 files changed, 7 insertions(+)
> >
> >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> >index 7572bf6de5c1..1242b0e6826b 100644
> >--- a/Documentation/networking/devlink/devlink-info.rst
> >+++ b/Documentation/networking/devlink/devlink-info.rst
> >@@ -198,6 +198,11 @@ fw.bundle_id
> >
> > Unique identifier of the entire firmware bundle.
> >
> >+fw.bootloader
> >+-------------
> >+
> >+Version of the bootloader.
> >+
> > Future work
> > ===========
> >
> >diff --git a/include/net/devlink.h b/include/net/devlink.h
> >index 074a79b8933f..2f552b90b5c6 100644
> >--- a/include/net/devlink.h
> >+++ b/include/net/devlink.h
> >@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> > #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE  "fw.roce"
> > /* Firmware bundle identifier */
> > #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID     "fw.bundle_id"
> >+/* Bootloader */
> >+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER    "fw.bootloader"
>
> You add it and don't use it. You should add only what you use.

I will use it in this series for the linux-can tree:
https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@wanadoo.fr/

If it is a problem to send this as a standalone patch, I will then
just add it to my series and have the patch go through the linux-can
tree.


Yours sincerely,
Vincent Mailhol
Marc Kleine-Budde Nov. 30, 2022, 5:03 p.m. UTC | #3 
On 29.11.2022 18:28:44, Vincent MAILHOL wrote:
> On Tue. 29 Nov. 2022 at 17:33, Jiri Pirko <jiri@resnulli.us> wrote:
> > Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@wanadoo.fr wrote:
> > >As discussed in [1], abbreviating the bootloader to "bl" might not be
> > >well understood. Instead, a bootloader technically being a firmware,
> > >name it "fw.bootloader".
> > >
> > >Add a new macro to devlink.h to formalize this new info attribute name
> > >and update the documentation.
> > >
> > >[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> > >
> > >Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > >Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > >---
> > >* Changelog *
> > >
> > >v1 -> v2:
> > >
> > >  * update the documentation as well.
> > >  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
> > >---
> > > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> > > include/net/devlink.h                             | 2 ++
> > > 2 files changed, 7 insertions(+)
> > >
> > >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> > >index 7572bf6de5c1..1242b0e6826b 100644
> > >--- a/Documentation/networking/devlink/devlink-info.rst
> > >+++ b/Documentation/networking/devlink/devlink-info.rst
> > >@@ -198,6 +198,11 @@ fw.bundle_id
> > >
> > > Unique identifier of the entire firmware bundle.
> > >
> > >+fw.bootloader
> > >+-------------
> > >+
> > >+Version of the bootloader.
> > >+
> > > Future work
> > > ===========
> > >
> > >diff --git a/include/net/devlink.h b/include/net/devlink.h
> > >index 074a79b8933f..2f552b90b5c6 100644
> > >--- a/include/net/devlink.h
> > >+++ b/include/net/devlink.h
> > >@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> > > #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE  "fw.roce"
> > > /* Firmware bundle identifier */
> > > #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID     "fw.bundle_id"
> > >+/* Bootloader */
> > >+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER    "fw.bootloader"
> >
> > You add it and don't use it. You should add only what you use.
> 
> I will use it in this series for the linux-can tree:
> https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@wanadoo.fr/
> 
> If it is a problem to send this as a standalone patch, I will then
> just add it to my series and have the patch go through the linux-can
> tree.

As you have the Ok from Greg, include this in you v5 series.

Marc
Vincent Mailhol Nov. 30, 2022, 5:52 p.m. UTC | #4 
On Thu. 1 Dec. 2022 at 02:14, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 29.11.2022 18:28:44, Vincent MAILHOL wrote:
> > On Tue. 29 Nov. 2022 at 17:33, Jiri Pirko <jiri@resnulli.us> wrote:
> > > Tue, Nov 29, 2022 at 04:14:06AM CET, mailhol.vincent@wanadoo.fr wrote:
> > > >As discussed in [1], abbreviating the bootloader to "bl" might not be
> > > >well understood. Instead, a bootloader technically being a firmware,
> > > >name it "fw.bootloader".
> > > >
> > > >Add a new macro to devlink.h to formalize this new info attribute name
> > > >and update the documentation.
> > > >
> > > >[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> > > >
> > > >Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > > >Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > > >---
> > > >* Changelog *
> > > >
> > > >v1 -> v2:
> > > >
> > > >  * update the documentation as well.
> > > >  Link: https://lore.kernel.org/netdev/20221129020151.3842613-1-mailhol.vincent@wanadoo.fr/
> > > >---
> > > > Documentation/networking/devlink/devlink-info.rst | 5 +++++
> > > > include/net/devlink.h                             | 2 ++
> > > > 2 files changed, 7 insertions(+)
> > > >
> > > >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
> > > >index 7572bf6de5c1..1242b0e6826b 100644
> > > >--- a/Documentation/networking/devlink/devlink-info.rst
> > > >+++ b/Documentation/networking/devlink/devlink-info.rst
> > > >@@ -198,6 +198,11 @@ fw.bundle_id
> > > >
> > > > Unique identifier of the entire firmware bundle.
> > > >
> > > >+fw.bootloader
> > > >+-------------
> > > >+
> > > >+Version of the bootloader.
> > > >+
> > > > Future work
> > > > ===========
> > > >
> > > >diff --git a/include/net/devlink.h b/include/net/devlink.h
> > > >index 074a79b8933f..2f552b90b5c6 100644
> > > >--- a/include/net/devlink.h
> > > >+++ b/include/net/devlink.h
> > > >@@ -621,6 +621,8 @@ enum devlink_param_generic_id {
> > > > #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE  "fw.roce"
> > > > /* Firmware bundle identifier */
> > > > #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID     "fw.bundle_id"
> > > >+/* Bootloader */
> > > >+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER    "fw.bootloader"
> > >
> > > You add it and don't use it. You should add only what you use.
> >
> > I will use it in this series for the linux-can tree:
> > https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@wanadoo.fr/
> >
> > If it is a problem to send this as a standalone patch, I will then
> > just add it to my series and have the patch go through the linux-can
> > tree.
>
> As you have the Ok from Greg, include this in you v5 series.

This is a different patch. Greg gave me his ACK to export usb_cache_string():
  https://lore.kernel.org/linux-usb/Y3zyCz5HbGdsxmRT@kroah.com/

This is a new patch to add an info attribute for the bootloader in
devlink.h. Regardless, I added it to the v5:
  https://lore.kernel.org/linux-can/20221130174658.29282-5-mailhol.vincent@wanadoo.fr/

@Jakub (and other netdev maintainers): do not pick this, it will go
through linux-can.


Yours sincerely,
Vincent Mailhol
Marc Kleine-Budde Dec. 1, 2022, 9:51 a.m. UTC | #5 
On 01.12.2022 02:52:17, Vincent MAILHOL wrote:
> > > I will use it in this series for the linux-can tree:
> > > https://lore.kernel.org/netdev/20221126162211.93322-4-mailhol.vincent@wanadoo.fr/
> > >
> > > If it is a problem to send this as a standalone patch, I will then
> > > just add it to my series and have the patch go through the linux-can
> > > tree.
> >
> > As you have the Ok from Greg, include this in you v5 series.
> 
> This is a different patch. Greg gave me his ACK to export usb_cache_string():
>   https://lore.kernel.org/linux-usb/Y3zyCz5HbGdsxmRT@kroah.com/

Right, thanks for the clarification. - Too many patches :)

Marc
diff mbox series

Patch

diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
index 7572bf6de5c1..1242b0e6826b 100644
--- a/Documentation/networking/devlink/devlink-info.rst
+++ b/Documentation/networking/devlink/devlink-info.rst
@@ -198,6 +198,11 @@  fw.bundle_id
 
 Unique identifier of the entire firmware bundle.
 
+fw.bootloader
+-------------
+
+Version of the bootloader.
+
 Future work
 ===========
 
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 074a79b8933f..2f552b90b5c6 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -621,6 +621,8 @@  enum devlink_param_generic_id {
 #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE	"fw.roce"
 /* Firmware bundle identifier */
 #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID	"fw.bundle_id"
+/* Bootloader */
+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER	"fw.bootloader"
 
 /**
  * struct devlink_flash_update_params - Flash Update parameters