From patchwork Tue Nov 29 03:01:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 27052 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp95554wrr; Mon, 28 Nov 2022 19:05:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf5sSDQzA/wabWhvnIxC6EIQI5xf5RteLqLLGjQQNeMgcXrW32pbxGnsZiIYXIyfv2LbL+Id X-Received: by 2002:a17:90b:b17:b0:218:a733:25ec with SMTP id bf23-20020a17090b0b1700b00218a73325ecmr45989240pjb.152.1669691131019; Mon, 28 Nov 2022 19:05:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669691131; cv=none; d=google.com; s=arc-20160816; b=P6QEolyAAsUZ58jfRrlCTXMw/r43MlWIS0NcnXy2Ur9lvBHKzx4flS5qeOenZV7JVY VflhRSM0peqXKakVC8fPLM9Tk1K54ktrYVsY6lO++R4VlxunSjlyjxOFj+L2HSjRVMEk Y11PVn8pvPia/1O47BgqjyKCsPSmJ/lpT0BZgUZbpadOUjDWZ+a0lH7tPIizX3eA40Qn t269Q6BS1loi/nlr/+4pDH/sOboB5HB66eRK0kQ8UIxgMtyUiHl96BTgilggipSvy6xM ZKpdNugkUl9LIao8boU3abO4u0WaT0GJ01PuRqg40kfiRZVhvq48TzOoKtFjsx83RZ7y aFjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=xIiDaTRzQYu/CT7gcrbysz66AbK1+PDPmjYR16II8IM=; b=CSLB0viEmcEhL8ZXkud0TBoh8AgxCiRCRRZHi9zAMH0d9lAR6yDFqhuyWclSfAKEWc V/pTzn8mfTl3vLTXk6tJ8sODWM3HQQsKxTSulf12it+i+wVKIfXMz31Li+nfUvV53yTH +taAccChgTgmPJ787+CbfnkAB88vbT4z8htvYAlsyhP8VAtZevVcbK9MJJk2MZccUGW7 mvtJz1HPJ6xS3h+kXBnVUVDkZ9PdtNY2M+ik7CozM5AeTwPNb4GOOJ2/sU/TgLWSHGSR RlOo6q2qW3nFPjD/GKxrgvixjHTVsISDeRktZ32jW44Ph5jxB7MMqufSfOgg72Xq8Qsn hjBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020a056a0024d600b00562a1693523si13082954pfv.20.2022.11.28.19.05.16; Mon, 28 Nov 2022 19:05:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235344AbiK2DCc (ORCPT + 99 others); Mon, 28 Nov 2022 22:02:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235314AbiK2DB6 (ORCPT ); Mon, 28 Nov 2022 22:01:58 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B10E45084; Mon, 28 Nov 2022 19:01:57 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NLn8n0j6jzJp0N; Tue, 29 Nov 2022 10:58:33 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 11:01:54 +0800 From: Kemeng Shi To: , , CC: , , , Subject: [PATCH v2 07/10] blk-throttle: remove incorrect comment for tg_last_low_overflow_time Date: Tue, 29 Nov 2022 11:01:44 +0800 Message-ID: <20221129030147.27400-8-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221129030147.27400-1-shikemeng@huawei.com> References: <20221129030147.27400-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750798047481211895?= X-GMAIL-MSGID: =?utf-8?q?1750798047481211895?= Function tg_last_low_overflow_time is called with intermediate node as following: throtl_hierarchy_can_downgrade throtl_tg_can_downgrade tg_last_low_overflow_time throtl_hierarchy_can_upgrade throtl_tg_can_upgrade tg_last_low_overflow_time throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse from leaf node to sub-root node and pass traversed intermediate node to tg_last_low_overflow_time. No such limit could be found from context and implementation of tg_last_low_overflow_time, so remove this limit in comment. Signed-off-by: Kemeng Shi Acked-by: Tejun Heo --- block/blk-throttle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 4b11099625da..3ddd8a15aa3f 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1762,7 +1762,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq;