diff mbox series

[net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

Message ID 20221129020151.3842613-1-mailhol.vincent@wanadoo.fr
State New
Headers
Series [net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER |

Commit Message

Vincent Mailhol Nov. 29, 2022, 2:01 a.m. UTC 
  As discussed in [1], abbreviating the bootloader to "bl" might not be
well understood. Instead, a bootloader technically being a firmware,
name it "fw.bootloader".

Add a new macro to devlink.h to formalize this new info attribute
name.

[1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
---
 include/net/devlink.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jakub Kicinski Nov. 29, 2022, 2:14 a.m. UTC | #1 
On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> As discussed in [1], abbreviating the bootloader to "bl" might not be
> well understood. Instead, a bootloader technically being a firmware,
> name it "fw.bootloader".
> 
> Add a new macro to devlink.h to formalize this new info attribute
> name.
> 
> [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> 
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

It's okay for this patch to go via the can tree, FWIW.
It may cause an extra delay for you if you have to wait
for the define to propagate.

Either way you should document the meaning of the parameter, 
however obvious it may seem:

 Documentation/networking/devlink/devlink-info.rst
Vincent Mailhol Nov. 29, 2022, 3:08 a.m. UTC | #2 
+CC: Marc and linux-can mailing list.

On Tue. 29 Nov. 2022 at 11:14, Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> > As discussed in [1], abbreviating the bootloader to "bl" might not be
> > well understood. Instead, a bootloader technically being a firmware,
> > name it "fw.bootloader".
> >
> > Add a new macro to devlink.h to formalize this new info attribute
> > name.
> >
> > [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> >
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>
> It's okay for this patch to go via the can tree, FWIW.
> It may cause an extra delay for you if you have to wait
> for the define to propagate.

Marc always pulls from net-next before picking patches and it is a
common practice to send to the linux-can mailing list some series
which are based on net-next. So I do not foresee any major delay.

> Either way you should document the meaning of the parameter,
> however obvious it may seem:
>
>  Documentation/networking/devlink/devlink-info.rst

ACK.

I will send the v2 with both the netdev and the linux-can mailing
list. I am fine whoever picks it.
diff mbox series

Patch

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 074a79b8933f..2f552b90b5c6 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -621,6 +621,8 @@  enum devlink_param_generic_id {
 #define DEVLINK_INFO_VERSION_GENERIC_FW_ROCE	"fw.roce"
 /* Firmware bundle identifier */
 #define DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID	"fw.bundle_id"
+/* Bootloader */
+#define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER	"fw.bootloader"
 
 /**
  * struct devlink_flash_update_params - Flash Update parameters