From patchwork Tue Nov 29 01:29:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 27022 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp58700wrr; Mon, 28 Nov 2022 17:30:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf7UoSXTypof664VQ45tUDAUtw7QRVu6TFXcA6oOp8fPlHJiwdfF8lKdE0fdwG+/C1aClafJ X-Received: by 2002:a17:90a:7649:b0:219:3e67:39dd with SMTP id s9-20020a17090a764900b002193e6739ddmr6379702pjl.156.1669685450402; Mon, 28 Nov 2022 17:30:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669685450; cv=none; d=google.com; s=arc-20160816; b=lGWJKuJioiF3hKobpFxXAPbs0MGuBdScyg5+854req0ZT+HHZtj4DF686QJ9dJeyFJ kwFaLXD1/EcngOd0HjmPhZBfAfJTIx1DMlyy8sOLLWcmNybiyOaR/tifW1LkdReZXJzR xyuV72/uoW9mEytuXg0oKKCaziVvzsk4iOJRi1FOZbx9OJsx0KOLxAJXBkfnrs8Kzln8 MGl3m8no4e2/UQR6TEuyAmf4a88rx2hlL3u9ula4ZtZGZzt6+PV3jbBxLUxdQnxDIB4C 3dX9uLyTzfvcWucec7jNt33qtYxHijtWtgIlV9BKzBDa8Jx1RkUxAnDRfiC5BMizwgVu T8Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RkKMoIaf1e3k/c6jKOA71+0DM6q6riLPXZG91eb46vg=; b=mntx0v0e1zgR8XyEsGfZ4gseBkH5pJUkwjULXuDyElJoX5fCdAih1UdL6PhG3OkMoO oL00IZAtrjH+xlKOnEQVzVBHXeslq4iiQrcB0v7ikptPCePni/6YECATcBFhmiZnaSLO pCNVk1UXoof04wF7SATsw6z/LeiTmnQnYsX8vjx3G9H/ovuJdvPu61sDx5y9BE6F8Ffd mlEDOrcBJD0PVOaSN3OeW9QDC1j3HYTc0nuthWh8jv1CAlTL5Y9sVDV1uVkWx8jd06ue eLlcoD2fSkegraofbOJBJqUvASnRb+Rh15QreZ7UOj1pCdDSfT8wC9TvEXjT6oJXpbyC aK9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i1-20020a63cd01000000b0043c474c8942si12265208pgg.673.2022.11.28.17.30.36; Mon, 28 Nov 2022 17:30:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235065AbiK2B3b (ORCPT + 99 others); Mon, 28 Nov 2022 20:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235058AbiK2B3a (ORCPT ); Mon, 28 Nov 2022 20:29:30 -0500 Received: from out30-1.freemail.mail.aliyun.com (out30-1.freemail.mail.aliyun.com [115.124.30.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDABC40934; Mon, 28 Nov 2022 17:29:28 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VVyDh8n_1669685364; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VVyDh8n_1669685364) by smtp.aliyun-inc.com; Tue, 29 Nov 2022 09:29:25 +0800 From: Yang Li To: paul.kocialkowski@bootlin.com Cc: mchehab@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] staging: media: Remove surplus dev_err() when using platform_get_irq() Date: Tue, 29 Nov 2022 09:29:23 +0800 Message-Id: <20221129012923.111691-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750792090700941368?= X-GMAIL-MSGID: =?utf-8?q?1750792090700941368?= There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is redundant because platform_get_irq() already prints an error Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 Reported-by: Abaci Robot Signed-off-by: Yang Li Acked-by: Jernej Skrabec Acked-by: Paul Kocialkowski --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 7b7947509b69..a6e813ff413a 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -387,7 +387,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); ret = -ENXIO; goto error_clock_rate_exclusive; }