diff mbox series

[net] dsa: lan9303: Correct stat name

Message ID 20221128193559.6572-1-jerry.ray@microchip.com
State New
Headers
Series [net] dsa: lan9303: Correct stat name |

Commit Message

Jerry Ray Nov. 28, 2022, 7:35 p.m. UTC 
  Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

This patch changes the reported ethtool statistics for the lan9303
family of parts covered by this driver.

The TxUnderRun statistic label is renamed to RxShort to accurately
reflect what stat the device is reporting.  I did not reorder the
statistics as that might cause problems with existing user code that
are expecting the stats at a certain offset.

Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
---
 drivers/net/dsa/lan9303-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Nov. 28, 2022, 8:04 p.m. UTC | #1 
On 11/28/22 11:35, Jerry Ray wrote:
> Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")

The Fixes: tag is supposed to come above your Signed-off-by, I don't 
know if the maintainers will fix that up manually or not, but in any case:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> 
> This patch changes the reported ethtool statistics for the lan9303
> family of parts covered by this driver.
> 
> The TxUnderRun statistic label is renamed to RxShort to accurately
> reflect what stat the device is reporting.  I did not reorder the
> statistics as that might cause problems with existing user code that
> are expecting the stats at a certain offset.
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> ---
>   drivers/net/dsa/lan9303-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> index 438e46af03e9..80f07bd20593 100644
> --- a/drivers/net/dsa/lan9303-core.c
> +++ b/drivers/net/dsa/lan9303-core.c
> @@ -961,7 +961,7 @@ static const struct lan9303_mib_desc lan9303_mib[] = {
>   	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
>   	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
>   	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
> -	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
> +	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
>   	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
>   	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
>   	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },
patchwork-bot+netdevbpf@kernel.org Nov. 29, 2022, 2:20 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 28 Nov 2022 13:35:59 -0600 you wrote:
> Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
> 
> This patch changes the reported ethtool statistics for the lan9303
> family of parts covered by this driver.
> 
> The TxUnderRun statistic label is renamed to RxShort to accurately
> reflect what stat the device is reporting.  I did not reorder the
> statistics as that might cause problems with existing user code that
> are expecting the stats at a certain offset.
> 
> [...]

Here is the summary with links:
  - [net] dsa: lan9303: Correct stat name
    https://git.kernel.org/netdev/net/c/39f59bca275d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
index 438e46af03e9..80f07bd20593 100644
--- a/drivers/net/dsa/lan9303-core.c
+++ b/drivers/net/dsa/lan9303-core.c
@@ -961,7 +961,7 @@  static const struct lan9303_mib_desc lan9303_mib[] = {
 	{ .offset = LAN9303_MAC_TX_BRDCST_CNT_0, .name = "TxBroad", },
 	{ .offset = LAN9303_MAC_TX_PAUSE_CNT_0, .name = "TxPause", },
 	{ .offset = LAN9303_MAC_TX_MULCST_CNT_0, .name = "TxMulti", },
-	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "TxUnderRun", },
+	{ .offset = LAN9303_MAC_RX_UNDSZE_CNT_0, .name = "RxShort", },
 	{ .offset = LAN9303_MAC_TX_64_CNT_0, .name = "Tx64Byte", },
 	{ .offset = LAN9303_MAC_TX_127_CNT_0, .name = "Tx128Byte", },
 	{ .offset = LAN9303_MAC_TX_255_CNT_0, .name = "Tx256Byte", },