From patchwork Sat Nov 26 14:18:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 26253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4655049wrr; Sat, 26 Nov 2022 06:18:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aJDHEkAGcjpDnQTduFLkF7g4S7AkD3Lf1izSA2kCFIUMf0xqffbPetTxOSZ9rs8VOySgG X-Received: by 2002:a17:906:381:b0:78c:b8b0:9d35 with SMTP id b1-20020a170906038100b0078cb8b09d35mr28465636eja.586.1669472322471; Sat, 26 Nov 2022 06:18:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669472322; cv=none; d=google.com; s=arc-20160816; b=PaZ0xnuos4TJdtG2k9dGi7g0Ij6ka47z0rQumxwxWa8q7674mDOnt+ZBp5Cww065E/ 0Uh9xyBGktW5UPteAuel+j1WAe7cInBL7AUpthQK25XuDsZpZT6x2sCpYtyziUDQnYff 5J9nDiZ0A/G4SB9RcO8flZGs767F4o68LiDaHOcJQJoL0NOb+hzpUHwEWOISO8An4z6j WmRL5kG/ph+OVY537odNLsrJrIOxNTwVKSNyN3BdvlH2tvHOyAhjk+SzCXGdSHqI2RFV 6QPTidh3ua7ELNftnubblnLrx24ZDGyzuWhbufmJAKMFQtmbQk5+Ne9727rCI+BAJW4n nURw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qlGGkSHrXtusSXd8xa8kBsqj6lC7wEJ6B7BSx6vNvN0=; b=AsXpUmWNEmfsSPkzFg6dsTO7JZ0vHZiIu6GqivkVZTMsx6n7KL1yO7pf2iZFfd1SDZ PWoFjmB0zzsGq/yNdKaXVi7CHGulg4VRzMOtLTi3Q4FcRzhhCdgJbQqAYP8CiqyuDtcs LN1g0cOrDTaKKQuYlQmqBvSXpxowy4IC9GluumxwwggABXpCGKFvKHOT3g/Yf01UQvLK u5gXZaNiCdBmteFXjN2cbXO/3VTXLBX0S3NpByNxaEtjT8FHvEqT8zD7Pv+jRDMdk5IZ H5zV+E9p1JKZK9NQmlwmHD6+su39OnBXqVz8l9QMTdKghHobrdgpX7kn0JqfZWM2iDQN E+PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FY8AE7KU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id br13-20020a170906d14d00b00783c42d2da1si4782713ejb.425.2022.11.26.06.18.19; Sat, 26 Nov 2022 06:18:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FY8AE7KU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiKZOR6 (ORCPT + 99 others); Sat, 26 Nov 2022 09:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiKZORv (ORCPT ); Sat, 26 Nov 2022 09:17:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215F118E23; Sat, 26 Nov 2022 06:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669472271; x=1701008271; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ll+1FVMo/UXGN2SeeyQhin6WVr2RA2XTjdyAG4/biUo=; b=FY8AE7KUgRk7HOwBqmFh2USuaOx4AjWGqjVElFnjZJaODgh4kJlCw1en qLmXynFBR1a4XU5s2Ml7ACxpYDcziXC7VINOraMRAQ6H6XKuRtP33atXw SqgnjRnGnMxv8EQtvFkLlmFCw9FcmGHVjbxKmlol5yCRg3rGs1P40pIya v8NehovDAJZmorWm5+/6Co6xQGGbY1wN8V3M75m/JqTGSCJYOaUib+BId Kjp6kv93rzP/v+XI/OGXM/ddPe5i8iikdvZD8BWk9rBFuJXdVDYGffEHy tB0+/z2HV4qpW87yvDr57SimH/4g7xSqsO2fhRER8kpTGlWyxFBQzaJrG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="315755386" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="315755386" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2022 06:17:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10543"; a="971800597" X-IronPort-AV: E=Sophos;i="5.96,196,1665471600"; d="scan'208";a="971800597" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 26 Nov 2022 06:17:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0BA05B7; Sat, 26 Nov 2022 16:18:11 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v1 2/5] rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L Date: Sat, 26 Nov 2022 16:18:03 +0200 Message-Id: <20221126141806.62205-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750568609820845706?= X-GMAIL-MSGID: =?utf-8?q?1750568609820845706?= We are reading 10-bit value in a 16-bit register in LE format. Make this explicit by using __le16 type for it and corresponding conversion function. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 44058fa27277..bf1aa6f6560d 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -19,6 +19,8 @@ #include #include +#include + /* ISL register offsets */ #define ISL12022_REG_SC 0x00 #define ISL12022_REG_MN 0x01 @@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data, static int isl12022_hwmon_read_temp(struct device *dev, long *mC) { struct regmap *regmap = dev_get_drvdata(dev); - u8 temp_buf[2]; int temp, ret; + __le16 buf; - ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, - temp_buf, sizeof(temp_buf)); + ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, &buf, sizeof(buf)); if (ret) return ret; /* * Temperature is represented as a 10-bit number, unit half-Kelvins. */ - temp = (temp_buf[1] << 8) | temp_buf[0]; + temp = le16_to_cpu(buf); temp *= 500; temp -= 273000;