| Message ID | 20221126125642.16358-1-dzm91@hust.edu.cn |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4621043wrr;
Sat, 26 Nov 2022 05:08:57 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5x54edaw8nKK89JBewTPn91jbyThkMtpBshWeGr+pEShstivfGbL//UBbSeQ0fJBRXGBjp
X-Received: by 2002:a17:902:e54f:b0:189:6a7f:3046 with SMTP id
n15-20020a170902e54f00b001896a7f3046mr6493795plf.88.1669468137322;
Sat, 26 Nov 2022 05:08:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669468137; cv=none;
d=google.com; s=arc-20160816;
b=I2AcxwXhjsuXuQfbpGT7Ok6PJUjHRDc0c9TEXLT+23W0UjAa+rQTbsvadK55F7fmBF
M1ezb4A2DfL4hHcQoHgv5+KHxXm9MU5eqtTpHFoXKel0KUhiuPRC9Y6c+7kp0yrH3Iqi
kSB6Nt0Kd6enB8ESNCiED79JPqLxSdB65eLLASW6FoxGyvbiR87Bko//1at6iBZNosrd
bWUGIsBPEeKpq78PeMgrTDK/0Wi7Jvt8pWlaFS4oAEbshJkEbkCmHgDq0mR1+pNqMwx2
KSItuEpZ9oP7/L0MLiJEtB5g1FYkOochqK+x8NQv5RoGBF/jbRluIzxm5PVD/FAXLJNC
Bb0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=68jOdG5b7YcsBy6gjdjJDs+T/lULF7bs51KRg8nNd7s=;
b=sZC64ilbqEXmfPCHhdY5N3gAcE0QcAvMEzL1um9AO0qSWm17AxZHQ68p6hLD45lwnm
uazExnx28ohLD6RWUvjW/KfpNhkBhEBhSfwqSZRcA4b3JrdWZjoM2OfIu0W8Hm/YEeTk
ay6R28nnSITbmRZQdp7KgGgXmdN7TH1KG9mFTmByIcB5SkxiKyfjlDxsG8P/jh5WgdPW
xDVNHvnTchgUoib4Di74yfhuuwh85UsDqHkd9mMyhISofomS+aAZc2TnYGt9TQPcCpYL
B4Nk4iq1O5BjGdgOi0Zrpbmi4gfC8vz+sC+VX4z4to9nyq7WVDpNOKxkmcpYxhKPqqt1
PZbw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
g10-20020a170902d1ca00b0018967b2d3bcsi4102517plb.93.2022.11.26.05.08.18;
Sat, 26 Nov 2022 05:08:57 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229600AbiKZM5k (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others);
Sat, 26 Nov 2022 07:57:40 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44158 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229535AbiKZM5i (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 26 Nov 2022 07:57:38 -0500
Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D074F00C
for <linux-kernel@vger.kernel.org>;
Sat, 26 Nov 2022 04:57:35 -0800 (PST)
Received: from localhost.localdomain ([172.16.0.254])
(user=dzm91@hust.edu.cn mech=LOGIN bits=0)
by mx1.hust.edu.cn with ESMTP id 2AQCuhbq014203-2AQCuhbt014203
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128
verify=NO);
Sat, 26 Nov 2022 20:56:51 +0800
From: Dongliang Mu <dzm91@hust.edu.cn>
To: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dongliang Mu <dzm91@hust.edu.cn>,
Arnd Bergmann <arnd@arndb.de>,
Mingyi Kang <jerrykang026@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 1/2] staging: vme_user: add list_del in the error handling of
tsi148_dma_list_add
Date: Sat, 26 Nov 2022 20:56:33 +0800
Message-Id: <20221126125642.16358-1-dzm91@hust.edu.cn>
X-Mailer: git-send-email 2.37.1 (Apple Git-137.1)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-FEAS-AUTH-USER: dzm91@hust.edu.cn
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750564221481935627?=
X-GMAIL-MSGID: =?utf-8?q?1750564221481935627?=
|
| Series |
[1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add
|
|
Commit Message
Dongliang Mu
Nov. 26, 2022, 12:56 p.m. UTC
Smatch reports the following issue:
drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add()
warn: '&entry->list' not removed from list
Fix this by adding list_del in the error handling code.
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/staging/vme_user/vme_tsi148.c | 1 +
1 file changed, 1 insertion(+)
Comments
Le 26/11/2022 à 13:56, Dongliang Mu a écrit : > Smatch reports the following issue: > drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add() > warn: '&entry->list' not removed from list > Hi, Not tested with smatch, but I think that moving the list_add_tail() call just a few lines below, when all lights are green, would also fix the issue. Just my 2c, CJ > Fix this by adding list_del in the error handling code. > > Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn> > --- > drivers/staging/vme_user/vme_tsi148.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c > index 020e0b3bce64..0171f46d1848 100644 > --- a/drivers/staging/vme_user/vme_tsi148.c > +++ b/drivers/staging/vme_user/vme_tsi148.c > @@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list, > return 0; > > err_dma: > + list_del(&entry->list); > err_dest: > err_source: > err_align:
diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c index 020e0b3bce64..0171f46d1848 100644 --- a/drivers/staging/vme_user/vme_tsi148.c +++ b/drivers/staging/vme_user/vme_tsi148.c @@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list, return 0; err_dma: + list_del(&entry->list); err_dest: err_source: err_align: