From patchwork Sat Nov 26 02:14:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Shixin X-Patchwork-Id: 26177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4404272wrr; Fri, 25 Nov 2022 17:51:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf56NG6I2PGHUBFkmoGZtc5YWD9WKgnTvlDWufVnhYckvtJADSfIM+IpwRmxifSZrNZoKbxE X-Received: by 2002:a63:4b0f:0:b0:464:203c:b964 with SMTP id y15-20020a634b0f000000b00464203cb964mr19182227pga.270.1669427481524; Fri, 25 Nov 2022 17:51:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669427481; cv=none; d=google.com; s=arc-20160816; b=l5+7fZgHl0/uZ5F2XkUMD8Aa0ZEptVJ+AH1e68/AxYJ3j1hOpfOlxdjUsC46A8Nwy7 B2KuYUKQn2rUYYO6v+IPbeSwiYuRZ/h73ixwH4k+JhYCXotv+rSvc4CC8fFhkGhQvhRg FLQHiVWabtiUEMaKg4TVp6SDxjG/2KOgQs9xvrcUbUu5Srw1JVTkkHuIk7v/jIuD7dhc ij62GLK6953B0ofl6wRu70sXGaktXkJUAUkttYytH3WZksCUESDUag45bnes9dFQQbcD caLLg317CCz9dj4Pn3ofhG+aVj3+itr8UYFv7V/sPCc2fFk4sB4+mNhSVARYFG107W4u f0Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=rAt7iSxBOyirfFaMAFIOscXrpoo3IoQHmpmyndHAZZQ=; b=ImxKqmRKiPKt8F10NWaRCR3egjjSc78ATEJ0jkKYnCGkeAfgqVXtz4zHTU7UCmARgJ M0TUBTXnq5u+Zf4pC5wSW6eLdFxRFq8GQxGCKdB4Fkq5+0NrOHNs/lbful9R8W2ey9+1 ubyKBSGFAMMmI9PRwe91Q1PTvZ78AVqnCmoS0GlDDxsIblZaMu3GQCI+iHmD21MYH9WK 5CAup46z+xSM4UrhVS1eP+KhaIL+qgFChJPheBjrgiVcN1h84fRRlIk7knYn3MpvkhP7 DqWYGVWEQs17b9cpZ9jCPtLQF3xVjeG2hwYE0brupyuL6FhSjjqMA+D9conLeSXwLQJU EIRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lx1-20020a17090b4b0100b00213d1d59224si5702199pjb.136.2022.11.25.17.51.08; Fri, 25 Nov 2022 17:51:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbiKZB1Q (ORCPT + 99 others); Fri, 25 Nov 2022 20:27:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbiKZB1O (ORCPT ); Fri, 25 Nov 2022 20:27:14 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD66543878 for ; Fri, 25 Nov 2022 17:27:13 -0800 (PST) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NJvG51fGyzmW9k; Sat, 26 Nov 2022 09:26:37 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 09:27:12 +0800 Received: from huawei.com (10.175.113.32) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 09:27:11 +0800 From: Liu Shixin To: Jaroslav Kysela , Takashi Iwai CC: , , Liu Shixin Subject: [PATCH] ALSA: asihpi: fix missing pci_disable_device() Date: Sat, 26 Nov 2022 10:14:29 +0800 Message-ID: <20221126021429.3029562-1-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750521590585726619?= X-GMAIL-MSGID: =?utf-8?q?1750521590585726619?= pci_disable_device() need be called while module exiting, switch to use pcim_enable(), pci_disable_device() will be called in pcim_release(). Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.") Signed-off-by: Liu Shixin --- sound/pci/asihpi/hpioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/asihpi/hpioctl.c b/sound/pci/asihpi/hpioctl.c index bb31b7fe867d..477a5b4b50bc 100644 --- a/sound/pci/asihpi/hpioctl.c +++ b/sound/pci/asihpi/hpioctl.c @@ -361,7 +361,7 @@ int asihpi_adapter_probe(struct pci_dev *pci_dev, pci_dev->device, pci_dev->subsystem_vendor, pci_dev->subsystem_device, pci_dev->devfn); - if (pci_enable_device(pci_dev) < 0) { + if (pcim_enable_device(pci_dev) < 0) { dev_err(&pci_dev->dev, "pci_enable_device failed, disabling device\n"); return -EIO;