| Message ID | 20221125195401.61642-2-samuel@sholland.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4259216wrr;
Fri, 25 Nov 2022 12:01:31 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf7DEte8IBPPV6XJqO2aiAr1Gs/hTmJb1fXSCfbzzxgZZBQV6cSC41IEWdrgZqqQyc0uf0er
X-Received: by 2002:aa7:ccd3:0:b0:468:f345:aa4a with SMTP id
y19-20020aa7ccd3000000b00468f345aa4amr36106993edt.412.1669406490996;
Fri, 25 Nov 2022 12:01:30 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669406490; cv=none;
d=google.com; s=arc-20160816;
b=OTyVD0qG9tvX97XkoLgutfFnd3qw9/bi/Czvf1Pea1jleeMgE7vcLdRVBlURKDcrds
S+UhW6cT+KlJlPRQuIH01dQhHQdjMhzq+7xNhEe16nLjphC1+tNcocn+0wKiX0iVQ599
mu/k8bBulsa5X8GFL6WaWSWXhITyLw8IaXIW2cDg963u8uLU5f6p05mCSoQLNqhLFn57
bLYpJcJDHI9WlvGeBatACrmgJkLtmmtF9toejZjNwgWOTqkimyEVABA1Z05ZTtt1MeHL
2muFW3YY452tzxQOXXtaJHvhBLsw3yxiHkwjioYESebGasKMhoBisEJjsG91VrtZBWIV
VUeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:feedback-id:dkim-signature:dkim-signature;
bh=s+PpxXX1k5QU3HQeh+iSdhp6bhrGbLgb0SFaWijnFOs=;
b=zu+RDuN+4WkO1t5IVFPleJMXKjmFbRolOvbpppSBa1OaSapgFpLFiiWGRh1mOxTbAm
PejPjIpk3c8PpsxMxs66ueyodpT1ykUyfm9vgj9w79yhxMWqnx+JToKBZbWcbHMn575s
jQb+2M+HjL9NNuaatyCh/VjvJpgnHsLpl9ih+aP2/vLuy9UGq/o/07tsqiHXcABi5r1q
r6BFxxKn1ACfU+Z+jLACppoIMkWQXyVKYkMSBmB8p+c381tY9YFQrD43nNs17+fdyrNf
cRzfZjofeToT+0+Bb2oEpdqJwvPljqsxPHA+MaqamQb5UjTIvSIWx5IVOha0HQsgk0KY
LVDg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@sholland.org header.s=fm2 header.b=kE+cO2LM;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=XNwTI8yx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
sg33-20020a170907a42100b0077f3a9c58e2si4093628ejc.6.2022.11.25.12.01.05;
Fri, 25 Nov 2022 12:01:30 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@sholland.org header.s=fm2 header.b=kE+cO2LM;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=XNwTI8yx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229847AbiKYTyK (ORCPT <rfc822;zxc52fgh@gmail.com> + 99 others);
Fri, 25 Nov 2022 14:54:10 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34986 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229807AbiKYTyG (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 25 Nov 2022 14:54:06 -0500
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3714355AB9;
Fri, 25 Nov 2022 11:54:06 -0800 (PST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
by mailout.nyi.internal (Postfix) with ESMTP id A6B915C0102;
Fri, 25 Nov 2022 14:54:05 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute5.internal (MEProxy); Fri, 25 Nov 2022 14:54:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h=
cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=fm2; t=1669406045; x=1669492445; bh=s+
PpxXX1k5QU3HQeh+iSdhp6bhrGbLgb0SFaWijnFOs=; b=kE+cO2LMI6NerflRZX
JOuoiJrPOSpB+KOImtGNq9liQovmNHSMcC5mjRBX/yolECy8nGvBW6xy+r3Cgsw5
EBZa6Vt8h/WBCUUMr0F9CqJgmJ2ytTOS/5385UTBKkJX/AYC6WuAc7U8B3/p1E5D
jESF2b9lRaSV/2Y2088K1pjWXVjPVObQ7/latGSVKZ598BUs0WcT7TboQXnPhuip
9G1CWZfhUV6Xgzvk3UC/wgJ2lUgbE9/SHNg2pV+/Rk4qIVqghe07KTuUIKDKOogn
LGW/bH8juBt03obxmvZcrvA/hE8cbicCp1OJ4LM5kHaN3fPeJdN0XMFYWMDCvRRi
yIcw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; t=1669406045; x=1669492445; bh=s+PpxXX1k5QU3
HQeh+iSdhp6bhrGbLgb0SFaWijnFOs=; b=XNwTI8yx7ZMHTp5Qci5vb/1Lui0CX
oJNRhGq2G5j9p8ctaMSloxqdSq8oCJKl+Rb8HhXXff+smSCDMhdBOTBvCWX4pK78
jzwxlqnZWzNjLWhw+ikonNAlLcVPD45dH1KLM/RK0s+G0DeL0thUqKmKSyu/C7ar
pc7eHESSIbBQ+yzZw8TzXEJqhVGql5+f+QotYnOE0oH4kx9IT4qVq5rBffiTdHsI
oWACokr69x+feuUE/wtaXA6k4nFi2l2iP5Un+ouCr19t3ibqWQj+mABocrqald2I
HBQbAruW6rebk5wwmjbhBzxGeELIGxQsNzR2FuXdbKt/hnJp/b9nLpCeA==
X-ME-Sender: <xms:XB2BY68r0j_4iYia-TuHC-JqZzE4tXo1YUtKjfjXDxUHONkoEWFQxw>
<xme:XB2BY6vvBU8VGGevlSB5FFFo0GaFA6q1EbRxD9Xit338BU7PDJ1u6seUEVutLLqRB
sEMTOgQkj_2y_1cQw>
X-ME-Received:
<xmr:XB2BYwAG3y0i3mOjslyMFBjxrJ5nShm-DO5Asc_tWMxKDdXs515zhhpKWW0DIZ09ClrBJFCzcXW7KrAGCwcoNV2AbGwS4OY9jVzeq7hbXzSNpgAUXOTHAzc561748IEa209XTg>
X-ME-Proxy-Cause:
gggruggvucftvghtrhhoucdtuddrgedvgedrieehgddufeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu
vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg
ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg
udefiedtveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh
X-ME-Proxy: <xmx:XB2BYyf6PLTdDO7TfphLzk7vBfuS0XEZcxC7JUbfie_ZNd_Ttz4pTA>
<xmx:XB2BY_NQ7TBZphav5_3ftrrHDMDOzWjbrhFoDT_5s4vj8ZwJhMugQw>
<xmx:XB2BY8llsOadMuAVsPlxmMB9nsHt_oIWaAs3HTIxv3vHBDHtwiZUww>
<xmx:XR2BY6ryMFTSiBMBTNUg-EELKUX2gBJNAsbTFMAZwCwrI_Fiu8IdKg>
Feedback-ID: i0ad843c9:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
25 Nov 2022 14:54:03 -0500 (EST)
From: Samuel Holland <samuel@sholland.org>
To: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev, Karl Palsson <karlp@tweak.net.au>,
Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO
reference
Date: Fri, 25 Nov 2022 13:54:01 -0600
Message-Id: <20221125195401.61642-2-samuel@sholland.org>
X-Mailer: git-send-email 2.37.4
In-Reply-To: <20221125195401.61642-1-samuel@sholland.org>
References: <20221125195401.61642-1-samuel@sholland.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750499580794243311?=
X-GMAIL-MSGID: =?utf-8?q?1750499580794243311?=
|
| Series |
[1/2] ARM: dts: sunxi: Fix GPIO LED node names
|
|
Commit Message
Samuel Holland
Nov. 25, 2022, 7:54 p.m. UTC
The property named in the schema is 'enable-gpios', not 'enable-gpio'.
This makes no difference at runtime, because the regulator is marked as
always-on, but it breaks validation.
Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 25 Nov 2022 13:54:01 -0600 Samuel Holland <samuel@sholland.org> wrote: > The property named in the schema is 'enable-gpios', not 'enable-gpio'. > This makes no difference at runtime, because the regulator is marked as > always-on, but it breaks validation. > > Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2") > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts > index 43641cb82398..343b02b97155 100644 > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts > @@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator { > regulator-ramp-delay = <50>; /* 4ms */ > > enable-active-high; > - enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ > + enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ > gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > gpios-states = <0x1>; > states = <1100000 0>, <1300000 1>;
Dne petek, 25. november 2022 ob 20:54:01 CET je Samuel Holland napisal(a): > The property named in the schema is 'enable-gpios', not 'enable-gpio'. > This makes no difference at runtime, because the regulator is marked as > always-on, but it breaks validation. > > Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2") > Signed-off-by: Samuel Holland <samuel@sholland.org> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts index 43641cb82398..343b02b97155 100644 --- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts @@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator { regulator-ramp-delay = <50>; /* 4ms */ enable-active-high; - enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ + enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ gpios-states = <0x1>; states = <1100000 0>, <1300000 1>;