From patchwork Fri Nov 25 13:54:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 26020 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp4038131wrr; Fri, 25 Nov 2022 06:01:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5gBa+gARB5jHI8U+nJfFANrEw1/f4iY+3CE3ESIHhKMSHGGE7kEKahODG7SWWhmmWZxzAN X-Received: by 2002:a17:906:4c92:b0:78d:ad29:396f with SMTP id q18-20020a1709064c9200b0078dad29396fmr32284823eju.165.1669384878683; Fri, 25 Nov 2022 06:01:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669384878; cv=none; d=google.com; s=arc-20160816; b=QmUxTQb3gFXlxttH9znpzv78j8iAda+dvJUngy0cCcr4LvG+HkpFhZerbpeIAEdj3v xCef8zyqqt08Z4IEj1bS+yNOt2MI3konBab/qZh6WRjJCdwzn/WpNaq5ZfkXQ6xJ6ajR 2WrBaAreVBu/HylFM/ggp+tf4EYuKQ8fPH5ApjJ300ZukP2bhFbSeMr6wKNWUJojWgmq S6i4hRPgsKLAILwngtCfKSucmJusCqfscFuM1ORIhyNbbBhaNGt1++FAwQJ5Y1LuMOx1 o3wShUB5VNNcIKl8BEhIO7xJFwCmpcTd1iP4pxXSBUd24mr153NwGQImScQWdgTpCJqX fVxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x27sSVS1Lg0kLoQjmQESjOUYq/MQacKhznRORjG2m+w=; b=xmeZtLzUjBT0JCxFKq39MjIbpGf2ArTr89T+iQMw3ZFbLiEtagqF8LzhEK0PmNogyp A/yJGrgqjNSizc5GnEqpEV4WDB8Zh52Tg9LWxWI3VeBlz5aEAZHjlaKzd7tIorV/D6Tf qaR8FbUMqU9YCXDU+gjPDy9LSPNPW5ujKFEX1o9F9N7d3tHfmjfUz81PSAOrs2KtHl50 bfmjR/zyJGts0lSBCaADaqFwotXbjRE8B7qPp+sv3SPzTOnKsmxTt+jKOuzqWtwXwA8f QlWmPFd+U023DTS3UhjyM7qQjCm3tb0AIo+HN5yx7bgEFFXL5o2s3X/G1iqG3EQVYqW5 3U3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PWrTou2x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p15-20020a50cd8f000000b00462ab8923ccsi1968536edi.600.2022.11.25.06.00.45; Fri, 25 Nov 2022 06:01:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PWrTou2x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbiKYNzP (ORCPT + 99 others); Fri, 25 Nov 2022 08:55:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiKYNzN (ORCPT ); Fri, 25 Nov 2022 08:55:13 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54431AD8F; Fri, 25 Nov 2022 05:55:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51DB36245A; Fri, 25 Nov 2022 13:55:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4754C433C1; Fri, 25 Nov 2022 13:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669384511; bh=ALLACmzXC6lYKmELWY0sATEsOCq01HNEAVNMSA5sSNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PWrTou2xJP0lqm6s5QPAORWmW0j8jfCxhnCMQeUbEiz3F0QA3AxuIpCRAkk6inw5p wEDcwPD1DlhwzX8kvszAKdvuVCvPhw+Dvkee6PRXx0kK9u+EG71tWNxOce0XX/WyOg 6I9TlVrT6Ds+SlvRt/8s1gXR8efW9OiazXwJwX0Uv8GBHlUx1UHellIjcY/tApFMOz gDfyGplUPEmCE0qcRmw1AyGPAcsYOKjecreO+qjAWsISQvsifq0uCCqmBnvsbWZ5t0 rjDY9oLXtHLIKgJe9vsrsBRNCqBRUkXaON89nIoi4DeUIM2KnFGrAvr8TNoTR9jDFa POLinGPxc460Q== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , "Eric W . Biederman" , Neeraj Upadhyay , Oleg Nesterov , Pengfei Xu , Boqun Feng , Lai Jiangshan , rcu@vger.kernel.org Subject: [PATCH 2/3] rcu-tasks: Remove preemption disablement around srcu_read_[un]lock() calls Date: Fri, 25 Nov 2022 14:54:59 +0100 Message-Id: <20221125135500.1653800-3-frederic@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221125135500.1653800-1-frederic@kernel.org> References: <20221125135500.1653800-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750476918583357879?= X-GMAIL-MSGID: =?utf-8?q?1750476918583357879?= Ever since the following commit: 5a41344a3d83 ("srcu: Simplify __srcu_read_unlock() via this_cpu_dec()") SRCU doesn't rely anymore on preemption to be disabled in order to modify the per-CPU counter. And even then it used to be done from the API itself. Therefore and after checking further, it appears to be safe to remove the preemption disablement around __srcu_read_[un]lock() in exit_tasks_rcu_start() and exit_tasks_rcu_finish() Suggested-by: Boqun Feng Suggested-by: Paul E. McKenney Suggested-by: Neeraj Upadhyay Cc: Lai Jiangshan Signed-off-by: Frederic Weisbecker --- kernel/rcu/tasks.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 7deed6135f73..9a8114114b48 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1008,9 +1008,7 @@ EXPORT_SYMBOL_GPL(show_rcu_tasks_classic_gp_kthread); */ void exit_tasks_rcu_start(void) __acquires(&tasks_rcu_exit_srcu) { - preempt_disable(); current->rcu_tasks_idx = __srcu_read_lock(&tasks_rcu_exit_srcu); - preempt_enable(); } /* @@ -1022,9 +1020,7 @@ void exit_tasks_rcu_finish(void) __releases(&tasks_rcu_exit_srcu) { struct task_struct *t = current; - preempt_disable(); __srcu_read_unlock(&tasks_rcu_exit_srcu, t->rcu_tasks_idx); - preempt_enable(); exit_tasks_rcu_finish_trace(t); }