diff mbox series

rtc: isl12026: drop obsolete dependency on COMPILE_TEST

Message ID 20221124154359.039be06c@endymion.delvare
State New
Headers
Series rtc: isl12026: drop obsolete dependency on COMPILE_TEST |

Commit Message

Jean Delvare Nov. 24, 2022, 2:43 p.m. UTC 
  Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni Dec. 12, 2022, 11:47 p.m. UTC | #1 
On Thu, 24 Nov 2022 15:43:59 +0100, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> [...]

Applied, thanks!

[1/1] rtc: isl12026: drop obsolete dependency on COMPILE_TEST
      commit: 28e93c214af6af9f5a8d5d4d0de0e36668708a4b

Best regards,
diff mbox series

Patch

--- linux-6.0.orig/drivers/rtc/Kconfig
+++ linux-6.0/drivers/rtc/Kconfig
@@ -432,7 +432,7 @@  config RTC_DRV_ISL12022
 
 config RTC_DRV_ISL12026
 	tristate "Intersil ISL12026"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  If you say yes here you get support for the
 	  Intersil ISL12026 RTC chip.