From patchwork Thu Nov 24 14:47:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 25597 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3441254wrr; Thu, 24 Nov 2022 06:51:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf7J/ierx9gsdT610QSsAerD97buy4ZwU00WwaXseVYkgK9eFlRePrcUdxaZB/IDi9scyHl5 X-Received: by 2002:a17:906:e2cb:b0:7ad:c35a:ad76 with SMTP id gr11-20020a170906e2cb00b007adc35aad76mr28328872ejb.705.1669301500781; Thu, 24 Nov 2022 06:51:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669301500; cv=none; d=google.com; s=arc-20160816; b=dxUVqh9BdOLvEpHs3KZdvA44B3B7fXrPPIV2XuZUQ9q1g7Bv/4jI1k4FS9mBDvxhCy 9HkM7ZqzsnMMssClqiL8XQEsuUPKywpd9n6s8zwLqKeD0jRm1Xggu3mrQecKLRE/FlBe 7xpJRBR44aH8D8/qigV9vx2042IxX1ci3p6zbZWNy5cNaPuIl+q2iNraGNvR6+vqs8oV db4MI+iAKzzmrGfTdqLULSZUe3CRtWN4Oqc8IVY48wji6oNLalFS8S3NdclGYosAH3jC sD4L2Iko0GrJfm91JSZJ6sve9afQKcQANPfnt1T9K6NeeKuxnFKAeq9VJHYIaMPo5hLZ +hsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=WcOCAs9ZVgnNGVvow70VfY49Za+ClC3IQk3rx6S1K1c=; b=xBFMs2mH5+XQ/LxQCO05noLTZIjSL0rqXuGsEVYhBBWYBj5CJrCwOAoRgSCt4FvAIz oeqr+LGDzqmHzQiFCvsM7b/NwIVVnfzc4NhkYeJ2XvtityjJTiq3iX+oapa4e9EUBdZq QE9PpdOl6YrepjXcuFhDADpMndUq9eapZ2kBYRZxn1q4GWipvSiTWahuB3yqv9NsTfDU NVFDohJ0u++U1NxqN0LiL6wPuyQ8P3LrHxLspH9i9HLVTdDmzm6fsjo3eBUiqwZuXbYB ghDmCwrq3YhuPSGC8FVERc4UKmeSWkrt4onmJHNDTz1QBhGOPy31426NRkK0XWofwznG jAoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020a50eac6000000b004674aa77346si1284095edp.72.2022.11.24.06.51.10; Thu, 24 Nov 2022 06:51:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbiKXOsj (ORCPT + 99 others); Thu, 24 Nov 2022 09:48:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiKXOs2 (ORCPT ); Thu, 24 Nov 2022 09:48:28 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D85E0740; Thu, 24 Nov 2022 06:48:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 724B9B8283D; Thu, 24 Nov 2022 14:48:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AFE2C43148; Thu, 24 Nov 2022 14:48:25 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oyDWa-001Wrx-03; Thu, 24 Nov 2022 09:48:24 -0500 Message-ID: <20221124144823.893546314@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 24 Nov 2022 09:47:55 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , stable@vger.kernel.org, Daniel Bristot de Oliveira , Jonathan Corbet Subject: [for-linus][PATCH 3/6] tracing/osnoise: Fix duration type References: <20221124144752.427194398@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750389490317593194?= X-GMAIL-MSGID: =?utf-8?q?1750389490317593194?= From: Daniel Bristot de Oliveira The duration type is a 64 long value, not an int. This was causing some long noise to report wrong values. Change the duration to a 64 bits value. Link: https://lkml.kernel.org/r/a93d8a8378c7973e9c609de05826533c9e977939.1668692096.git.bristot@kernel.org Cc: stable@vger.kernel.org Cc: Daniel Bristot de Oliveira Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Jonathan Corbet Fixes: bce29ac9ce0b ("trace: Add osnoise tracer") Signed-off-by: Daniel Bristot de Oliveira Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_osnoise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 78d536d3ff3d..4300c5dc4e5d 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -917,7 +917,7 @@ void osnoise_trace_irq_entry(int id) void osnoise_trace_irq_exit(int id, const char *desc) { struct osnoise_variables *osn_var = this_cpu_osn_var(); - int duration; + s64 duration; if (!osn_var->sampling) return; @@ -1048,7 +1048,7 @@ static void trace_softirq_entry_callback(void *data, unsigned int vec_nr) static void trace_softirq_exit_callback(void *data, unsigned int vec_nr) { struct osnoise_variables *osn_var = this_cpu_osn_var(); - int duration; + s64 duration; if (!osn_var->sampling) return; @@ -1144,7 +1144,7 @@ thread_entry(struct osnoise_variables *osn_var, struct task_struct *t) static void thread_exit(struct osnoise_variables *osn_var, struct task_struct *t) { - int duration; + s64 duration; if (!osn_var->sampling) return;