From patchwork Thu Nov 24 02:30:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SmlheGluIFl1ICjkv57lrrbpkasp?= X-Patchwork-Id: 25287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3152021wrr; Wed, 23 Nov 2022 18:39:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf4X4uygt5TvLSaV84QZodLV2qPqP80j9fyjpOfhYAMcBsaCwWhMyOrErPLB8aG4h7POaVAV X-Received: by 2002:a17:90a:b018:b0:214:247a:1932 with SMTP id x24-20020a17090ab01800b00214247a1932mr33655681pjq.187.1669257575050; Wed, 23 Nov 2022 18:39:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669257575; cv=none; d=google.com; s=arc-20160816; b=nRuJq0Pm84oDbJf5pvmEsisEpCG43lGOXdAPrzBk0zJMAWDlgQ2zalN7dZPMZg9yUP eSsulY3zJx/fu8LDVNgPFEFQFPyCor4qVyN972x6M3jdLBklLfPUpe2Xwhp5RSqjiz4h SZPZ6BV880VNZF8ut82msb0AX2zSo89I2ClsGnyL86BmGto8+7mC1vUlvTbBhBplnlCb zlPvfZ3JimiWGXUl+KYwBZX7wM/NbIAyrh1W4Q4FUgMb90PFOg9LoqDfVWd9gF4Bbp5E DsF5XflU8YgbAZPOw740ft6ZVMAGDFIOYUtWfKwxVQNIr7K5H6tw+psLtJmJknPqCJS0 ASLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=V62CK7vIlndfUw1CoKmHyZxgPytNIVD7jU/ImKsOJCU=; b=A8EjHQIfDIysAtXTdoYwkVZ+E5OSoIeO+Spvq+mNrgyi7COV2pDNmySvZds5LHc+sm o7Z/wRRrCDucz+B+PJXA0XDshl/SwoWf4JLzKcJDdApVVNMfsj2GYV7/Fb2le57j4+us L4XtE3rJqsuqQo+f02Dv3yIcbDm2Eoz0XcpLzrxj3OI8dOCigzUJmHtFo/LLUApKcKLa cLg/I9PWrFZGk5JXePNdPPa/d5vpeMfUWeffOwv0gYJ3cR9Cpg2NHlYYqs8Ls4KvaDCt EVDbJTwnfB2MJzE+Pwis5GQ+ZL5M+JS093cr821ANqYHcr83YMe2Nt9U6K4hMZvoiYbr XNpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=nGjAb4g8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cp7-20020a170902e78700b00176c59140c5si194698plb.138.2022.11.23.18.39.22; Wed, 23 Nov 2022 18:39:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=nGjAb4g8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbiKXCbI (ORCPT + 99 others); Wed, 23 Nov 2022 21:31:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiKXCbH (ORCPT ); Wed, 23 Nov 2022 21:31:07 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54A8E54B09 for ; Wed, 23 Nov 2022 18:31:01 -0800 (PST) X-UUID: 26a3c0fb0a9c48a48847613d1d10f148-20221124 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=V62CK7vIlndfUw1CoKmHyZxgPytNIVD7jU/ImKsOJCU=; b=nGjAb4g8RsuAKlHtObnIYRVBs6gEdgMcd0vbS7Ve4ih9MN0WSIlS9FqEnnCIKENzaxKUevM7NBMXP8HVlachk0LRPza9e2QMjEz6sDVC1rI6rscANSlOrfzvJ9J5xgGt/P8Nw6EX/w8yZRmVh65zyWGP1VeRAGbcql0Bp7h3oT8=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.12,REQID:9fe4b923-43a9-419f-993d-70cf3f4e17f3,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:62cd327,CLOUDID:8601aa2f-2938-482e-aafd-98d66723b8a9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 26a3c0fb0a9c48a48847613d1d10f148-20221124 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1157067141; Thu, 24 Nov 2022 10:30:57 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 24 Nov 2022 10:30:55 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 24 Nov 2022 10:30:54 +0800 From: Jiaxin Yu To: , , CC: , , , , , , , Jiaxin Yu Subject: [PATCH v2] ASoC: mediatek: mt8186: Correct I2S shared clocks Date: Thu, 24 Nov 2022 10:30:50 +0800 Message-ID: <20221124023050.4470-1-jiaxin.yu@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750304873653252609?= X-GMAIL-MSGID: =?utf-8?q?1750343430875781469?= In mt8186 platform, I2S2 should be the main I2S port that provide the clock, on the contrary I2S3 should be the second I2S port that use this clock. Fixes: 9986bdaee477 ("ASoC: mediatek: mt8186: Configure shared clocks") Signed-off-by: Jiaxin Yu Reviewed-by: AngeloGioacchino Del Regno --- Change since v1: Add Fixes tag. --- sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c | 2 +- sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c b/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c index d8c93d66b4e6..970b980a81e6 100644 --- a/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c +++ b/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c @@ -192,7 +192,7 @@ static int mt8186_mt6366_da7219_max98357_hdmi_init(struct snd_soc_pcm_runtime *r struct mt8186_mt6366_da7219_max98357_priv *priv = soc_card_data->mach_priv; int ret; - ret = mt8186_dai_i2s_set_share(afe, "I2S3", "I2S2"); + ret = mt8186_dai_i2s_set_share(afe, "I2S2", "I2S3"); if (ret) { dev_err(rtd->dev, "Failed to set up shared clocks\n"); return ret; diff --git a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c index e59d92e2afa3..8f77a0bc1dc8 100644 --- a/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c +++ b/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c @@ -260,7 +260,7 @@ static int mt8186_mt6366_rt1019_rt5682s_hdmi_init(struct snd_soc_pcm_runtime *rt struct mt8186_mt6366_rt1019_rt5682s_priv *priv = soc_card_data->mach_priv; int ret; - ret = mt8186_dai_i2s_set_share(afe, "I2S3", "I2S2"); + ret = mt8186_dai_i2s_set_share(afe, "I2S2", "I2S3"); if (ret) { dev_err(rtd->dev, "Failed to set up shared clocks\n"); return ret;