From patchwork Wed Nov 23 23:13:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Ogness X-Patchwork-Id: 25238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3079588wrr; Wed, 23 Nov 2022 15:15:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf7K82oRD+R/yvVgoQezTVZdi+03EeWfBQqI9/kshsjhM5BnO5ce+/oKn7xw1DS+j82AK61J X-Received: by 2002:a17:906:3fce:b0:7ad:bb54:75d3 with SMTP id k14-20020a1709063fce00b007adbb5475d3mr25196118ejj.484.1669245307898; Wed, 23 Nov 2022 15:15:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669245307; cv=none; d=google.com; s=arc-20160816; b=uQsxOycUzpdAGr5RmRkXP6NoIc+XyGldgs5QymadLD/DEZarjZkUL0MkG0obUsJagP LubGpGNZJwvdBbb+sJbL/gO9wF9sX3jD8/3iwcCozzSWdq3pr7q3nuwHXeSHLgPnHzNa qBsj517UEbpFCaJqeyBzvt7Lx8y0QfpoOSRsMsjzUpymj65qPG8yRWZnVwl4BoZddE1N NsCbvm3WyHU0D8K5GBnyxwbFvVfvaxtjXAlUwku/8Eh6xlpZv3rrvT+In45ZbhLioSLL jAcq/iHd44OFYGYT35MD5fdlbznWNGdZQTv86JqpDNSTqxPtzFFYQdZkcoD/giKoj448 vTBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=F3opJ7HlbeLq3ffu10RUcIJy4CWkVQ7ilUuqExGzyjQ=; b=CjU/ftidSzGavjeL4/YcpSiIyMuuItXor66iWpehbjbEgQ+qBqYRnP0/Wf9r8Su3YU Q2AE3w1MuZcQphstGnZ33u2F2QJaxy8mv8uXeXgCtj6HQJcvdE53Ao1+gxw9G5/Zk4Pt laWudDT8m4nsbsXpiCW0YU+MPM94Cu3Kq/odF/cnhhwU5AEiB+2+BPssgxQoenFsN95L f3jeD3y/EZ/KPmiyuTDBYTM5Qj4QBocz4tKWftBVOimahQmjOmwb4rKwimXi4Jou5LbE l7g3c8fyqgXtvN2eFmC1DTachOu5W206hGUo6e/BxUzLXH6LIcvSTgiGWz3xy6vNovOu V00A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dqKa6Wr1; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a170906a18b00b007adf6f0f962si12799023ejy.291.2022.11.23.15.14.43; Wed, 23 Nov 2022 15:15:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dqKa6Wr1; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbiKWXOX (ORCPT + 99 others); Wed, 23 Nov 2022 18:14:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiKWXOO (ORCPT ); Wed, 23 Nov 2022 18:14:14 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E2F0B8572 for ; Wed, 23 Nov 2022 15:14:13 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669245251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F3opJ7HlbeLq3ffu10RUcIJy4CWkVQ7ilUuqExGzyjQ=; b=dqKa6Wr1Wdtr4Pf6qxKwBGE8yTiS7HowAJnEYkCsZBht7qIyYlU5t6DYmzm13I2y+RtbTV GQmYX/78A+otM0IMGWAFs+Y5Yzio/l6x2vEFdNBI5LS6YHUYLcaYyphjdnirY4nnEkW9uI XtGAsuz649cQinBcrr2jDcHqvLZSF+nLyDRCRE3J57uru/WsBNw8CLF2dRVCuxh30J9ojw g9LEF8wT0kdeROQt6PLP47saUTwI24kWk8sx2xRXnHWkD9K5TQpbDMEzysrC8DcD6Zv491 EZ/gDsWJRgHC6y0TL9wTL9WZa8XdioUUiR6bAklSK4lHnKwJ1xb6QN5FiF3gww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669245251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F3opJ7HlbeLq3ffu10RUcIJy4CWkVQ7ilUuqExGzyjQ=; b=W1ydZ2KGZJWegCfX3wzYey2lDEjnY0PfPIF0wpO9cLHp6C/dqNGjtEdLsYkchSQ65Qk7t2 lwhG+M7/4iWYbFDg== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH printk v2 2/7] console: Use BIT() macros for @flags values Date: Thu, 24 Nov 2022 00:19:55 +0106 Message-Id: <20221123231400.614679-3-john.ogness@linutronix.de> In-Reply-To: <20221123231400.614679-1-john.ogness@linutronix.de> References: <20221123231400.614679-1-john.ogness@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,INVALID_DATE_TZ_ABSURD, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750330567893156721?= X-GMAIL-MSGID: =?utf-8?q?1750330567893156721?= From: Thomas Gleixner Rather than manually calculating powers of 2, use the BIT() macros. Also take this opportunatity to cleanup and restructure the value comments into proper kerneldoc comments. Signed-off-by: Thomas Gleixner Signed-off-by: John Ogness Reviewed-by: Petr Mladek --- include/linux/console.h | 46 ++++++++++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/include/linux/console.h b/include/linux/console.h index 799fc3216aad..f7a14ea6bae0 100644 --- a/include/linux/console.h +++ b/include/linux/console.h @@ -15,6 +15,7 @@ #define _LINUX_CONSOLE_H_ 1 #include +#include #include #include @@ -139,18 +140,43 @@ static inline int con_debug_leave(void) /* * The interface for a console, or any other device that wants to capture * console messages (printer driver?) - * - * If a console driver is marked CON_BOOT then it will be auto-unregistered - * when the first real console is registered. This is for early-printk drivers. */ -#define CON_PRINTBUFFER (1) -#define CON_CONSDEV (2) /* Preferred console, /dev/console */ -#define CON_ENABLED (4) -#define CON_BOOT (8) -#define CON_ANYTIME (16) /* Safe to call when cpu is offline */ -#define CON_BRL (32) /* Used for a braille device */ -#define CON_EXTENDED (64) /* Use the extended output format a la /dev/kmsg */ +/** + * cons_flags - General console flags + * @CON_PRINTBUFFER: Used by newly registered consoles to avoid duplicate + * output of messages that were already shown by boot + * consoles or read by userspace via syslog() syscall. + * @CON_CONSDEV: Indicates that the console driver is backing + * /dev/console. + * @CON_ENABLED: Indicates if a console is allowed to print records. If + * false, the console also will not advance to later + * records. + * @CON_BOOT: Marks the console driver as early console driver which + * is used during boot before the real driver becomes + * available. It will be automatically unregistered + * when the real console driver is registered unless + * "keep_bootcon" parameter is used. + * @CON_ANYTIME: A misnomed historical flag which tells the core code + * that the legacy @console::write callback can be invoked + * on a CPU which is marked OFFLINE. That is misleading as + * it suggests that there is no contextual limit for + * invoking the callback. The original motivation was + * readiness of the per-CPU areas. + * @CON_BRL: Indicates a braille device which is exempt from + * receiving the printk spam for obvious reasons. + * @CON_EXTENDED: The console supports the extended output format of + * /dev/kmesg which requires a larger output buffer. + */ +enum cons_flags { + CON_PRINTBUFFER = BIT(0), + CON_CONSDEV = BIT(1), + CON_ENABLED = BIT(2), + CON_BOOT = BIT(3), + CON_ANYTIME = BIT(4), + CON_BRL = BIT(5), + CON_EXTENDED = BIT(6), +}; struct console { char name[16];