From patchwork Wed Nov 23 09:00:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhang.songyi@zte.com.cn X-Patchwork-Id: 24804 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2673488wrr; Wed, 23 Nov 2022 01:02:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf7GiPoyx4JEShUKR1x2sDHIXhLhUmSh95CruwmIusKVjIu81PnW1a3CbSZQ1XCzVjYUOix0 X-Received: by 2002:a05:6402:388e:b0:468:fb0d:2d8b with SMTP id fd14-20020a056402388e00b00468fb0d2d8bmr22865836edb.124.1669194120219; Wed, 23 Nov 2022 01:02:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669194120; cv=none; d=google.com; s=arc-20160816; b=qjP8XeJitmJ94d31z3HgH5Y3CFd0uiychyKCgs/6VQEwpzgmmUSM+7CMvBVB8yChoF X+t92gPxZvmoPWGKQBqYottxH3dcZLXTYvp9YxwwhRSMNYHRHQpCnBWPaV8CKsfY4pU4 C47umPHJJ5K44CE/+EM5hLX2iP8bLLwnsxFlsqIijLgeNCL9Q4POUhl6BU8pi1g64mzO NBZVTj/kfz4UUPcvwGtPjx3Yxi3G19ox53vK+QU9Te50IfEo8SkWOVmzCttLXBji6S5t 2v2DPjdYzQPCjdjfUoqVCEJp8xAso8Se14A3Se4y0zLWhcLNisB4PGI2/Mrxc2uInI/w ZmZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=qoT2C4StqRTsoR5flHT6vPYJVKbh1GN5QyF2LX37SZI=; b=TjY6rbDdprkrZ52osOti1led/WIlXsfDs70ZG+iUSOn6T4uDwpgYYeaSZ+1+nCDmWd Z2QI7NVVpFMouBJkLVzipKE9DQRSSXsF9TTa1a3p1cit6/9MhKrX/+hJVTxj4I/bApiJ piIarNg6QViAK9YGTi8FNSyV57UEKQoSXnDTHkmQhKl9Fadgqg0dP70xAh48DTfENpkn SPQYip6c5qSrUz2YyqpdXD1QvpeHvNWFuls8OK0R6hUEpmOoHPWTv2dI7jFn9SAh1zgT obo5JuedpdZ5rr1TN9BNMZN6L6QfXinHZyUX6XhBg58AzI3QQVMA7mBT5Kuv6tMShxIJ zkKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js2-20020a17090797c200b007ae75edfa25si16638988ejc.63.2022.11.23.01.01.36; Wed, 23 Nov 2022 01:02:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236872AbiKWJBK (ORCPT + 99 others); Wed, 23 Nov 2022 04:01:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236880AbiKWJBG (ORCPT ); Wed, 23 Nov 2022 04:01:06 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B363FFA8A; Wed, 23 Nov 2022 01:01:02 -0800 (PST) Received: from mxct.zte.com.cn (unknown [192.168.251.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NHFTk5yf8z8RV6H; Wed, 23 Nov 2022 17:00:58 +0800 (CST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NHFTh3b9Sz4y0tt; Wed, 23 Nov 2022 17:00:56 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2AN90mIR055180; Wed, 23 Nov 2022 17:00:48 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid31; Wed, 23 Nov 2022 17:00:50 +0800 (CST) Date: Wed, 23 Nov 2022 17:00:50 +0800 (CST) X-Zmail-TransId: 2afa637de14266b30956 X-Mailer: Zmail v1.0 Message-ID: <202211231700506267036@zte.com.cn> Mime-Version: 1.0 From: To: , Cc: , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_perf_stat=3A_remove_redundant_vari?= =?utf-8?q?able_in?= =?utf-8?q?_arch=5Fget=5Ftopdown=5Fpmu=5Fname?= X-MAIL: mse-fl2.zte.com.cn 2AN90mIR055180 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.137.novalocal with ID 637DE14A.000 by FangMail milter! X-FangMail-Envelope: 1669194058/4NHFTk5yf8z8RV6H/637DE14A.000/192.168.251.13/[192.168.251.13]/mxct.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 637DE14A.000/4NHFTk5yf8z8RV6H X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750276893883296427?= X-GMAIL-MSGID: =?utf-8?q?1750276893883296427?= From: zhang songyi Return value from arch_get_topdown_pmu_name directly instead of taking this in another redundant variable. Signed-off-by: zhang songyi Acked-by: Ian Rogers --- tools/perf/arch/x86/util/topdown.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.15.2 diff --git a/tools/perf/arch/x86/util/topdown.c b/tools/perf/arch/x86/util/topdown.c index 54810f9acd6f..5a5cdd6efe4d 100644 --- a/tools/perf/arch/x86/util/topdown.c +++ b/tools/perf/arch/x86/util/topdown.c @@ -84,8 +84,6 @@ bool arch_topdown_sample_read(struct evsel *leader) const char *arch_get_topdown_pmu_name(struct evlist *evlist, bool warn) { - const char *pmu_name; - if (!perf_pmu__has_hybrid()) return "cpu"; @@ -95,9 +93,7 @@ const char *arch_get_topdown_pmu_name(struct evlist *evlist, bool warn) evlist->hybrid_pmu_name = perf_pmu__hybrid_type_to_pmu("core"); } - pmu_name = evlist->hybrid_pmu_name; - - return pmu_name; + return evlist->hybrid_pmu_name; } int topdown_parse_events(struct evlist *evlist)