From patchwork Wed Nov 23 13:23:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ekaterina Esina X-Patchwork-Id: 24984 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2801877wrr; Wed, 23 Nov 2022 05:56:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf5CjXTjc3lcVBH6PnIm7Wct76it7rftZ1s8TQgBLr2QDgHaHwEyTpq/9Ez/57k4Yrc2qt1Q X-Received: by 2002:a17:906:a113:b0:7b2:7c9a:1849 with SMTP id t19-20020a170906a11300b007b27c9a1849mr23859664ejy.733.1669211761485; Wed, 23 Nov 2022 05:56:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669211761; cv=none; d=google.com; s=arc-20160816; b=yp0yyskjej/VKm8pZxFVXUWWiItH5vYOIijkLUjPS0e6L18sPf/I9Xnn1oETdBPgUu aOKOHM00QFNe99S2AjjlJYPpzRpzxNt3ecGJZHXjw36LTjHJ3d41bnr3gWH79DQPaQyn ROj/Wb9O3YQSweWhV8pAi8b7m3AwPmNfEjtRR6c4ugJiP2vWLOiTvo/z0AKX0iA7kfRt 8dKrz08FPnwkyCkZaN8NgNGRWuDp/wb+Sm5ADeY8MmJUGAFaDBFW3GLZNju1CuZy3Jw9 mNlF3MovsLHosBbpWlV98+Diadhx6ynuIZbuWFUznJ/pBCBHwJTeBoTz0+dgkLmvSVTR OZ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ymhRI628S2dd0Bb9L/ZOJz6YsdD772pUWkQ754kVsDw=; b=S2AW5o7Yh8ktPr4WvYOwNUOSMN8iPaSKFIWvV6p8cJMC99yWsLuSwM8weDU/TT08el 5EbL62ODzWN51lmCsuZvJyOR9lDJAqPZIxH2MNJ/Z25j0Ak8npyGKjw5ZPcmEq6Bs7p+ EdSpZCAoxfNog9T2Ngc6S2fLkDslxgGCVwNBEtGX4XqZDz8xWBs2GfbeyT//gkRKBPrM z9jiLJzlx0uFUm2DAdaITTvcWiYRR7LORsxc4WDCFMIyHHcLUytl/YD1nDC03q4UVlie Ipdl3jgA5rIo9dsubMgacXe1FNSoZ7gDmY+pVlpZ9JypAZjBK18yT7zgquMn20PvexSG +ZgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a056402355000b004637be0f76csi15967778edd.186.2022.11.23.05.55.36; Wed, 23 Nov 2022 05:56:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238817AbiKWNhi (ORCPT + 99 others); Wed, 23 Nov 2022 08:37:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237897AbiKWNgu (ORCPT ); Wed, 23 Nov 2022 08:36:50 -0500 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2B7767F67 for ; Wed, 23 Nov 2022 05:24:45 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 9F6BD18643A3; Wed, 23 Nov 2022 16:24:41 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id WO4GhI7u6oeA; Wed, 23 Nov 2022 16:24:41 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 55512186439D; Wed, 23 Nov 2022 16:24:41 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rDVj4VrMS6RK; Wed, 23 Nov 2022 16:24:41 +0300 (MSK) Received: from astra.astralinux.ru (unknown [10.177.20.52]) by mail.astralinux.ru (Postfix) with ESMTPSA id EF3451863DD4; Wed, 23 Nov 2022 16:24:40 +0300 (MSK) From: Ekaterina Esina To: Greg Kroah-Hartman Cc: Ekaterina Esina , Won Kang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] gdm7240: Add check for NULL for callback in r Date: Wed, 23 Nov 2022 16:23:45 +0300 Message-Id: <20221123132345.7071-1-eesina@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750295391995522405?= X-GMAIL-MSGID: =?utf-8?q?1750295391995522405?= Before dereferencing r->callback check it for NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 61e121047645 ("staging: gdm7240: adding LTE USB driver") Signed-off-by: Ekaterina Esina --- drivers/staging/gdm724x/gdm_usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index 54bdb64f52e8..7cf89f4c95c4 100644 --- a/drivers/staging/gdm724x/gdm_usb.c +++ b/drivers/staging/gdm724x/gdm_usb.c @@ -409,10 +409,12 @@ static void do_rx(struct work_struct *work) switch (cmd_evt) { case LTE_GET_INFORMATION_RESULT: if (set_mac_address(hci->data, r->cb_data) == 0) { - r->callback(r->cb_data, + if (r->callback) { + r->callback(r->cb_data, r->buf, r->urb->actual_length, KERNEL_THREAD); + } } break;