From patchwork Wed Nov 23 06:03:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 24721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2617417wrr; Tue, 22 Nov 2022 22:13:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf6XCgHhnmlJYXNSIo/SwgnIJVfFj61KsheiYVBmIbjzE+fZuuNRl51w6m3HAvUx6ipwCHse X-Received: by 2002:a17:906:1682:b0:78d:6ba1:74dd with SMTP id s2-20020a170906168200b0078d6ba174ddmr23439603ejd.119.1669184026771; Tue, 22 Nov 2022 22:13:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669184026; cv=none; d=google.com; s=arc-20160816; b=ALM0Q1k/367hzULb+sgaEP8T2k2Ly6yGiC9QCkWfyNn2D8NW3QE8GDBuf+/1BwivEN 0AvvgHy9NS7wfIhspUzIyesVtF99XGJXhUIi1b+LydxDL0GilvJxsTh1SN6g7n4YP7+d jyr3z/6eI4vgWuJyhbBMLh9OW1ct70MNVwb/VGtuEQ+BOdh2Eik2iEXkjWzmVJ6V1aFF OBo7NNmeC47v1n83USCnyjKVvqPD9hJKYloaBCs3ZWJEZuczN0QUrbme62KJ7iP0Yn3y HFG/ShGLbOJ1Gx2RC+Q12qL/rCLXL7eWGmzaHyhVqSiuXMAGPo8OUqYvw76dDXRxTkTQ lQPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Tbs+45x2l07CRaAe8zsFdTxHzDuaUUWGgMr4VDYrD8A=; b=Ml3HeULHNYNdiMpJrzNgu+ZrA3zMTTH5lDh1NftAMuoH2b2Pm4RCBLURNCtcwd23Vk lsbTDkQOGONbqiubR2DTYDe+4/3NRCN0wMY5bSZsOll8tnMOf2t8o3099C+gERtI4iMH wJRizhsMQeJX6Xwkz7kTdGrK60XXFn4hgqzR/xs0G+VFhIVGDaO7UeI3xJ+dXEEZrnpW HQaPm9B0UZ5iIU4Xm4zPQohEtYds6uKdBnxofQMA4WUFpeGawm7M2TUQddXZTLG1KfVq vsLUHlllD1jvfNizeO7ELPCs9Gyd6IzZIjYLZnCN23ccNgzwkjN+uf7tcBn0ceTjaFsK 929A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020a056402054f00b0046a085157f3si1648365edx.313.2022.11.22.22.13.22; Tue, 22 Nov 2022 22:13:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235917AbiKWGEm (ORCPT + 99 others); Wed, 23 Nov 2022 01:04:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235644AbiKWGEL (ORCPT ); Wed, 23 Nov 2022 01:04:11 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24A68F2C05; Tue, 22 Nov 2022 22:04:11 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NH9Y101kYzHw2C; Wed, 23 Nov 2022 14:03:32 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 14:04:08 +0800 From: Kemeng Shi To: , , CC: , , , Subject: [PATCH 07/11] blk-throttle: remove incorrect comment for tg_last_low_overflow_time Date: Wed, 23 Nov 2022 14:03:57 +0800 Message-ID: <20221123060401.20392-8-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221123060401.20392-1-shikemeng@huawei.com> References: <20221123060401.20392-1-shikemeng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750266310129708403?= X-GMAIL-MSGID: =?utf-8?q?1750266310129708403?= Function tg_last_low_overflow_time is called with intermediate node as following: throtl_hierarchy_can_downgrade throtl_tg_can_downgrade tg_last_low_overflow_time throtl_hierarchy_can_upgrade throtl_tg_can_upgrade tg_last_low_overflow_time throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse from leaf node to sub-root node and pass traversed intermediate node to tg_last_low_overflow_time. No such limit could be found from context and implementation of tg_last_low_overflow_time, so remove this limit in comment. Signed-off-by: Kemeng Shi Acked-by: Tejun Heo --- block/blk-throttle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 0aa21832cb96..bd07f562c799 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1746,7 +1746,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq;