From patchwork Wed Nov 23 05:10:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suman Ghosh X-Patchwork-Id: 24707 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2601040wrr; Tue, 22 Nov 2022 21:16:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf5DGHBEIPwz3UWeJ0tUVSr+ux6XC0fi1/1PbAYelAf+XcNqWwnbOXJYUgtVkwrGPiTj82ap X-Received: by 2002:a05:6402:1f85:b0:462:2410:9720 with SMTP id c5-20020a0564021f8500b0046224109720mr23953764edc.84.1669180584872; Tue, 22 Nov 2022 21:16:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669180584; cv=none; d=google.com; s=arc-20160816; b=sw4f71DuYsQofgsviygIGMt2i3/SDZkhoReDk7UcSnaaLYzmX2+FFToFkvjJo9GGp/ OsPmDm8tuvMq06wqCb6kIzjmDhTbCCI+QC3OO/SJzBCyh1wgIQn9EcAXJhCnYnhB9MUo VQNr5UIIHwgHHuHAlR5OSLSO8tJVk69yhoJLbhBjW8onS9wPiD9SWc7VKTzpjR674NfV t80N5LpEJSTc8TFenpxrEtDTHqjsUEwI/+hXT8SpXR+RJLCqCv0auCoBOjeiw8PUNuge /bqOBzElj71fOYUySjutv/qnM0pEz3vqexZFZHKighE2kMN6oggKLHvBKfs8g8Lu2Y7x S95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TV6BMAeIiWmo9w705vQkZmR+KDIeD1FDKBzuZo4LV90=; b=WGjnZBTc0Rvyrh+XZUafp0n5GgT0jYDvC7F1iI39umW0+TZLiKb88kR561DTsB4W+6 0Os5ZX6o1KsFQ8gZi2KONwHWnLKao7x9ks03BgpE4LZvB/YZYI7y2H+mxkX32LGf5BPB 7RVH3CfAuRyM9zRlHzAzNqtuQ2DO/dQhjQW2io4j8BroIMudDb8RhFWskHRPeIyljqob 4fXnC4SzK28Kndlt4LU9Q2t90fa1QbBZTVPMSWqixjoDXI9ds/O7ZpeEka4yTBFFmcsG LrLz8XX8c2bESBpn9JJO/k1DYHOna6s1vj4juSB5F9x+6hQ5GPbu5GvGNwdTWT+aepJA o4fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=PTXb3rby; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ww5-20020a170907084500b007ae09db5f4esi14308954ejb.657.2022.11.22.21.15.58; Tue, 22 Nov 2022 21:16:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=PTXb3rby; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235698AbiKWFKj (ORCPT + 99 others); Wed, 23 Nov 2022 00:10:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235354AbiKWFKg (ORCPT ); Wed, 23 Nov 2022 00:10:36 -0500 Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE31E677D; Tue, 22 Nov 2022 21:10:34 -0800 (PST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AMK8hLG018733; Tue, 22 Nov 2022 21:10:22 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=TV6BMAeIiWmo9w705vQkZmR+KDIeD1FDKBzuZo4LV90=; b=PTXb3rby5648WkFexDtZw6K2grEy6WPqPzQol0gZF6zjSOs8h8Wquhb583QtCO2XJEZs 9811qQmlclsJ+w/kqgIKSMT5QeNIN1FY/NBvedyDT5i83h+tdahY6edSrBhKu9uMHCpG ORHapraemOoesYYt/TAw8SX12bsCRWfhzIRph83vjqOQZhP1buLELaf8lOrmVQK/YJ/J JQF5Hytg9ZJpAeMtG290HiLMhUl85Q/i2xbYuFku8eLZIcoJJbNB19kB2//Dp0XDC3LV yftos3zHlEp2K2H72aRBIJaKKtodmcoNY0fMNnwP05J+pNH5CZ3zGDDExLmn7dB/AoNM +A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kxyhs5u0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 22 Nov 2022 21:10:21 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Nov 2022 21:10:19 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 22 Nov 2022 21:10:19 -0800 Received: from localhost.localdomain (unknown [10.28.36.166]) by maili.marvell.com (Postfix) with ESMTP id E72D33F7043; Tue, 22 Nov 2022 21:10:13 -0800 (PST) From: Suman Ghosh To: , , , , , , , , , , , CC: Suman Ghosh Subject: [net PATCH] octeontx2-pf: Fix pfc_alloc_status array overflow Date: Wed, 23 Nov 2022 10:40:10 +0530 Message-ID: <20221123051010.2725917-1-sumang@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Proofpoint-GUID: w_6lzc0g2MEEq3Fd_EunJefyQO_39v2n X-Proofpoint-ORIG-GUID: w_6lzc0g2MEEq3Fd_EunJefyQO_39v2n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_02,2022-11-18_01,2022-06-22_01 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750262700892734683?= X-GMAIL-MSGID: =?utf-8?q?1750262700892734683?= This patch addresses pfc_alloc_status array overflow occurring for send queue index value greater than PFC priority. This is causing mbox errors as otx2_get_smq_idx returing invalid smq value. Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support") Signed-off-by: Suman Ghosh --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h index 282db6fe3b08..67aa02bb2b85 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h @@ -884,7 +884,7 @@ static inline void otx2_dma_unmap_page(struct otx2_nic *pfvf, static inline u16 otx2_get_smq_idx(struct otx2_nic *pfvf, u16 qidx) { #ifdef CONFIG_DCB - if (pfvf->pfc_alloc_status[qidx]) + if (qidx < NIX_PF_PFC_PRIO_MAX && pfvf->pfc_alloc_status[qidx]) return pfvf->pfc_schq_list[NIX_TXSCH_LVL_SMQ][qidx]; #endif