From patchwork Wed Nov 23 03:59:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 24684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2581927wrr; Tue, 22 Nov 2022 20:11:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf6CfCQJGGnHkGWePrpoE3ogOCL6bMtFIoOB3dEhCFQknt7AJYz6psG2QWN0l5XZBeZ8W0EM X-Received: by 2002:aa7:c941:0:b0:469:172:4f46 with SMTP id h1-20020aa7c941000000b0046901724f46mr21223965edt.130.1669176679984; Tue, 22 Nov 2022 20:11:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669176679; cv=none; d=google.com; s=arc-20160816; b=Z2+E95fRo+7W9LhO49rv2dWznaOpXUuZEHAIQHoQV3yLFClUY3Cbu3dfrcy2MSIOCy CB90pnS1BJ9/vYaf95loghu0RFt2Z7XtZtKNiyCulKWW0WULLHGtnQTRK2PE7MJiyf+f rIi8FeyatPj7umzf+mWD5sFv2fYBIR8Zqq+u635lOKuYP2Hz3+99hteu8KE0PQh2lKDN T6etPk/YwHnhYb46GDmaTIk6yj6F8mpx2TRVc0F997amL0iQhrGL6Pi6yNbvZZCflkkx gwFq1qJ+g61Ue+aziWgRyGH2q2SGuMf9iiCWn5IWfkxfoZyVmttV6zfiNZfDsgMtYie+ SyYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1IMogDDuyHDobePoH5zW5I1O+NXiNP3jh1ZG/Sk/jKo=; b=HCUcG435BAOCtCYVtq7mLxxyvJJTtijTv7R4UUTSMkuKm7hyVs1gallHKUeDJfbbVV FFmTSIYplTUG6T5UWinKjvE8AQE/+r0jC4+rZM5FKCV63vHR5DI5k/Go95ybHyyZg9Mc 56Po2II7OJtB7l51/n731Pi9dIVViKGZhb9BzyriK/kYe1e+1pIidr6Wka1ymsoCVTBY O4HHCEKK4IYgowbjZ7fWoojcxqSKb3OFf3bAPyPvfqrHDf57afMMTnPSB57WzoKtKoa9 oKUsehi/2f+Ol41T1yUep5NnPtz0aW4qOF5c5ArNhaY1R7Bls+t0c5J/f8UvT8ygg7Mc b0Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f9-20020a056402354900b00462f85ee700si14142065edd.65.2022.11.22.20.10.53; Tue, 22 Nov 2022 20:11:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235661AbiKWEAK (ORCPT + 99 others); Tue, 22 Nov 2022 23:00:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234375AbiKWEAI (ORCPT ); Tue, 22 Nov 2022 23:00:08 -0500 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD4C1E0CAD; Tue, 22 Nov 2022 20:00:03 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VVV17LO_1669175993; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VVV17LO_1669175993) by smtp.aliyun-inc.com; Wed, 23 Nov 2022 12:00:01 +0800 From: Jiapeng Chong To: tgraf@suug.ch Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] lib/test_rhashtable: Remove set but unused variable 'insert_retries' Date: Wed, 23 Nov 2022 11:59:51 +0800 Message-Id: <20221123035951.10720-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750258606349765081?= X-GMAIL-MSGID: =?utf-8?q?1750258606349765081?= Variable 'insert_retries' is not effectively used in the function, so delete it. lib/test_rhashtable.c:437:18: warning: variable 'insert_retries' set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3242 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- lib/test_rhashtable.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 6a8e445c8b55..a7bf3b40b67b 100644 --- a/lib/test_rhashtable.c +++ b/lib/test_rhashtable.c @@ -434,7 +434,7 @@ static int __init test_rhltable(unsigned int entries) static int __init test_rhashtable_max(struct test_obj *array, unsigned int entries) { - unsigned int i, insert_retries = 0; + unsigned int i; int err; test_rht_params.max_size = roundup_pow_of_two(entries / 8); @@ -447,9 +447,7 @@ static int __init test_rhashtable_max(struct test_obj *array, obj->value.id = i * 2; err = insert_retry(&ht, obj, test_rht_params); - if (err > 0) - insert_retries += err; - else if (err) + if (err) return err; }