diff mbox series

[v3,2/2] earlycon: Increase options size

Message ID 20221123-serial-clk-v3-2-49c516980ae0@chromium.org
State New
Headers
Series earlycon: Let users set the clock frequency |

Commit Message

Ricardo Ribalda Nov. 24, 2022, 12:39 p.m. UTC 
  Now that the clock frequency is also part of the options, 16 bytes is
too little.

Without this patch dmesg does not show the whole options, Eg:

earlycon: uart0 at MMIO32 0x00000000fedc9000 (options '115200n8,480000')

instead of: '115200n8,48000000'

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Comments

Jiri Slaby Dec. 6, 2022, 6:53 a.m. UTC | #1 
On 24. 11. 22, 13:39, Ricardo Ribalda wrote:
> Now that the clock frequency is also part of the options, 16 bytes is
> too little.
> 
> Without this patch dmesg does not show the whole options, Eg:
> 
> earlycon: uart0 at MMIO32 0x00000000fedc9000 (options '115200n8,480000')
> 
> instead of: '115200n8,48000000'
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index d657f2a42a7b..f555927195da 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -701,7 +701,7 @@ static inline int uart_poll_timeout(struct uart_port *port)
>   struct earlycon_device {
>   	struct console *con;
>   	struct uart_port port;
> -	char options[16];		/* e.g., 115200n8 */
> +	char options[32];		/* e.g., 115200n8 */
>   	unsigned int baud;
>   };
>   
>
diff mbox series

Patch

diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index d657f2a42a7b..f555927195da 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -701,7 +701,7 @@  static inline int uart_poll_timeout(struct uart_port *port)
 struct earlycon_device {
 	struct console *con;
 	struct uart_port port;
-	char options[16];		/* e.g., 115200n8 */
+	char options[32];		/* e.g., 115200n8 */
 	unsigned int baud;
 };