diff mbox series

[linux-next] perf stat: use sysfs_streq() instead of strncmp()

Message ID 202211222011006572179@zte.com.cn
State New
Headers
Series [linux-next] perf stat: use sysfs_streq() instead of strncmp() |

Commit Message

Yang Yang Nov. 22, 2022, 12:11 p.m. UTC 
  From: Xu Panda <xu.panda@zte.com.cn>

Replace the open-code with sysfs_streq().

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
 tools/perf/util/stat-display.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Namhyung Kim Nov. 22, 2022, 6:31 p.m. UTC | #1 
Hello,

On Tue, Nov 22, 2022 at 4:11 AM <yang.yang29@zte.com.cn> wrote:
>
> From: Xu Panda <xu.panda@zte.com.cn>
>
> Replace the open-code with sysfs_streq().

I don't think it's equivalent to strncmp() and it seems not available
in the tools.

Thanks,
Namhyung

>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
>  tools/perf/util/stat-display.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index f5501760ff2e..1fd9f7e9d2a1 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -463,7 +463,7 @@ static bool valid_only_metric(const char *unit)
>  static const char *fixunit(char *buf, struct evsel *evsel,
>                            const char *unit)
>  {
> -       if (!strncmp(unit, "of all", 6)) {
> +       if (sysfs_streq(unit, "of all")) {
>                 snprintf(buf, 1024, "%s %s", evsel__name(evsel),
>                          unit);
>                 return buf;
> @@ -767,8 +767,7 @@ static void uniquify_event_name(struct evsel *counter)
>         int ret = 0;
>
>         if (counter->uniquified_name || counter->use_config_name ||
> -           !counter->pmu_name || !strncmp(counter->name, counter->pmu_name,
> -                                          strlen(counter->pmu_name)))
> +           !counter->pmu_name || sysfs_streq(counter->name, counter->pmu_name))
>                 return;
>
>         config = strchr(counter->name, '/');
> --
> 2.15.2
diff mbox series

Patch

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index f5501760ff2e..1fd9f7e9d2a1 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -463,7 +463,7 @@  static bool valid_only_metric(const char *unit)
 static const char *fixunit(char *buf, struct evsel *evsel,
 			   const char *unit)
 {
-	if (!strncmp(unit, "of all", 6)) {
+	if (sysfs_streq(unit, "of all")) {
 		snprintf(buf, 1024, "%s %s", evsel__name(evsel),
 			 unit);
 		return buf;
@@ -767,8 +767,7 @@  static void uniquify_event_name(struct evsel *counter)
 	int ret = 0;

 	if (counter->uniquified_name || counter->use_config_name ||
-	    !counter->pmu_name || !strncmp(counter->name, counter->pmu_name,
-					   strlen(counter->pmu_name)))
+	    !counter->pmu_name || sysfs_streq(counter->name, counter->pmu_name))
 		return;

 	config = strchr(counter->name, '/');